| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
|
|
|
|
|
|
|
| |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
|
|
|
|
|
| |
empathy_folks_individual_contains_contact() fails
The individual menu already asserts that's the case. And there is no point
displaying a menu anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
This is needed when being used in a muc.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
This will be needed when using this widget in MUC.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
|
| |
Move it to empathy-contactinfo-utils so we'll be able to re-use it in
empathy-individual-widget as well.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
|
| |
That way we'll pick at least one TpContact if there is only one contact in
the individual and he doesn't have any presence (IRC for example).
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
|
|
| |
God I hate _get functions returning new memory...
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
|
|
| |
The model copies the date so we should free it afterward.
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
| |
|
|
|
|
|
|
|
|
| |
EMPATHY_INDIVIDUAL_STORE_COL_NAME
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663842
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663842
|
|
|
|
|
|
|
|
|
|
| |
It has been deprecated. I asked on #gtk+ and that seems to be the right way to
do this. See
http://git.gnome.org/browse/gtk+/commit/?id=2783158f8d9ca69e5a8fc4a903bfbcc3871a1b02
All these APIs are available since GTK+ 3.0 so we're good.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
|
|
|
| |
It has been deprecated. gdk_window_get_device_position() has been added in
GTK+ 3.0 so we're fine.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663563
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
|
|
| |
This reverts commit 40dc4074eeecb15c82d9eacb3fcd54cff7162440.
We can now depends on it.
|
|
|
|
| |
We weren't using the persona we just created for some reason.
|
|
|
|
|
| |
Unexpectedly, a 0 length buffer causes gdk_pixbuf_loader_write() to return
FALSE without setting @error. Would then segv on error->message.
|
|\ |
|
| |
| |
| |
| | |
Buttons should all be the same size.
|
| |
| |
| |
| |
| | |
The child widgets of the dialpad-widget weren't being shown, so the widget
required a gtk_widget_show_all() to show up. Unexpected :(
|
|/
|
|
|
| |
In that case priv->jid_suffix is NULL, so we should not try to call
remove_jid_suffix().
|
| |
|
|
|
|
|
|
| |
This reverts commit d8153fa21a7beb4229dbba1810eb8544af91db4f.
I was not supposed to commit that yet; the tp-glib API hasn't been released.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
|
|
| |
We have 2 different models having their own set of columns.
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
| |
|
|
|
|
|
|
| |
It's stupid to have to ask to any user of this widget to do this itself.
https://bugzilla.gnome.org/show_bug.cgi?id=662604
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662604
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662843
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
| |
TP_CONNECTION_FEATURE_CAPABILITIES are prepared
Most filter will need those.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
| |
It's cleaner than re-setting the same filter function.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
| |
It just unref one object so dispose is the best place.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
|
|
| |
I wanted to clean the account chooser a bit but the old coding style makes me
cry...
It's good to do anyway, especially if we move this widget to a telepathy-gtk
lib at some point.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
|
| |
Making a call to GetContactAttributes only gets the attributes currently known
to the CM. If a contact is unknown, lookups for the attributes are then queued
and signalled when retrieved. When we receive this signal, we should refilter
the contact list.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662727
|
|
|
|
|
| |
The latter has been deprecated and g_unichar_fully_decompose() is already in
2.30.
|
|
|
|
|
| |
The latter has been deprecated in GLib 2.31 but g_format_size() has been added
in 2.30 so we can already use it without bumping the dep.
|
|
|
|
|
|
| |
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=640846
Signed-off-by: Danielle Madeley <danielle.madeley@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
|
| |
store destruction
This is an exact port of similar code from empathy-individual-store.
https://bugzilla.gnome.org/show_bug.cgi?id=662211
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662211
|
|
|
|
|
| |
This is a reworking, rather than rebasing of the original patch because of
large changes in the codebase.
|
|
|
|
|
| |
Update empathy-individual-widget for these changes. This comes from the rebase
of this branch.
|
|
|
|
|
|
|
| |
Why do we still have this annoying split?
Rebasing this work will pull in a dependency on empathy-string-parser, which is
part of libempathy-gtk. Hence the move.
|
| |
|
|
|
|
|
| |
This patch isn't quite the behaviour I want, but I think it's better than just
re-selecting the first entry every time I type something.
|
| |
|
|
|
|
| |
This means the selection can be activated when the treeview is focused.
|
|
|
|
| |
The default action should be on the right.
|
|
|
|
| |
This was caused by a missing parameter of gtk_dialog_add_buttons().
|
|
|
|
| |
It's no longer used.
|
|
|
|
| |
The user wants to see her most recent history, not what she typed in first.
|
|
|
|
|
|
| |
Let's face it, the whole thing was getting a little unwieldly there in the
UI utils, and if we're going to be using it in more places, let's start by
abstracting it into a widget.
|
|
|
|
|
|
| |
Not doing so can lead to nasty HTML injection from hostile users.
https://bugzilla.gnome.org/show_bug.cgi?id=662035
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
|
|
|
|
|
|
| |
Replace the 'send video' checkbox by an extra button
It's more coherent with the other places where we allow user to start calls.
It also gives better feedback as we can unsensitive this button if the
selected contact doesn't support video.
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
|
|
| |
Also allow caller to get a ref on the EmpathyContact supporting audio/video.
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
|
|
|
|
|
| |
selected
So user can just type the phone number of the contact he wants to call and hit
enter.
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
|
|
|
|
| |
This store is only used for MUC members which doesn't use these fake groups.
Actually we could drop all the group code but it would probably be easier to
completely rewrite the way we display MUC members.
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
|
|
|
|
| |
If Template.html is missing, then you haven't installed Empathy properly
(or set EMPATHY_SRCDIR or whatever in my case). But previously we would
just crash later down this function when passing template_html to
string_with_format() without checking if it's NULL. This patch makes
it fail a little less inscrutably.
|
|
|
|
|
|
|
| |
This will make it easier to replace these with new stuff. The funky
indentation in the callbacks for the subject and title changing is to
make it clear that I didn't change that code; I'll reindent it in
another patch.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-new-message-dialog.c
|
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-new-message-dialog.c
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-individual-menu.c
libempathy-gtk/empathy-new-message-dialog.c
libempathy/empathy-dispatcher.c
libempathy/empathy-dispatcher.h
src/empathy-chat-manager.c
src/empathy-chat-window.c
|
|\ \ |
|
| | | |
|
| |/ |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is only added for Adium themes since ChatTextView ones don't
support markup.
Conflicts:
libempathy-gtk/empathy-chat.c
|
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
libempathy-gtk/empathy-theme-adium.c
|
| |/
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-chat-view.c
libempathy-gtk/empathy-chat-view.h
|
| |
| |
| |
| | |
It's not very helpful to not know which Connection/Channel failed.
|
| |
| |
| |
| |
| |
| | |
We use to crash here trying to get the first element of an empty GPtrArray.
https://bugzilla.gnome.org/show_bug.cgi?id=660586
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=629517
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=629517
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| |
| |
| | |
No change.
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660449
|
| |
| |
| |
| | |
No more ugly marshallers \o/
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658245
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659594
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659594
|
| |
| |
| |
| |
| |
| | |
It's already done that way in individual-widget.
https://bugzilla.gnome.org/show_bug.cgi?id=659816
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| |
| |
| | |
This work around bug #657621
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| |
| |
| | |
Fix the glade file for sizing issues
Bug #646630
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There are a few improvements we can make to the search entry icons in
the log window, which this patch tries to fix.
- icons in entries are usually symbolic in GNOME 3, so I made the icons
symbolic.
- I merged the two icons in just one on the right using the shell-style,
i.e. the search icon turns into a clear action once there's some text
typed into the entry (Documents also uses the same style for its
search entry).
https://bugzilla.gnome.org/show_bug.cgi?id=659298
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Folks is in the way of deprecating the
folks_persona_store_get_can_{alias,group}_personas methods in favour
of directly checking alias and groups properties via
folks_persona_store_get_always_writeable_properties and
folks_persona_get_writeable_properties.
|
| |
| |
| |
| |
| |
| |
| | |
This ensure that the window has resized before setting the position
because GtkPaned needs to know its size allocation
https://bugzilla.gnome.org/show_bug.cgi?id=632357
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=652985
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=652985
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659141
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659141
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| |
| |
| | |
cache
GtkTreeRowReference keeps a ref on the store introducing a ref cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| | |
GtkTreeRowReference keeps a ref on the store introducing a ref cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
EmpathyIndividualWidget (used both in the contact information dialogs
and in the tooltips) use a GtkTable internally to layout contact
details.
GtkTable is being deprecated, and does not correctly support
width-for-height size negotiation. So, there are cases where we get
funny overallocations bugs for wrapping GtkLabels; this is especially
annoying for tooltips, as they tend to grow huge vertically.
Porting the code to use a better container such as GtkGrid solves the
bug. This patch does not cover all the use of GtkTable in
EmpathyIndividualWidget, but enough to fix the tooltip sizing.
https://bugzilla.gnome.org/show_bug.cgi?id=658857
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, the 'set' field of the stack-allocated 'data' structure was
not initialized. It's explicitly set to TRUE if the account is found,
but never otherwise set; so if the account is not found, this function
returned random garbage.
Reviewed-by: Xavier Claessens <xclaesse@gmail.com>
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658821
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=648315
|
| | |
|
| |
| |
| |
| |
| |
| | |
the process
https://bugzilla.gnome.org/show_bug.cgi?id=658644
|
| |
| |
| |
| |
| |
| | |
the process
https://bugzilla.gnome.org/show_bug.cgi?id=658644
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently "Who"-list is sorted with "g_strcmp0 (name)" which
is not what we want (e.g. "Chris" becomes before "bob" because of
the initial capital letter).
Start sorting using g_utf8_collate_key().
https://bugzilla.gnome.org/show_bug.cgi?id=658336
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows Gtk+ to style the button differently to indicate that it
will be pressed when the user hits Enter; it also fixes hitting enter in
the New Conversation dialog, which does not consider GTK_RESPONSE_ACCEPT
to be a reasonable response and ignores it. So we get a bug fix and
better styling in exchange for less code!
https://bugzilla.gnome.org/show_bug.cgi?id=658343
|
| |
| |
| |
| |
| | |
We already use it to check if a contact is in favourite or not.
The contact manager should probably be killed at some point any way.
|
| | |
|
|/
|
|
|
|
| |
So that it raises up from the toolbar below.
https://bugzilla.gnome.org/show_bug.cgi?id=657954
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657843
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657843
|
|
|
|
|
|
|
| |
Center the account chooser and align the search widget to the right of the
toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=657842
|
|
|
|
|
|
|
|
|
|
|
| |
When a contact cannot be obtained from an individual, icon_name and
contact will be NULL, leading to g_hash_table_lookup for a NULL-value,
segfaulting.
Although there's probably an underlying error somewhere, the NULL case
should be handled, being a valid return value for the method;
https://bugzilla.gnome.org/show_bug.cgi?id=657914
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
g_date_time_new_from_unix_local() reads a Unix timestamp (which is defined
to be in UTC) and sets the timezone for the GDateTime to be the local timezone.
Thus when we format it, we get times in local time.
g_date_time_new_from_unix_utc() is not correct, because it sets the timezone
to UTC.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=656189
|
|/
|
|
|
|
|
| |
Correctly group our subregexp otherwise hostnames like the following
won't be recognized due to the way things expand:
a.com
example.c-om
|
| |
|
|\ |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=657616
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous algorithm was O(n^2) with the number of contacts. Each contact can
be in several groups, so when a contact is added or updated, we iterated over
all the contact list to find the rows representing the contact. When connecting
to an account and getting all the contacts, this was too slow.
The groups are stored in the GtkTreeStore and suffer from the same problem: to
look for a group, it needed to iterate on all contacts.
The new algorithm maintains a hash from the contact to the list of rows
representing it, and another hash from the group to the row representing it.
On Empathy 2.30.2 when tested on MeeGo with 300 contacts, loading the contacts
is faster: roughly 9 seconds before the patch, 3 seconds after.
On Empathy 3.1.5, it seems to load in background so I don't know how to measure
the time lost in GtkTreeStore. But before the patch, GProf says 23% is lost in
individual_store_find_contact_foreach(), and after the patch it is not visible
anymore. And "time" says we win 5s of CPU when starting+quitting Empathy:
Before the patch: After the patch:
real 0m23.485s real 0m23.460s
user 0m13.805s user 0m8.305s
sys 0m0.308s sys 0m0.316s
https://bugzilla.gnome.org/show_bug.cgi?id=657086
|
|
|
|
|
| |
Having to double click on a day to update it was really confusing and most
people (including me!) were just thinking that was not working.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=650112
|
|
|
|
|
|
| |
Dialog asking user to pick an account from a pre-defined list.
https://bugzilla.gnome.org/show_bug.cgi?id=650112
|
|
|
|
| |
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
| |
It used to be right in the middle of actions on the contact.
|
|
|
|
|
|
| |
* Fix an unclear error string in the avatar chooser
when saving camera taken image to file.
Fixes bug #657166
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
|
|
| |
No change has been done, this is just to keep commits simpler.
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a missing unref in GIO, the input stream is leaked by GFileIcon, so
if we rely on its FD being implicitly closed when the stream is finalised,
we'll end up leaking (lots of) file descriptors.
As well as fixing the unref in GIO (see: bgo#657206), we now explicitly
close the input stream so that even if the stream object is leaked, the FD
isn't.
Closes: bgo#656682
|
|\ |
|
| |
| |
| |
| |
| |
| | |
The verb, "Find", is already present on the left of the entry.
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This has the much nicer side-effect that if it gets thrown off the
side because it doesn't have enough room, the icon and label will be
shown in the expander.
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|/
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657104
|
|
|
|
|
|
|
| |
Closes: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a
valid TpContact
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|
|
|
|
|
|
| |
Helps: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a
valid TpContact
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=656934
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=656934
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=656934
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=656866
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_CAPABILITIES
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_CAPABILITIES
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_CONTACT_INFO
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_CONTACT_INFO
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
| |
| |
| |
| |
| |
| | |
TP_CONNECTION_FEATURE_AVATAR_REQUIREMENTS
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
|/
|
|
|
|
|
|
|
| |
TP_CONNECTION_FEATURE_CAPABILITIES,
Also simplify empathy_account_chooser_filter_supports_chatrooms in the
process.
https://bugzilla.gnome.org/show_bug.cgi?id=656831
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- EmpathyChannelFactory has been changed to EmpathyClientFactory and inherit
from TpAutomaticClientFactory.
- We now always use the _with_am variant of TpSimple* constructors
- We define our own factory as default.
- Replace empathy_get_account_for_connection() by tp_connection_get_account()
- The factory is passed to EmpathyTpChat and TpyCallChannel
- Use tp_simple_client_factory_ensure_account() instead of
tp_account_manager_ensure_account().
- Rely on the factory to prepare connection features.
This should ensure that all the TpProxy and TpContact objects created in
Empathy are shared and use EmpathyClientFactory.
https://bugzilla.gnome.org/show_bug.cgi?id=655799
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Does not currently highlight the row.
|
| |
| |
| |
| |
| | |
N.B. This has not been properly tested, because I'm not actually sure how to
exhaust this codepath.
|
| |
| |
| |
| |
| | |
It is now required for the log viewer, furthermore it will be required once
we remove non-adium themes.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
It should also be used for the Adium theme, but this also supports fonts
specified in the Adium theme, which we need to support.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Still some commented out code to reimplement.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
This file is currently optionally built, but if the logviewer is going to
depend on WebKit, maybe that's a bad idea? Maybe we should just make WebKit
required (this will probably happen when we require Adium themes in the future).
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The widget is currently bolted in alongside the existing log display widget
for comparison. This includes some debugging cruft like showing the secret
notebook tabs.
The webview is populated from the store_events treestore, allowing all of the
existing node-management and ordering code to be used. Attempting to replace
this logic in Javascript was demonstratably too hard. This approach keeps the
Javascript code down to the 4 GtkTreeModel signals.
TODO:
- icons
- pretty printed dates
- expanders
- supporting smileys, links, etc.
- using the correct font, etc.
- removing the debugging
|
|\ \
| | |
| | |
| | | |
https://bugzilla.gnome.org/show_bug.cgi?id=656167
|
| | |
| | |
| | |
| | |
| | |
| | | |
This is the same area as is used for the custom status dialog's scrolled
window. The content area turns out very slightly smaller, because the
area includes the tree view's header.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Folks' AvatarDetails.avatar is now a GLoadableIcon rather than a GFile.
Closes: bgo#655212
https://bugzilla.gnome.org/show_bug.cgi?id=655212
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Also factor out empathy_call_set_stream_properties().
|
|/ /
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=656065
|
| |
| |
| |
| |
| |
| | |
It's not used any more and a generic widget shouldn't need it.
https://bugzilla.gnome.org/show_bug.cgi?id=656020
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=656020
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=656020
|
| |
| |
| |
| |
| |
| |
| | |
This is a pure code refactoring from EmpathyInviteParticipantDialog, this
widget is not generic yet.
https://bugzilla.gnome.org/show_bug.cgi?id=656020
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=655959
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=655884
|
| | |
|
| |
| |
| |
| |
| |
| | |
running
It's not safe to assume that the EmpathyContact stays alive.
|
| |
| |
| |
| |
| |
| | |
The first argument of g_date_time_difference() should be the older timestamp.
https://bugzilla.gnome.org/show_bug.cgi?id=654958
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=632874
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The dialpad is shared between empathy-call and empathy-av.
Really it would be nice to make the dialpad its own little widget that emits
signals with DTMF event ids, but I've got things to get done.
Conflicts:
libempathy-gtk/empathy-ui-utils.c
src/empathy-call-window.c
src/empathy-streamed-media-window.c
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Warn if making this assumption.
|
|\ \ \
| |_|/
|/| | |
|
| | | |
|
| |/
| |
| |
| |
| |
| |
| | |
This also fixes the problem where dragging with no contact selected drags the
previously selected contact.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=558942
|
| |
| |
| |
| |
| |
| |
| | |
Track what kind of event generated the populate-popup event and then use the
cursor position or mouse position as appropriate.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=654669
|
|\ \
| | |
| | |
| | |
| | | |
Fixes: <https://bugzilla.gnome.org/show_bug.cgi?id=654552>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As mentioned on <https://bugzilla.gnome.org/show_bug.cgi?id=654552#c13>,
this makes the password hint text be right up against the field it's
hinting about, at the cost of even more ugly space between it and
the Advanced expander. I think this is the lesser of two evils.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The 'account’ parameter in Telepathy, to which this regex applies, is
the ‘nickname’ in IRC parlance.
(I'm about to add a regex for what IRC calls ‘usernames’.)
|
| | |
| | |
| | |
| | |
| | | |
This addresses Nick's concern on
https://bugzilla.gnome.org/show_bug.cgi?id=654552
|
| |/
| |
| |
| |
| |
| |
| | |
-Move the Real Name and Quit Message to the advanced section
-Add a new Username field to the advanced section
https://bugzilla.gnome.org/show_bug.cgi?id=654552
|
|/
|
|
|
|
|
|
| |
Default to Call channels again.
https://bugzilla.gnome.org/show_bug.cgi?id=654611
This reverts commit 1cacc0945f81e0513013b83ca7488589dd6c61f7.
|