aboutsummaryrefslogtreecommitdiffstats
path: root/libempathy-gtk
Commit message (Collapse)AuthorAgeFilesLines
* individual-store: contacts in Favourite People are not UngroupedDanielle Madeley2012-01-271-47/+53
| | | | | | | Rearrange the code that puts people into groups a bit in a way I think makes more sense. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=668796
* empathy-tls-dialog: add a title for screenshotsDanielle Madeley2012-01-261-0/+1
| | | | Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=668681
* Merge branch 'highlight-regex'Will Thompson2012-01-268-26/+175
|\
| * EmpathyChat: cache highlight regex.Will Thompson2012-01-251-17/+45
| |
| * EmpathyChat: track self contact.Will Thompson2012-01-191-8/+27
| |
| * Don't highlight messages in 1-1 chats.Will Thompson2012-01-191-0/+4
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=576912
| * Don't highlight messages the user sent themselfWill Thompson2012-01-191-0/+4
| | | | | | | | | | If a message is outgoing, then why on earth would we check whether it mentions our own nick and highlight it?
| * Move empathy_message_should_highlight to EmpathyChatWill Thompson2012-01-191-3/+71
| | | | | | | | | | | | This will give us a place to cache the GRegex object. (Of course, this also depends on monitoring changes to the TpChat's self contact's alias, and changes to the TpChat's self contact!)
| * EmpathyChat: include should_highlight in ::new-messageWill Thompson2012-01-191-2/+11
| | | | | | | | | | This allows EmpathyChatWindow to use this rather than calling empathy_message_should_highlight() itself.
| * chat_view_append_message: take a should_highlight argumentWill Thompson2012-01-198-20/+37
| | | | | | | | | | | | | | | | | | | | Rather than the EmpathyChatView implementations calling empathy_message_should_highlight() themselves, this patch makes EmpathyChat take responsibility for doing so. The theme preview in Preferences, whether deliberately or otherwise, highlights the line in which Juliet mentions Romeo. This behaviour is preserved.
* | don't display 'No topic defined' if topic are not supportedGuillaume Desmottes2012-01-241-4/+8
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=668502
* | contact-widget: merge grid_contact and main_grid_contactGuillaume Desmottes2012-01-231-70/+52
| | | | | | | | | | | | No point keeping the extra widgets now. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | move vbox_avatar to grid_contactGuillaume Desmottes2012-01-231-12/+13
| | | | | | | | | | | | That way the avatar is no longer miss aligned with the other fields. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | contact-widget: move hbox_presence to grid_contactGuillaume Desmottes2012-01-231-27/+16
| | | | | | | | | | | | There is no point keeping this even more complicated that it already is. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | empathy-contact-widget: replace hbox_contact by a GtkGridGuillaume Desmottes2012-01-231-6/+5
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | contact-widget: stop storing hbox_contactGuillaume Desmottes2012-01-231-2/+0
| | | | | | | | | | | | It's not used. https://bugzilla.gnome.org/show_bug.cgi?id=666714
* | remove empathy_contact_personal_dialog_show()Guillaume Desmottes2012-01-202-54/+0
|/
* account-widget: allow JID such as 'test@localhost'Guillaume Desmottes2012-01-171-1/+1
| | | | | | Thanks to marc@ttux.net for his help. https://bugzilla.gnome.org/show_bug.cgi?id=660856
* don't free content of the list returned by ↵Guillaume Desmottes2012-01-171-2/+0
| | | | | | empathy_connection_aggregator_get_all_groups() https://bugzilla.gnome.org/show_bug.cgi?id=667037
* empathy_pixbuf_avatar_from_individual_scaled_async: set an error if no avatarGuillaume Desmottes2012-01-171-11/+10
| | | | | | | It's fair for the caller to expect the error the be set if the _finish() function returns NULL. https://bugzilla.gnome.org/show_bug.cgi?id=667037
* individual-view: remove GTK+ workaroundsGuillaume Desmottes2012-01-161-68/+0
| | | | They have been properly fixed since a while.
* individual-view: use tp_g_signal_connect_object() to connect the destroy sigGuillaume Desmottes2012-01-161-2/+4
| | | | | | This ensure that we won't call the callback when disposing the widget. https://bugzilla.gnome.org/show_bug.cgi?id=667676
* filter_result_callback_data_new: add some checksGuillaume Desmottes2012-01-161-0/+4
|
* account-widget-irc: fix label position in the gridGuillaume Desmottes2012-01-131-0/+1
|
* be less restrictive regarding the Service formatGuillaume Desmottes2012-01-131-11/+17
|
* irc-network-chooser-dialog: be more NULL-safeGuillaume Desmottes2012-01-131-1/+4
|
* irc-network-chooser: set the account serviceGuillaume Desmottes2012-01-131-0/+35
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=667791
* EmpathySoundManager: passing a GtkWidget is optionalXavier Claessens2012-01-101-10/+19
|
* contact-chooser: keep a ref on the TpContact we requestedGuillaume Desmottes2012-01-061-2/+20
| | | | | | Kinda hacky but that's the best we can do without major changes in Folks. https://bugzilla.gnome.org/show_bug.cgi?id=666531
* individual-widget: display champlain map in tooltipsGuillaume Desmottes2011-12-221-2/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661500
* individual_grid_destroy: remove the ChamplainEmbedView from its containerGuillaume Desmottes2011-12-221-0/+11
| | | | | | | The EmpathyIndividualWidget object is re-used for tooltips so we should remove the ChamplainEmbedView before trying to add a new one. https://bugzilla.gnome.org/show_bug.cgi?id=661500
* add new-account-dialogGuillaume Desmottes2011-12-223-0/+273
| | | | | This introduces some code duplication with the assistant but it's going to die soon anyway.
* account-widget: display the buttons in simple mode as wellGuillaume Desmottes2011-12-222-55/+57
| | | | | We'll need them when creating the account. Adding a simple function to manually hide them in the assistant for now.
* account-widget: modernize dipose functionGuillaume Desmottes2011-12-221-20/+2
|
* account-widget: use the self->priv patternGuillaume Desmottes2011-12-222-326/+287
| | | | I'm changing this file a lot so while I'm on it...
* properly handle accounts using an external storageGuillaume Desmottes2011-12-221-208/+20
|
* we can now use the stock close buttonGuillaume Desmottes2011-12-221-10/+1
| | | | | We should use the official accelerator for closing dialog. If widget fields are also using the 'C' accelerator then they should be fixed.
* remove old commentGuillaume Desmottes2011-12-221-1/+0
| | | | We fire the close signal a bit later in this function
* no need to control the cancel button sensitivity any moreGuillaume Desmottes2011-12-221-2/+0
| | | | | It should also be displayed now as we always want the user to be able to close the dialog.
* Don't show the presence twiceDanielle Madeley2011-12-222-1/+4
|
* Add a close signal, emitted by both cancel and applyDanielle Madeley2011-12-221-0/+14
|
* Begin combining the dialogsDanielle Madeley2011-12-221-2/+3
| | | | | | | This is not functional yet, but it does compile and kindof demonstrate what's going to happen. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=652670
* coding style fixEMPATHY_3_3_3Guillaume Desmottes2011-12-201-1/+1
|
* add empathy_move_to_window_desktopGuillaume Desmottes2011-12-192-0/+120
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=649208
* Stop passing an EmpathyContact to menu_item_new() fonctionsGuillaume Desmottes2011-12-143-152/+64
| | | | | | Best to always use an individual so we don't have 2 code paths to maintain. https://bugzilla.gnome.org/show_bug.cgi?id=666163
* individual-menu: export only the methods we needGuillaume Desmottes2011-12-142-33/+41
| | | | | | | No need to export everything. I added prototypes in the C file to not have to move everything upside down. https://bugzilla.gnome.org/show_bug.cgi?id=666163
* remove useless includes of empathy-contact-manager.hGuillaume Desmottes2011-12-143-3/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* remove EMPATHY_CONTACT_WIDGET_EDIT_FAVOURITEGuillaume Desmottes2011-12-142-72/+2
| | | | | | | It's not used any more and this code was the last one using the contact manager. https://bugzilla.gnome.org/show_bug.cgi?id=660547
* remove unused empathy_contact_edit_dialog_show()Guillaume Desmottes2011-12-142-62/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* Show a contact as blocked if *all* is personas are blockedGuillaume Desmottes2011-12-141-4/+7
| | | | | | It's clearer that way. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* individual_menu_add_personas: add the block menu item, if neededGuillaume Desmottes2011-12-141-0/+22
| | | | | | | | | | | | | This allow user to select the personas he wants to block. Note that I didn't pass an EmpathyContact as second argument to empathy_individiual_block_menu_item_new() as we currently do with most item_new() methods. Instead I just craft a new individual containing only the persona we care about. This approach is much cleaner as we don't have to deal with 2 different code paths. I filed bug #666163 to do the same with the existing functions. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* remove empathy-contact-menuGuillaume Desmottes2011-12-143-723/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* chat: use an EmpathyIndividualMenuGuillaume Desmottes2011-12-141-8/+20
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* add EMPATHY_INDIVIDUAL_FEATURE_BLOCKGuillaume Desmottes2011-12-142-0/+216
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665038
* remove EMPATHY_INDIVIDUAL_FEATURE_ALLGuillaume Desmottes2011-12-142-2/+0
| | | | | | It's a bit fragile, user should say which features he wants. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* individual-menu: allow priv->store to be NULLGuillaume Desmottes2011-12-141-2/+3
| | | | | | | We already checks if it's a IndividualStoreChannel before using it so that's safe. https://bugzilla.gnome.org/show_bug.cgi?id=665038
* Deal with empathy_create_individual_from_tp_contact() returning NULLGuillaume Desmottes2011-12-142-0/+4
| | | | | | Shouldn't really happen in practice but better to be safe than sorry. https://bugzilla.gnome.org/show_bug.cgi?id=665853
* log-window: update buttons if contact's caps are updatedGuillaume Desmottes2011-12-061-1/+22
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=665592
* factor out do_update_buttons_sensitivity()Guillaume Desmottes2011-12-061-34/+41
| | | | | | | | This fix a bug with button_video_binding not being re-installed when a contact supporting video was selected. It was only re-installed when using the contact from the selected event. https://bugzilla.gnome.org/show_bug.cgi?id=665592
* log-window: include empathy-geometry.hGuillaume Desmottes2011-12-051-0/+1
|
* log-window: save window geometryGuillaume Desmottes2011-12-051-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=664209
* contact-blocking-dialog: stop using EmpathyContactManagerGuillaume Desmottes2011-12-021-19/+9
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=660547
* use the individual edit dialog when pressing F2Guillaume Desmottes2011-11-301-9/+2
| | | | | We already use it when using the menu so there is no reason to keep using the old one.
* ui-utils: don't expect that cancellable is not NULLGuillaume Desmottes2011-11-301-2/+3
| | | | cancellable are always optional so this code should be NULL safe.
* groups-widget: use empathy_connection_aggregator_get_all_groups()Guillaume Desmottes2011-11-291-8/+8
| | | | | | | | We have to prepare the contact groups feature and ensure that the singleton is still alive. The 'empathy' process is the only one allowing user to change contact groups so we just have to do it there. https://bugzilla.gnome.org/show_bug.cgi?id=665121
* add missing empathy-contact-list.h includeGuillaume Desmottes2011-11-281-0/+1
| | | | | | | | For some reason, gcc starts complaining about this as soon as I remove EmpathyContactListFlags from empathy-contact-list.h ?! If you have an explanation for this please let me know... https://bugzilla.gnome.org/show_bug.cgi?id=663328
* contact-menu: stop using empathy_contact_manager_get_flags_for_connection()Guillaume Desmottes2011-11-281-15/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663328
* Properly update the 'simple' themeGuillaume Desmottes2011-11-251-3/+13
| | | | | | | | We have to call the callback manually to update the theme when it's changed. Also make sure that style-set signal is only connected once and we update the theme only if the 'simple' one is used. https://bugzilla.gnome.org/show_bug.cgi?id=664795
* remove unused variablesGuillaume Desmottes2011-11-241-3/+0
|
* Remove obsolete contact-list-{store,view}Guillaume Desmottes2011-11-246-4116/+0
| | | | | | Hourrah \o/ https://bugzilla.gnome.org/show_bug.cgi?id=663387
* chat: use the individual view/store rather than the contact oneGuillaume Desmottes2011-11-241-14/+22
| | | | | | | | | The great unification ! EmpathyChat was the last user of the contact store/view, everything now use the individual ones. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add initial_loading() as a virtual methodGuillaume Desmottes2011-11-244-14/+37
| | | | | | This allows us to remove setup_idle_id as a protected variable. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add empathy_individual_store_refresh_individual() as a protected methodGuillaume Desmottes2011-11-243-11/+22
| | | | | | This allows us to remove show_active as a protected variable. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* Add individual-store-channelGuillaume Desmottes2011-11-243-0/+397
| | | | | | This will allow us to use the individual view to display muc members. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add EMPATHY_INDIVIDUAL_FEATURE_ADD_CONTACTGuillaume Desmottes2011-11-243-4/+149
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387
* factor out empathy_create_individual_from_tp_contact()Guillaume Desmottes2011-11-241-20/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387
* Abstract the individual storeGuillaume Desmottes2011-11-247-177/+400
| | | | | | | We now have EmpathyIndividualStoreManager which implements the store using EmpathyIndividualManager as its contact source. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* individual-store: expose some attributes and methods as 'protected'Guillaume Desmottes2011-11-242-30/+44
| | | | | | This will be needed when abstracting EmpathyIndividualStore. https://bugzilla.gnome.org/show_bug.cgi?id=663387
* add empathy-bad-password-dialogGuillaume Desmottes2011-11-233-0/+262
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661640
* Abstract EmpathyPasswordDialog to EmpathyBasePasswordDialogGuillaume Desmottes2011-11-235-196/+391
| | | | | | | I'm going to implement a slidely different version of this dialog so best to re-use as much code as possible. https://bugzilla.gnome.org/show_bug.cgi?id=661640
* password-dialog: use self->priv patternGuillaume Desmottes2011-11-232-68/+68
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661640
* fix GTK_BOX castsGuillaume Desmottes2011-11-211-1/+1
|
* use gtk_box_new() instead of gtk_[h,v]box_new()Guillaume Desmottes2011-11-2111-21/+23
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* use gtk_paned_new() instead of gtk_hpaned_new()Guillaume Desmottes2011-11-211-1/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* use gtk_separator_new() instead of gtk_hseparator_new()Guillaume Desmottes2011-11-211-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* Use _unref instead of _free _destroy when possible.unrefXavier Claessens2011-11-1612-17/+17
| | | | | | | | | | | Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref. I used this command to generate this patch: for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done See Danielle's blog for explanation of possible bug _free can do: http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
* individual-view: don't display menu if ↵Guillaume Desmottes2011-11-161-0/+4
| | | | | | | | | empathy_folks_individual_contains_contact() fails The individual menu already asserts that's the case. And there is no point displaying a menu anyway. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-view: add an option to disable uninteresting filteringGuillaume Desmottes2011-11-162-24/+76
| | | | | | This is needed when being used in a muc. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-widget: display channels list if availableGuillaume Desmottes2011-11-161-0/+22
| | | | | | This will be needed when using this widget in MUC. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* factor out empathy_contact_info_create_channel_list_label()Guillaume Desmottes2011-11-163-81/+106
| | | | | | | Move it to empathy-contactinfo-utils so we'll be able to re-use it in empathy-individual-widget as well. https://bugzilla.gnome.org/show_bug.cgi?id=663763
* update_weak_contact: use a greater or equal comparaisonGuillaume Desmottes2011-11-161-1/+1
| | | | | | | That way we'll pick at least one TpContact if there is only one contact in the individual and he doesn't have any presence (IRC for example). https://bugzilla.gnome.org/show_bug.cgi?id=663763
* fix separator leakGuillaume Desmottes2011-11-141-0/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663873
* don't leak uri returned by g_file_get_uri()Guillaume Desmottes2011-11-141-2/+4
| | | | | | God I hate _get functions returning new memory... https://bugzilla.gnome.org/show_bug.cgi?id=663873
* fix GDate leaks when getting dates from the modelGuillaume Desmottes2011-11-141-1/+10
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663873
* free GDate leaks when inserting them into the modelGuillaume Desmottes2011-11-141-4/+23
| | | | | | The model copies the date so we should free it afterward. https://bugzilla.gnome.org/show_bug.cgi?id=663873
* coding style fixesGuillaume Desmottes2011-11-141-1/+1
|
* empathy_individual_store_remove_individual: use ↵Guillaume Desmottes2011-11-141-1/+1
| | | | | | | | EMPATHY_INDIVIDUAL_STORE_COL_NAME https://bugzilla.gnome.org/show_bug.cgi?id=663387 https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-view: remove explicit boolean comparaisonsGuillaume Desmottes2011-11-141-10/+10
| | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387 https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-store: use self->priv patternGuillaume Desmottes2011-11-142-169/+100
| | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=663387 https://bugzilla.gnome.org/show_bug.cgi?id=663763
* individual-widget: factor out add_row()Guillaume Desmottes2011-11-141-14/+22
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663763
* details_update_show: skip empty fieldGuillaume Desmottes2011-11-141-0/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663763
* Don't turn on echo cancellation on the sink if it's for raw conferencesSjoerd Simons2011-11-111-3/+8
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663842
* Don't turn on echo cancellation on the source if it's for raw conferencesSjoerd Simons2011-11-112-4/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663842
* stop using gtk_widget_get_pointer()Guillaume Desmottes2011-11-112-2/+7
| | | | | | | | | | It has been deprecated. I asked on #gtk+ and that seems to be the right way to do this. See http://git.gnome.org/browse/gtk+/commit/?id=2783158f8d9ca69e5a8fc4a903bfbcc3871a1b02 All these APIs are available since GTK+ 3.0 so we're good. https://bugzilla.gnome.org/show_bug.cgi?id=662903
* stop using gdk_window_get_pointer()Guillaume Desmottes2011-11-111-1/+1
| | | | | | | It has been deprecated. gdk_window_get_device_position() has been added in GTK+ 3.0 so we're fine. https://bugzilla.gnome.org/show_bug.cgi?id=662903
* doesn't allow to send socket filesGuillaume Desmottes2011-11-101-0/+24
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663563
* empathy_contact_block_menu_item_new: remove unused EmpathyContactManagerGuillaume Desmottes2011-11-091-3/+0
|
* contact-list-view: use empathy_contact_remove_from_contact_list()Guillaume Desmottes2011-11-081-5/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663327
* contact-dialog: stop using EmpathyContactManagerGuillaume Desmottes2011-11-081-25/+6
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663327
* contact-search-dialog: stop using EmpathyContactManagerGuillaume Desmottes2011-11-081-10/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=663327
* individual dialog: use tp-glib blocking APIGuillaume Desmottes2011-11-081-8/+5
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661805
* contact-dialogs: use tp-glib blocking APIGuillaume Desmottes2011-11-081-19/+14
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661805
* contact-menu: use tp-glib blocking APIGuillaume Desmottes2011-11-081-16/+14
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661805
* Revert "Revert "contact-blocking-dialog: use tp-glib high level blocking API""Guillaume Desmottes2011-11-082-319/+158
| | | | | | This reverts commit 40dc4074eeecb15c82d9eacb3fcd54cff7162440. We can now depends on it.
* contact-chooser: fix TpfPersona leakGuillaume Desmottes2011-11-081-5/+6
| | | | We weren't using the persona we just created for some reason.
* Don't crash when the buffer has length 0Danielle Madeley2011-11-071-1/+4
| | | | | Unexpectedly, a 0 length buffer causes gdk_pixbuf_loader_write() to return FALSE without setting @error. Would then segv on error->message.
* Merge branch 'ui-fixes'Danielle Madeley2011-11-051-0/+6
|\
| * dialpad-widget: make grid rows/columns homogeneousDanielle Madeley2011-11-041-0/+2
| | | | | | | | Buttons should all be the same size.
| * dialpad-widget: ensure able to show with gtk_widget_show()Danielle Madeley2011-11-041-0/+4
| | | | | | | | | | The child widgets of the dialpad-widget weren't being shown, so the widget required a gtk_widget_show_all() to show up. Unexpected :(
* | Fix crash when opening GOA facebook account settingsXavier Claessens2011-11-041-1/+1
|/ | | | | In that case priv->jid_suffix is NULL, so we should not try to call remove_jid_suffix().
* Fix set-but-not-used build warningXavier Claessens2011-11-021-2/+2
|
* Revert "contact-blocking-dialog: use tp-glib high level blocking API"Guillaume Desmottes2011-11-022-158/+319
| | | | | | This reverts commit d8153fa21a7beb4229dbba1810eb8544af91db4f. I was not supposed to commit that yet; the tp-glib API hasn't been released.
* contact-blocking-dialog: use tp-glib high level blocking APIGuillaume Desmottes2011-11-022-319/+158
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661805
* contact-blocking-dialog: split COL_* enumsGuillaume Desmottes2011-11-021-15/+21
| | | | | | We have 2 different models having their own set of columns. https://bugzilla.gnome.org/show_bug.cgi?id=661805
* individual-widget: port to GtkGridGuillaume Desmottes2011-11-011-11/+11
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* dialpad-widget: port to GtkGridGuillaume Desmottes2011-11-011-5/+5
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* contact-widget: port to GtkGridGuillaume Desmottes2011-11-012-81/+57
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* account-widget-*: port to GtkGridGuillaume Desmottes2011-11-0113-483/+126
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662903
* coding style fixGuillaume Desmottes2011-11-011-2/+2
|
* empathy_account_chooser_set_account: select account later if not ready yetGuillaume Desmottes2011-10-282-34/+28
| | | | | | It's stupid to have to ask to any user of this widget to do this itself. https://bugzilla.gnome.org/show_bug.cgi?id=662604
* account-chooser: factor out select_account()Guillaume Desmottes2011-10-281-11/+18
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662604
* add empathy_contact_chooser_show_tree_view()Guillaume Desmottes2011-10-282-5/+16
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662843
* refilter if the TpConnection of a TpAccount is changedGuillaume Desmottes2011-10-271-0/+16
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* factor out update_account()Guillaume Desmottes2011-10-271-3/+13
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* account-chooser: make sure that TP_ACCOUNT_FEATURE_CONNECTION and ↵Guillaume Desmottes2011-10-271-0/+10
| | | | | | | | TP_CONNECTION_FEATURE_CAPABILITIES are prepared Most filter will need those. https://bugzilla.gnome.org/show_bug.cgi?id=662609
* log-window: use empathy_account_chooser_refilter()Guillaume Desmottes2011-10-271-6/+6
| | | | | | It's cleaner than re-setting the same filter function. https://bugzilla.gnome.org/show_bug.cgi?id=662609
* factor out empathy_account_chooser_refilter()Guillaume Desmottes2011-10-272-5/+13
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* move pre-defined filter at the end of the filesGuillaume Desmottes2011-10-272-28/+32
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* account-chooser: replace finalize by disposeGuillaume Desmottes2011-10-271-5/+5
| | | | | | It just unref one object so dispose is the best place. https://bugzilla.gnome.org/show_bug.cgi?id=662609
* account-chooser: use tp_g_signal_connect_object()Guillaume Desmottes2011-10-271-12/+5
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* account-chooser: use self->priv patternGuillaume Desmottes2011-10-272-75/+39
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* inline account_chooser_setup()Guillaume Desmottes2011-10-271-136/+129
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* move down empathy_account_chooser_class_init()Guillaume Desmottes2011-10-271-46/+36
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662609
* account-chooser: port to new coding styleGuillaume Desmottes2011-10-272-715/+740
| | | | | | | | | | I wanted to clean the account chooser a bit but the old coding style makes me cry... It's good to do anyway, especially if we move this widget to a telepathy-gtk lib at some point. https://bugzilla.gnome.org/show_bug.cgi?id=662609
* contact-chooser: refilter when the tmp contacts change capabilitiesDanielle Madeley2011-10-261-0/+12
| | | | | | | | | Making a call to GetContactAttributes only gets the attributes currently known to the CM. If a contact is unknown, lookups for the attributes are then queued and signalled when retrieved. When we receive this signal, we should refilter the contact list. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662727
* use g_unichar_fully_decompose instead of g_unicode_canonical_decompositionGuillaume Desmottes2011-10-251-8/+1
| | | | | The latter has been deprecated and g_unichar_fully_decompose() is already in 2.30.
* use g_format_size instead of g_format_size_for_displayGuillaume Desmottes2011-10-251-2/+2
| | | | | The latter has been deprecated in GLib 2.31 but g_format_size() has been added in 2.30 so we can already use it without bumping the dep.
* [presence-chooser] Set status message as the tooltipJovanka Gulicoska2011-10-251-4/+8
| | | | | | Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=640846 Signed-off-by: Danielle Madeley <danielle.madeley@collabora.co.uk>
* theme-adium: escape the name in actions as wellGuillaume Desmottes2011-10-241-3/+3
|
* ensure that contact_list_store_contact_active_cb isn't called after the ↵Guillaume Desmottes2011-10-241-5/+38
| | | | | | | | store destruction This is an exact port of similar code from empathy-individual-store. https://bugzilla.gnome.org/show_bug.cgi?id=662211
* contact_list_store_dispose: unset the timer idsGuillaume Desmottes2011-10-241-1/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=662211
* Port contact-widget to contactinfo-utilsDanielle Madeley2011-10-213-132/+58
| | | | | This is a reworking, rather than rebasing of the original patch because of large changes in the codebase.
* Incorporate updates from empathy-contact-widget into contactinfo-utilsDanielle Madeley2011-10-213-15/+72
| | | | | Update empathy-individual-widget for these changes. This comes from the rebase of this branch.
* Move empathy-contactinfo-utils to libempathy-gtkDanielle Madeley2011-10-214-1/+229
| | | | | | | Why do we still have this annoying split? Rebasing this work will pull in a dependency on empathy-string-parser, which is part of libempathy-gtk. Hence the move.
* Port individual-widget to contactinfo-utilsDanielle Madeley2011-10-211-64/+17
|
* [contact-chooser] Don't reselect the first match if something else is selectedDanielle Madeley2011-10-201-2/+5
| | | | | This patch isn't quite the behaviour I want, but I think it's better than just re-selecting the first entry every time I type something.
* [contact-chooser] Move the selection up/down without defocusing the entryDanielle Madeley2011-10-201-0/+56
|
* [contact-chooser] emit 'activate' on 'row-activated' as wellDanielle Madeley2011-10-201-0/+11
| | | | This means the selection can be activated when the treeview is focused.
* Swap SMS and Text buttonsDanielle Madeley2011-10-201-4/+4
| | | | The default action should be on the right.
* Fix extra buttons in new-call/message dialogsDanielle Madeley2011-10-202-2/+4
| | | | This was caused by a missing parameter of gtk_dialog_add_buttons().
* Remove contact-selector-dialogDanielle Madeley2011-10-204-751/+0
| | | | It's no longer used.
* Scroll dialpad entry right as more characters are inserted.Danielle Madeley2011-10-191-0/+1
| | | | The user wants to see her most recent history, not what she typed in first.
* Move dialpad into a widget of its ownDanielle Madeley2011-10-195-107/+246
| | | | | | Let's face it, the whole thing was getting a little unwieldly there in the UI utils, and if we're going to be using it in more places, let's start by abstracting it into a widget.
* theme_adium_append_message: escape alias before displaying itGuillaume Desmottes2011-10-191-2/+5
| | | | | | Not doing so can lead to nasty HTML injection from hostile users. https://bugzilla.gnome.org/show_bug.cgi?id=662035
* empathy_new_message_dialog_response: initialize contactGuillaume Desmottes2011-10-181-1/+1
|
* empathy_new_message_dialog_response: initialize individualGuillaume Desmottes2011-10-181-1/+1
|
* new-call-dialog: use the self->priv patternGuillaume Desmottes2011-10-182-32/+31
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661981
* new-message-dialog: port to EmpathyContactChooserGuillaume Desmottes2011-10-182-126/+137
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661981
* new-call-dialog: port to EmpathyContactChooserGuillaume Desmottes2011-10-182-99/+121
| | | | | | | | | | Replace the 'send video' checkbox by an extra button It's more coherent with the other places where we allow user to start calls. It also gives better feedback as we can unsensitive this button if the selected contact doesn't support video. https://bugzilla.gnome.org/show_bug.cgi?id=661981
* factor out empathy_individual_can_audio_video_call()Guillaume Desmottes2011-10-181-53/+4
| | | | | | Also allow caller to get a ref on the EmpathyContact supporting audio/video. https://bugzilla.gnome.org/show_bug.cgi?id=661981
* new-call-dialog: fix typo in commentGuillaume Desmottes2011-10-181-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661981
* contact-chooser: add 'activate' signalGuillaume Desmottes2011-10-181-0/+19
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661993
* contact-chooser: when searching, make sure that the first matching item is ↵Guillaume Desmottes2011-10-181-0/+3
| | | | | | | | | selected So user can just type the phone number of the contact he wants to call and hit enter. https://bugzilla.gnome.org/show_bug.cgi?id=661993
* add empathy_individual_view_select_first()Guillaume Desmottes2011-10-182-0/+19
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661993
* contact-list-store: stop tracking favourite contactsGuillaume Desmottes2011-10-151-26/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661489
* contact-list-store: remove 'fake group' codeGuillaume Desmottes2011-10-153-128/+1
| | | | | | | | This store is only used for MUC members which doesn't use these fake groups. Actually we could drop all the group code but it would probably be easier to completely rewrite the way we display MUC members. https://bugzilla.gnome.org/show_bug.cgi?id=661489
* remove unused EMPATHY_CONTACT_FEATURE_FAVOURITEGuillaume Desmottes2011-10-152-51/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=661489
* adium themes: crash less hard when Template.html is missingWill Thompson2011-10-151-1/+9
| | | | | | | | If Template.html is missing, then you haven't installed Empathy properly (or set EMPATHY_SRCDIR or whatever in my case). But previously we would just crash later down this function when passing template_html to string_with_format() without checking if it's NULL. This patch makes it fail a little less inscrutably.
* TpChat: hide guts of Telepathy properties.Will Thompson2011-10-151-43/+25
| | | | | | | This will make it easier to replace these with new stuff. The funky indentation in the callbacks for the subject and title changing is to make it clear that I didn't change that code; I'll reindent it in another patch.
* Merge remote-tracking branch 'pochu/error-dialog'Danielle Madeley2011-10-143-5/+88
|\
| * Set a parent for the error dialogEmilio Pozuelo Monfort2011-09-051-5/+8
| | | | | | | | | | | | Conflicts: libempathy-gtk/empathy-new-message-dialog.c
| * NewMessageDialog: show an error if starting the channel failsEmilio Pozuelo Monfort2011-09-051-2/+77
| | | | | | | | | | | | Conflicts: libempathy-gtk/empathy-new-message-dialog.c
| * empathy_dispatcher_chat_with_contact_id(): add optional cbEmilio Pozuelo Monfort2011-09-053-5/+10
| | | | | | | | | | | | | | | | | | | | | | Conflicts: libempathy-gtk/empathy-individual-menu.c libempathy-gtk/empathy-new-message-dialog.c libempathy/empathy-dispatcher.c libempathy/empathy-dispatcher.h src/empathy-chat-manager.c src/empathy-chat-window.c
* | Merge remote-tracking branch 'pochu/misc-fixes'Danielle Madeley2011-10-142-0/+5
|\ \
| * | Display an accurate error when not enough creditEmilio Pozuelo Monfort2011-09-051-0/+2
| | |
| * | Cope with gtk_icon_theme_lookup_icon returning NULLSjoerd Simons2011-09-051-0/+3
| |/
* | Merge branch: 'Add top-up link to chat text when there is insufficient credit'Danielle Madeley2011-10-144-3/+78
|\ \
| * | EmpathyChat: add a 'Top up' link when there's not enough creditEmilio Pozuelo Monfort2011-09-051-3/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is only added for Adium themes since ChatTextView ones don't support markup. Conflicts: libempathy-gtk/empathy-chat.c
| * | EmpathyThemeAdium: implement append_event_markupEmilio Pozuelo Monfort2011-09-051-0/+9
| | | | | | | | | | | | | | | | | | Conflicts: libempathy-gtk/empathy-theme-adium.c
| * | Add empathy_chat_view_append_event_markupEmilio Pozuelo Monfort2011-09-052-0/+22
| |/ | | | | | | | | | | | | Conflicts: libempathy-gtk/empathy-chat-view.c libempathy-gtk/empathy-chat-view.h
* | contact-blocking-dialog: make debug more usefulGuillaume Desmottes2011-10-131-12/+21
| | | | | | | | It's not very helpful to not know which Connection/Channel failed.
* | Use default variant if we can't find any variantsGuillaume Desmottes2011-10-121-1/+4
| | | | | | | | | | | | We use to crash here trying to get the first element of an empty GPtrArray. https://bugzilla.gnome.org/show_bug.cgi?id=660586
* | remove empathy-contact-selectorGuillaume Desmottes2011-10-093-550/+0
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=629517
* | contact-chooser: add API to hide the search entryGuillaume Desmottes2011-10-092-5/+15
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=629517
* | individual-widget: use GtkGrid instead of GtkTableGuillaume Desmottes2011-09-292-17/+10
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=660429
* | contact-selector-dialog: use GtkGrid instead of GtkTableGuillaume Desmottes2011-09-292-17/+16
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=660429
* | empathy-contact-selector-dialog.ui: load/save in GladeGuillaume Desmottes2011-09-291-3/+5
| | | | | | | | | | | | No change. https://bugzilla.gnome.org/show_bug.cgi?id=660429
* | Use new GOA desktop fileGuillaume Desmottes2011-09-291-2/+3
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=660449
* | Use g_cclosure_marshal_generic for all signalsXavier Claessens2011-09-2814-45/+19
| | | | | | | | No more ugly marshallers \o/
* | pass to proper user action time when requesting an outgoing FTGuillaume Desmottes2011-09-271-1/+2
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=658245
* | e-account-widget-irc: Use a GtkGrid to fix label wrappingXavier Claessens2011-09-262-52/+49
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=646630
* | Add /inspector command to show webkit inspectorXavier Claessens2011-09-263-0/+28
| |
* | Don't try to request a Call channel if built without Call supportGuillaume Desmottes2011-09-261-0/+35
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=659594
* | Factor out call_new_with_streams()Guillaume Desmottes2011-09-261-5/+22
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=659594
* | contact-widget: left align status labelGuillaume Desmottes2011-09-261-0/+1
| | | | | | | | | | | | It's already done that way in individual-widget. https://bugzilla.gnome.org/show_bug.cgi?id=659816
* | glade: move IRC's expander to the vbox instead of the tableXavier Claessens2011-09-231-130/+168
| |
* | Glade: GtkGrid does not have n-rows and n-columns properties as GtkTableXavier Claessens2011-09-231-9/+0
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=646630
* | Glade: fix sizing in SIP accounts widgetXavier Claessens2011-09-231-1/+2
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=646630
* | e-account-widget-jabber: Use GtkGrid instead of GtkTableXavier Claessens2011-09-221-55/+71
| | | | | | | | | | | | This work around bug #657621 https://bugzilla.gnome.org/show_bug.cgi?id=646630
* | e-account-widget-jabber: fix sizing issuesDiego Escalante Urrelo2011-09-221-347/+381
| | | | | | | | | | | | Fix the glade file for sizing issues Bug #646630
* | log-window: improve icons in the search entryCosimo Cecchi2011-09-201-4/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | There are a few improvements we can make to the search entry icons in the log window, which this patch tries to fix. - icons in entries are usually symbolic in GNOME 3, so I made the icons symbolic. - I merged the two icons in just one on the right using the shell-style, i.e. the search icon turns into a clear action once there's some text typed into the entry (Documents also uses the same style for its search entry). https://bugzilla.gnome.org/show_bug.cgi?id=659298
* | coding style fixEMPATHY_3_1_92Guillaume Desmottes2011-09-191-1/+1
| |
* | Use always-writeable and writeable-properties for alias and groupsRaul Gutierrez Segales2011-09-191-2/+3
| | | | | | | | | | | | | | | | Folks is in the way of deprecating the folks_persona_store_get_can_{alias,group}_personas methods in favour of directly checking alias and groups properties via folks_persona_store_get_always_writeable_properties and folks_persona_get_writeable_properties.
* | EmpathyChat: Set slider position after a timeoutXavier Claessens2011-09-191-16/+29
| | | | | | | | | | | | | | This ensure that the window has resized before setting the position because GtkPaned needs to know its size allocation https://bugzilla.gnome.org/show_bug.cgi?id=632357
* | Use tp_proxy_prepare_async instead of tp_account_manager_prepare_asyncGuillaume Desmottes2011-09-196-14/+14
| |
* | avatar-chooser: disable 'take picture' button if there is no camera connectedGuillaume Desmottes2011-09-161-1/+16
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=652985
* | avatar-chooser: split creation of the file chooser dialogGuillaume Desmottes2011-09-161-11/+12
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=652985
* | log-window: fix translators commentGuillaume Desmottes2011-09-151-3/+2
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=659141
* | log-window: properly translate duration stringsGuillaume Desmottes2011-09-151-3/+14
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=659141
* | Remove unused variables [-Werror=unused-but-set-variable]Alban Crequy2011-09-152-4/+0
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=658650
* | contact-list-store: store GtkTreeIter rather than GtkTreeRowReference in the ↵Guillaume Desmottes2011-09-151-59/+20
| | | | | | | | | | | | | | | | cache GtkTreeRowReference keeps a ref on the store introducing a ref cycle. https://bugzilla.gnome.org/show_bug.cgi?id=658650
* | individual-store: store GtkTreeIter rather than GtkTreeRowReference in the cacheGuillaume Desmottes2011-09-151-64/+21
| | | | | | | | | | | | GtkTreeRowReference keeps a ref on the store introducing a ref cycle. https://bugzilla.gnome.org/show_bug.cgi?id=658650
* | individual-widget: use GtkGrid instead of GtkTable internallyCosimo Cecchi2011-09-131-125/+118
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EmpathyIndividualWidget (used both in the contact information dialogs and in the tooltips) use a GtkTable internally to layout contact details. GtkTable is being deprecated, and does not correctly support width-for-height size negotiation. So, there are cases where we get funny overallocations bugs for wrapping GtkLabels; this is especially annoying for tooltips, as they tend to grow huge vertically. Porting the code to use a better container such as GtkGrid solves the bug. This patch does not cover all the use of GtkTable in EmpathyIndividualWidget, but enough to fix the tooltip sizing. https://bugzilla.gnome.org/show_bug.cgi?id=658857
* | AccountChooser: don't return garbage from _set_accountWill Thompson2011-09-131-0/+1
| | | | | | | | | | | | | | | | | | Previously, the 'set' field of the stack-allocated 'data' structure was not initialized. It's explicitly set to TRUE if the account is found, but never otherwise set; so if the account is not found, this function returned random garbage. Reviewed-by: Xavier Claessens <xclaesse@gmail.com>
* | theme-adium: ensure we always use the same color when sending messagesGuillaume Desmottes2011-09-131-4/+10
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=658821
* | rename text/{persona,individual}-id as they are not standardGuillaume Desmottes2011-09-133-8/+8
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=648315
* | Because we like whalesXavier Claessens2011-09-091-2/+43
| |
* | individual_store_remove_individual: ensure that the store stays alive during ↵Guillaume Desmottes2011-09-091-0/+7
| | | | | | | | | | | | the process https://bugzilla.gnome.org/show_bug.cgi?id=658644
* | contact_list_store_remove_contact: ensure that the store stays alive during ↵Guillaume Desmottes2011-09-091-0/+7
| | | | | | | | | | | | the process https://bugzilla.gnome.org/show_bug.cgi?id=658644
* | log-window: sort "Who" list store alphabeticallyJussi Kukkonen2011-09-081-11/+27
| | | | | | | | | | | | | | | | | | | | Currently "Who"-list is sorted with "g_strcmp0 (name)" which is not what we want (e.g. "Chris" becomes before "bob" because of the initial capital letter). Start sorting using g_utf8_collate_key(). https://bugzilla.gnome.org/show_bug.cgi?id=658336
* | ContactSelector: mark standard action as the default.Will Thompson2011-09-071-16/+5
| | | | | | | | | | | | | | | | | | | | This allows Gtk+ to style the button differently to indicate that it will be pressed when the user hits Enter; it also fixes hitting enter in the New Conversation dialog, which does not consider GTK_RESPONSE_ACCEPT to be a reasonable response and ignores it. So we get a bug fix and better styling in exchange for less code! https://bugzilla.gnome.org/show_bug.cgi?id=658343
* | individual-store: use Folks directly to watch is-favourite changesGuillaume Desmottes2011-09-071-20/+18
| | | | | | | | | | We already use it to check if a contact is in favourite or not. The contact manager should probably be killed at some point any way.
* | Support launching GNOME Online Accounts in empathy-accountsDanielle Madeley2011-09-061-7/+65
| |
* | log-window: add the "raised" style class to the account chooserCosimo Cecchi2011-09-031-0/+3
|/ | | | | | So that it raises up from the toolbar below. https://bugzilla.gnome.org/show_bug.cgi?id=657954
* Use format-justify-fill everywhereEmilio Pozuelo Monfort2011-09-021-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=657843
* LogWindow: fix toolbar iconsEmilio Pozuelo Monfort2011-09-021-2/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=657843
* log-window: align the account chooser and search widgetGuillaume Desmottes2011-09-021-0/+26
| | | | | | | Center the account chooser and align the search widget to the right of the toolbar. https://bugzilla.gnome.org/show_bug.cgi?id=657842
* Fixes a segfault in empathy-individual-store.cCosimo Alfarano2011-09-021-0/+8
| | | | | | | | | | | When a contact cannot be obtained from an individual, icon_name and contact will be NULL, leading to g_hash_table_lookup for a NULL-value, segfaulting. Although there's probably an underlying error somewhere, the NULL case should be handled, being a valid return value for the method; https://bugzilla.gnome.org/show_bug.cgi?id=657914
* Merge branch 'timezones-656189'Danielle Madeley2011-09-011-3/+3
|\
| * Use g_date_time_new_from_unix_local() to read timestamps from loggerDanielle Madeley2011-08-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | g_date_time_new_from_unix_local() reads a Unix timestamp (which is defined to be in UTC) and sets the timezone for the GDateTime to be the local timezone. Thus when we format it, we get times in local time. g_date_time_new_from_unix_utc() is not correct, because it sets the timezone to UTC. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=656189
* | Correct grouping in the hostname regexpSjoerd Simons2011-08-311-3/+4
|/ | | | | | | Correctly group our subregexp otherwise hostnames like the following won't be recognized due to the way things expand: a.com example.c-om
* coding style fixEMPATHY_3_1_90Guillaume Desmottes2011-08-292-3/+3
|
* Merge branch 'account-widget-657616'Guillaume Desmottes2011-08-291-0/+10
|\
| * account-widget-local-xmpp: put all the labels in a GtkSizeGroupGuillaume Desmottes2011-08-291-0/+10
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=657616
* | contact list: optimize loading contactsAlban Crequy2011-08-292-194/+220
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous algorithm was O(n^2) with the number of contacts. Each contact can be in several groups, so when a contact is added or updated, we iterated over all the contact list to find the rows representing the contact. When connecting to an account and getting all the contacts, this was too slow. The groups are stored in the GtkTreeStore and suffer from the same problem: to look for a group, it needed to iterate on all contacts. The new algorithm maintains a hash from the contact to the list of rows representing it, and another hash from the group to the row representing it. On Empathy 2.30.2 when tested on MeeGo with 300 contacts, loading the contacts is faster: roughly 9 seconds before the patch, 3 seconds after. On Empathy 3.1.5, it seems to load in background so I don't know how to measure the time lost in GtkTreeStore. But before the patch, GProf says 23% is lost in individual_store_find_contact_foreach(), and after the patch it is not visible anymore. And "time" says we win 5s of CPU when starting+quitting Empathy: Before the patch: After the patch: real 0m23.485s real 0m23.460s user 0m13.805s user 0m8.305s sys 0m0.308s sys 0m0.316s https://bugzilla.gnome.org/show_bug.cgi?id=657086
* contact-widget: use the day-selected sig to update birthdayGuillaume Desmottes2011-08-291-1/+1
| | | | | Having to double click on a day to update it was really confusing and most people (including me!) were just thinking that was not working.
* Allow to call phone number of contactsGuillaume Desmottes2011-08-292-1/+209
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=650112
* add EmpathyAccountSelectorDialogGuillaume Desmottes2011-08-293-0/+268
| | | | | | Dialog asking user to pick an account from a pre-defined list. https://bugzilla.gnome.org/show_bug.cgi?id=650112
* Don't leak FDs when loading avatars.Will Thompson2011-08-261-5/+5
| | | | Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Move the 'Show previous conversation' menu entryGuillaume Desmottes2011-08-262-15/+15
| | | | It used to be right in the middle of actions on the contact.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 03:02:35 +0800