| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=668502
|
|
|
|
|
|
| |
No point keeping the extra widgets now.
https://bugzilla.gnome.org/show_bug.cgi?id=666714
|
|
|
|
|
|
| |
That way the avatar is no longer miss aligned with the other fields.
https://bugzilla.gnome.org/show_bug.cgi?id=666714
|
|
|
|
|
|
| |
There is no point keeping this even more complicated that it already is.
https://bugzilla.gnome.org/show_bug.cgi?id=666714
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=666714
|
|
|
|
|
|
| |
It's not used.
https://bugzilla.gnome.org/show_bug.cgi?id=666714
|
| |
|
|
|
|
|
|
| |
Thanks to marc@ttux.net for his help.
https://bugzilla.gnome.org/show_bug.cgi?id=660856
|
|
|
|
|
|
| |
empathy_connection_aggregator_get_all_groups()
https://bugzilla.gnome.org/show_bug.cgi?id=667037
|
|
|
|
|
|
|
| |
It's fair for the caller to expect the error the be set if the _finish()
function returns NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=667037
|
|
|
|
| |
They have been properly fixed since a while.
|
|
|
|
|
|
| |
This ensure that we won't call the callback when disposing the widget.
https://bugzilla.gnome.org/show_bug.cgi?id=667676
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=667791
|
| |
|
|
|
|
|
|
| |
Kinda hacky but that's the best we can do without major changes in Folks.
https://bugzilla.gnome.org/show_bug.cgi?id=666531
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661500
|
|
|
|
|
|
|
| |
The EmpathyIndividualWidget object is re-used for tooltips so we should remove
the ChamplainEmbedView before trying to add a new one.
https://bugzilla.gnome.org/show_bug.cgi?id=661500
|
|
|
|
|
| |
This introduces some code duplication with the assistant but it's going to die
soon anyway.
|
|
|
|
|
| |
We'll need them when creating the account. Adding a simple function to
manually hide them in the assistant for now.
|
| |
|
|
|
|
| |
I'm changing this file a lot so while I'm on it...
|
| |
|
|
|
|
|
| |
We should use the official accelerator for closing dialog. If widget fields
are also using the 'C' accelerator then they should be fixed.
|
|
|
|
| |
We fire the close signal a bit later in this function
|
|
|
|
|
| |
It should also be displayed now as we always want the user to be able to close
the dialog.
|
| |
|
| |
|
|
|
|
|
|
|
| |
This is not functional yet, but it does compile and kindof demonstrate what's
going to happen.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=652670
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=649208
|
|
|
|
|
|
| |
Best to always use an individual so we don't have 2 code paths to maintain.
https://bugzilla.gnome.org/show_bug.cgi?id=666163
|
|
|
|
|
|
|
| |
No need to export everything. I added prototypes in the C file to not have to
move everything upside down.
https://bugzilla.gnome.org/show_bug.cgi?id=666163
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=660547
|
|
|
|
|
|
|
| |
It's not used any more and this code was the last one using the contact
manager.
https://bugzilla.gnome.org/show_bug.cgi?id=660547
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=660547
|
|
|
|
|
|
| |
It's clearer that way.
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allow user to select the personas he wants to block.
Note that I didn't pass an EmpathyContact as second argument to
empathy_individiual_block_menu_item_new() as we currently do with most
item_new() methods. Instead I just craft a new individual containing only the
persona we care about. This approach is much cleaner as we don't have to deal
with 2 different code paths. I filed bug #666163 to do the same with the
existing functions.
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
|
|
| |
It's a bit fragile, user should say which features he wants.
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
|
|
|
| |
We already checks if it's a IndividualStoreChannel before using it so that's
safe.
https://bugzilla.gnome.org/show_bug.cgi?id=665038
|
|
|
|
|
|
| |
Shouldn't really happen in practice but better to be safe than sorry.
https://bugzilla.gnome.org/show_bug.cgi?id=665853
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=665592
|
|
|
|
|
|
|
|
| |
This fix a bug with button_video_binding not being re-installed when a contact
supporting video was selected. It was only re-installed when using the contact
from the selected event.
https://bugzilla.gnome.org/show_bug.cgi?id=665592
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=664209
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=660547
|
|
|
|
|
| |
We already use it when using the menu so there is no reason to keep using the
old one.
|
|
|
|
| |
cancellable are always optional so this code should be NULL safe.
|
|
|
|
|
|
|
|
| |
We have to prepare the contact groups feature and ensure that the singleton is
still alive. The 'empathy' process is the only one allowing user to change
contact groups so we just have to do it there.
https://bugzilla.gnome.org/show_bug.cgi?id=665121
|
|
|
|
|
|
|
|
| |
For some reason, gcc starts complaining about this as soon as I remove
EmpathyContactListFlags from empathy-contact-list.h ?!
If you have an explanation for this please let me know...
https://bugzilla.gnome.org/show_bug.cgi?id=663328
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663328
|
|
|
|
|
|
|
|
| |
We have to call the callback manually to update the theme when it's changed.
Also make sure that style-set signal is only connected once and we update the
theme only if the 'simple' one is used.
https://bugzilla.gnome.org/show_bug.cgi?id=664795
|
| |
|
|
|
|
|
|
| |
Hourrah \o/
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
|
|
|
| |
The great unification !
EmpathyChat was the last user of the contact store/view, everything now use
the individual ones.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This allows us to remove setup_idle_id as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This allows us to remove show_active as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This will allow us to use the individual view to display muc members.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
|
| |
We now have EmpathyIndividualStoreManager which implements the store using
EmpathyIndividualManager as its contact source.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This will be needed when abstracting EmpathyIndividualStore.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661640
|
|
|
|
|
|
|
| |
I'm going to implement a slidely different version of this dialog so best to
re-use as much code as possible.
https://bugzilla.gnome.org/show_bug.cgi?id=661640
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661640
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
|
|
|
|
|
|
|
| |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
|
|
|
|
|
| |
empathy_folks_individual_contains_contact() fails
The individual menu already asserts that's the case. And there is no point
displaying a menu anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
This is needed when being used in a muc.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
This will be needed when using this widget in MUC.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
|
| |
Move it to empathy-contactinfo-utils so we'll be able to re-use it in
empathy-individual-widget as well.
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
|
| |
That way we'll pick at least one TpContact if there is only one contact in
the individual and he doesn't have any presence (IRC for example).
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
|
|
| |
God I hate _get functions returning new memory...
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
|
|
|
|
|
| |
The model copies the date so we should free it afterward.
https://bugzilla.gnome.org/show_bug.cgi?id=663873
|
| |
|
|
|
|
|
|
|
|
| |
EMPATHY_INDIVIDUAL_STORE_COL_NAME
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663842
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663842
|
|
|
|
|
|
|
|
|
|
| |
It has been deprecated. I asked on #gtk+ and that seems to be the right way to
do this. See
http://git.gnome.org/browse/gtk+/commit/?id=2783158f8d9ca69e5a8fc4a903bfbcc3871a1b02
All these APIs are available since GTK+ 3.0 so we're good.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
|
|
|
| |
It has been deprecated. gdk_window_get_device_position() has been added in
GTK+ 3.0 so we're fine.
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663563
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663327
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
|
|
| |
This reverts commit 40dc4074eeecb15c82d9eacb3fcd54cff7162440.
We can now depends on it.
|
|
|
|
| |
We weren't using the persona we just created for some reason.
|
|
|
|
|
| |
Unexpectedly, a 0 length buffer causes gdk_pixbuf_loader_write() to return
FALSE without setting @error. Would then segv on error->message.
|
|\ |
|
| |
| |
| |
| | |
Buttons should all be the same size.
|
| |
| |
| |
| |
| | |
The child widgets of the dialpad-widget weren't being shown, so the widget
required a gtk_widget_show_all() to show up. Unexpected :(
|
|/
|
|
|
| |
In that case priv->jid_suffix is NULL, so we should not try to call
remove_jid_suffix().
|
| |
|
|
|
|
|
|
| |
This reverts commit d8153fa21a7beb4229dbba1810eb8544af91db4f.
I was not supposed to commit that yet; the tp-glib API hasn't been released.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
|
|
| |
We have 2 different models having their own set of columns.
https://bugzilla.gnome.org/show_bug.cgi?id=661805
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662903
|
| |
|
|
|
|
|
|
| |
It's stupid to have to ask to any user of this widget to do this itself.
https://bugzilla.gnome.org/show_bug.cgi?id=662604
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662604
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662843
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
| |
TP_CONNECTION_FEATURE_CAPABILITIES are prepared
Most filter will need those.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
| |
It's cleaner than re-setting the same filter function.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
| |
It just unref one object so dispose is the best place.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
|
|
| |
I wanted to clean the account chooser a bit but the old coding style makes me
cry...
It's good to do anyway, especially if we move this widget to a telepathy-gtk
lib at some point.
https://bugzilla.gnome.org/show_bug.cgi?id=662609
|
|
|
|
|
|
|
|
|
| |
Making a call to GetContactAttributes only gets the attributes currently known
to the CM. If a contact is unknown, lookups for the attributes are then queued
and signalled when retrieved. When we receive this signal, we should refilter
the contact list.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662727
|
|
|
|
|
| |
The latter has been deprecated and g_unichar_fully_decompose() is already in
2.30.
|
|
|
|
|
| |
The latter has been deprecated in GLib 2.31 but g_format_size() has been added
in 2.30 so we can already use it without bumping the dep.
|
|
|
|
|
|
| |
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=640846
Signed-off-by: Danielle Madeley <danielle.madeley@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
|
| |
store destruction
This is an exact port of similar code from empathy-individual-store.
https://bugzilla.gnome.org/show_bug.cgi?id=662211
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=662211
|
|
|
|
|
| |
This is a reworking, rather than rebasing of the original patch because of
large changes in the codebase.
|
|
|
|
|
| |
Update empathy-individual-widget for these changes. This comes from the rebase
of this branch.
|
|
|
|
|
|
|
| |
Why do we still have this annoying split?
Rebasing this work will pull in a dependency on empathy-string-parser, which is
part of libempathy-gtk. Hence the move.
|
| |
|
|
|
|
|
| |
This patch isn't quite the behaviour I want, but I think it's better than just
re-selecting the first entry every time I type something.
|
| |
|
|
|
|
| |
This means the selection can be activated when the treeview is focused.
|
|
|
|
| |
The default action should be on the right.
|
|
|
|
| |
This was caused by a missing parameter of gtk_dialog_add_buttons().
|
|
|
|
| |
It's no longer used.
|
|
|
|
| |
The user wants to see her most recent history, not what she typed in first.
|
|
|
|
|
|
| |
Let's face it, the whole thing was getting a little unwieldly there in the
UI utils, and if we're going to be using it in more places, let's start by
abstracting it into a widget.
|
|
|
|
|
|
| |
Not doing so can lead to nasty HTML injection from hostile users.
https://bugzilla.gnome.org/show_bug.cgi?id=662035
|
| |
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
|
|
|
|
|
|
| |
Replace the 'send video' checkbox by an extra button
It's more coherent with the other places where we allow user to start calls.
It also gives better feedback as we can unsensitive this button if the
selected contact doesn't support video.
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
|
|
| |
Also allow caller to get a ref on the EmpathyContact supporting audio/video.
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
|
|
|
|
|
| |
selected
So user can just type the phone number of the contact he wants to call and hit
enter.
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661993
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
|
|
|
|
| |
This store is only used for MUC members which doesn't use these fake groups.
Actually we could drop all the group code but it would probably be easier to
completely rewrite the way we display MUC members.
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=661489
|
|
|
|
|
|
|
|
| |
If Template.html is missing, then you haven't installed Empathy properly
(or set EMPATHY_SRCDIR or whatever in my case). But previously we would
just crash later down this function when passing template_html to
string_with_format() without checking if it's NULL. This patch makes
it fail a little less inscrutably.
|
|
|
|
|
|
|
| |
This will make it easier to replace these with new stuff. The funky
indentation in the callbacks for the subject and title changing is to
make it clear that I didn't change that code; I'll reindent it in
another patch.
|
|\ |
|
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-new-message-dialog.c
|
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-new-message-dialog.c
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-individual-menu.c
libempathy-gtk/empathy-new-message-dialog.c
libempathy/empathy-dispatcher.c
libempathy/empathy-dispatcher.h
src/empathy-chat-manager.c
src/empathy-chat-window.c
|
|\ \ |
|
| | | |
|
| |/ |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is only added for Adium themes since ChatTextView ones don't
support markup.
Conflicts:
libempathy-gtk/empathy-chat.c
|
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
libempathy-gtk/empathy-theme-adium.c
|
| |/
| |
| |
| |
| |
| |
| | |
Conflicts:
libempathy-gtk/empathy-chat-view.c
libempathy-gtk/empathy-chat-view.h
|
| |
| |
| |
| | |
It's not very helpful to not know which Connection/Channel failed.
|
| |
| |
| |
| |
| |
| | |
We use to crash here trying to get the first element of an empty GPtrArray.
https://bugzilla.gnome.org/show_bug.cgi?id=660586
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=629517
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=629517
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| |
| |
| | |
No change.
https://bugzilla.gnome.org/show_bug.cgi?id=660429
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=660449
|
| |
| |
| |
| | |
No more ugly marshallers \o/
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658245
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659594
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659594
|
| |
| |
| |
| |
| |
| | |
It's already done that way in individual-widget.
https://bugzilla.gnome.org/show_bug.cgi?id=659816
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| |
| |
| | |
This work around bug #657621
https://bugzilla.gnome.org/show_bug.cgi?id=646630
|
| |
| |
| |
| |
| |
| | |
Fix the glade file for sizing issues
Bug #646630
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There are a few improvements we can make to the search entry icons in
the log window, which this patch tries to fix.
- icons in entries are usually symbolic in GNOME 3, so I made the icons
symbolic.
- I merged the two icons in just one on the right using the shell-style,
i.e. the search icon turns into a clear action once there's some text
typed into the entry (Documents also uses the same style for its
search entry).
https://bugzilla.gnome.org/show_bug.cgi?id=659298
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Folks is in the way of deprecating the
folks_persona_store_get_can_{alias,group}_personas methods in favour
of directly checking alias and groups properties via
folks_persona_store_get_always_writeable_properties and
folks_persona_get_writeable_properties.
|
| |
| |
| |
| |
| |
| |
| | |
This ensure that the window has resized before setting the position
because GtkPaned needs to know its size allocation
https://bugzilla.gnome.org/show_bug.cgi?id=632357
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=652985
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=652985
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659141
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=659141
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| |
| |
| | |
cache
GtkTreeRowReference keeps a ref on the store introducing a ref cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| | |
GtkTreeRowReference keeps a ref on the store introducing a ref cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
EmpathyIndividualWidget (used both in the contact information dialogs
and in the tooltips) use a GtkTable internally to layout contact
details.
GtkTable is being deprecated, and does not correctly support
width-for-height size negotiation. So, there are cases where we get
funny overallocations bugs for wrapping GtkLabels; this is especially
annoying for tooltips, as they tend to grow huge vertically.
Porting the code to use a better container such as GtkGrid solves the
bug. This patch does not cover all the use of GtkTable in
EmpathyIndividualWidget, but enough to fix the tooltip sizing.
https://bugzilla.gnome.org/show_bug.cgi?id=658857
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, the 'set' field of the stack-allocated 'data' structure was
not initialized. It's explicitly set to TRUE if the account is found,
but never otherwise set; so if the account is not found, this function
returned random garbage.
Reviewed-by: Xavier Claessens <xclaesse@gmail.com>
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=658821
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=648315
|
| | |
|
| |
| |
| |
| |
| |
| | |
the process
https://bugzilla.gnome.org/show_bug.cgi?id=658644
|
| |
| |
| |
| |
| |
| | |
the process
https://bugzilla.gnome.org/show_bug.cgi?id=658644
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently "Who"-list is sorted with "g_strcmp0 (name)" which
is not what we want (e.g. "Chris" becomes before "bob" because of
the initial capital letter).
Start sorting using g_utf8_collate_key().
https://bugzilla.gnome.org/show_bug.cgi?id=658336
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This allows Gtk+ to style the button differently to indicate that it
will be pressed when the user hits Enter; it also fixes hitting enter in
the New Conversation dialog, which does not consider GTK_RESPONSE_ACCEPT
to be a reasonable response and ignores it. So we get a bug fix and
better styling in exchange for less code!
https://bugzilla.gnome.org/show_bug.cgi?id=658343
|
| |
| |
| |
| |
| | |
We already use it to check if a contact is in favourite or not.
The contact manager should probably be killed at some point any way.
|
| | |
|
|/
|
|
|
|
| |
So that it raises up from the toolbar below.
https://bugzilla.gnome.org/show_bug.cgi?id=657954
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657843
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657843
|
|
|
|
|
|
|
| |
Center the account chooser and align the search widget to the right of the
toolbar.
https://bugzilla.gnome.org/show_bug.cgi?id=657842
|
|
|
|
|
|
|
|
|
|
|
| |
When a contact cannot be obtained from an individual, icon_name and
contact will be NULL, leading to g_hash_table_lookup for a NULL-value,
segfaulting.
Although there's probably an underlying error somewhere, the NULL case
should be handled, being a valid return value for the method;
https://bugzilla.gnome.org/show_bug.cgi?id=657914
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
g_date_time_new_from_unix_local() reads a Unix timestamp (which is defined
to be in UTC) and sets the timezone for the GDateTime to be the local timezone.
Thus when we format it, we get times in local time.
g_date_time_new_from_unix_utc() is not correct, because it sets the timezone
to UTC.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=656189
|
|/
|
|
|
|
|
| |
Correctly group our subregexp otherwise hostnames like the following
won't be recognized due to the way things expand:
a.com
example.c-om
|
| |
|
|\ |
|
| |
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=657616
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous algorithm was O(n^2) with the number of contacts. Each contact can
be in several groups, so when a contact is added or updated, we iterated over
all the contact list to find the rows representing the contact. When connecting
to an account and getting all the contacts, this was too slow.
The groups are stored in the GtkTreeStore and suffer from the same problem: to
look for a group, it needed to iterate on all contacts.
The new algorithm maintains a hash from the contact to the list of rows
representing it, and another hash from the group to the row representing it.
On Empathy 2.30.2 when tested on MeeGo with 300 contacts, loading the contacts
is faster: roughly 9 seconds before the patch, 3 seconds after.
On Empathy 3.1.5, it seems to load in background so I don't know how to measure
the time lost in GtkTreeStore. But before the patch, GProf says 23% is lost in
individual_store_find_contact_foreach(), and after the patch it is not visible
anymore. And "time" says we win 5s of CPU when starting+quitting Empathy:
Before the patch: After the patch:
real 0m23.485s real 0m23.460s
user 0m13.805s user 0m8.305s
sys 0m0.308s sys 0m0.316s
https://bugzilla.gnome.org/show_bug.cgi?id=657086
|
|
|
|
|
| |
Having to double click on a day to update it was really confusing and most
people (including me!) were just thinking that was not working.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=650112
|
|
|
|
|
|
| |
Dialog asking user to pick an account from a pre-defined list.
https://bugzilla.gnome.org/show_bug.cgi?id=650112
|
|
|
|
| |
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
| |
It used to be right in the middle of actions on the contact.
|
|
|
|
|
|
| |
* Fix an unclear error string in the avatar chooser
when saving camera taken image to file.
Fixes bug #657166
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
|
|
| |
No change has been done, this is just to keep commits simpler.
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=657220
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a missing unref in GIO, the input stream is leaked by GFileIcon, so
if we rely on its FD being implicitly closed when the stream is finalised,
we'll end up leaking (lots of) file descriptors.
As well as fixing the unref in GIO (see: bgo#657206), we now explicitly
close the input stream so that even if the stream object is leaked, the FD
isn't.
Closes: bgo#656682
|
|\ |
|
| |
| |
| |
| |
| |
| | |
The verb, "Find", is already present on the left of the entry.
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This has the much nicer side-effect that if it gets thrown off the
side because it doesn't have enough room, the icon and label will be
shown in the expander.
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|