| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Sort by:
• "config.h"
• API declarations, if any
• public libraries
• internal headers, alphabetically sorted (mostly)
http://telepathy.freedesktop.org/wiki/Style#A.23includes
https://bugzilla.gnome.org/show_bug.cgi?id=697076
|
|
|
|
|
|
|
|
| |
Directly add the libempathy, libempathy-gtk and extensions directories
to the include search path. This decouples header inclusions from their
location and helps when reorganizing the source files layout.
https://bugzilla.gnome.org/show_bug.cgi?id=696950
|
|
|
|
|
|
|
| |
This makes a bit more obvious which headers come from public libraries
and which ones come from uninstalled utility libraries.
https://bugzilla.gnome.org/show_bug.cgi?id=696950
|
|
|
|
|
|
|
| |
With the help of the script posted at http://stackoverflow.com/a/7135530
and some manual fixes, drop the unused or redundant #include directives.
https://bugzilla.gnome.org/show_bug.cgi?id=696718
|
|
|
|
|
| |
tp-glib 1.0 will enforce to only include telepathy-glib.h so best doing it to
reduce the delta with the future stable branch.
|
| |
|
| |
|
|
|
|
| |
The individual manager already sends the exact same debugging message.
|
| |
|
|
|
|
| |
Those messages flood the debug window and never helped me finding any bug.
|
|
|
|
|
|
|
| |
Rearrange the code that puts people into groups a bit in a way I think
makes more sense.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=668796
|
|
|
|
|
|
| |
This allows us to remove setup_idle_id as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This allows us to remove show_active as a protected variable.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
|
| |
We now have EmpathyIndividualStoreManager which implements the store using
EmpathyIndividualManager as its contact source.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
| |
This will be needed when abstracting EmpathyIndividualStore.
https://bugzilla.gnome.org/show_bug.cgi?id=663387
|
|
|
|
|
|
|
|
|
|
|
| |
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|
|
|
|
|
|
| |
EMPATHY_INDIVIDUAL_STORE_COL_NAME
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=663387
https://bugzilla.gnome.org/show_bug.cgi?id=663763
|
|
|
|
|
|
| |
Also allow caller to get a ref on the EmpathyContact supporting audio/video.
https://bugzilla.gnome.org/show_bug.cgi?id=661981
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
|
|
|
|
|
| |
GtkTreeRowReference keeps a ref on the store introducing a ref cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=658650
|
|
|
|
|
|
| |
the process
https://bugzilla.gnome.org/show_bug.cgi?id=658644
|
|
|
|
|
| |
We already use it to check if a contact is in favourite or not.
The contact manager should probably be killed at some point any way.
|
|
|
|
|
|
|
|
|
|
|
| |
When a contact cannot be obtained from an individual, icon_name and
contact will be NULL, leading to g_hash_table_lookup for a NULL-value,
segfaulting.
Although there's probably an underlying error somewhere, the NULL case
should be handled, being a valid return value for the method;
https://bugzilla.gnome.org/show_bug.cgi?id=657914
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous algorithm was O(n^2) with the number of contacts. Each contact can
be in several groups, so when a contact is added or updated, we iterated over
all the contact list to find the rows representing the contact. When connecting
to an account and getting all the contacts, this was too slow.
The groups are stored in the GtkTreeStore and suffer from the same problem: to
look for a group, it needed to iterate on all contacts.
The new algorithm maintains a hash from the contact to the list of rows
representing it, and another hash from the group to the row representing it.
On Empathy 2.30.2 when tested on MeeGo with 300 contacts, loading the contacts
is faster: roughly 9 seconds before the patch, 3 seconds after.
On Empathy 3.1.5, it seems to load in background so I don't know how to measure
the time lost in GtkTreeStore. But before the patch, GProf says 23% is lost in
individual_store_find_contact_foreach(), and after the patch it is not visible
anymore. And "time" says we win 5s of CPU when starting+quitting Empathy:
Before the patch: After the patch:
real 0m23.485s real 0m23.460s
user 0m13.805s user 0m8.305s
sys 0m0.308s sys 0m0.316s
https://bugzilla.gnome.org/show_bug.cgi?id=657086
|
|
|
|
|
|
|
| |
Closes: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a
valid TpContact
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|
|
|
|
|
|
| |
Helps: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a
valid TpContact
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
| |
|
|
|
|
| |
Helps: bgo#648822 - Port Empathy to Folks 0.5.1
|
|
|
|
| |
Helps: bgo#648822 - Port Empathy to Folks 0.5.1
|
|
|
|
| |
Helps: bgo#648822 - Port Empathy to Folks 0.5.1
|
| |
|
|
|
|
| |
individual_store_remove_individual_and_disconnect
|
|
|
|
| |
cache before creating new pixbuf
|
| |
|
|
|
|
|
| |
Fixes bgo#644470 - Empathy needs to catch up with Folks interface name change
(API/ABI breaks)
|
|
|
|
|
| |
Helps bgo#644470 - Empathy needs to catch up with Folks interface name change
(API/ABI breaks)
|
|
|
|
|
| |
Helps bgo#644470 - Empathy needs to catch up with Folks interface name change
(API/ABI breaks)
|
|
|
|
|
| |
Helps bgo#644470 - Empathy needs to catch up with Folks interface name change
(API/ABI breaks)
|
|
|
|
|
|
|
|
|
|
| |
Generalise the mechanism used to determine whether a persona is to be
displayed by Empathy to also take into account whether the persona is the
user and, if so, whether they're in the contact list.
This bumps the libfolks dependency to 0.3.5.
Closes: bgo#637151
|
|
|
|
| |
Fixes bgo#637847.
|
|
|
|
|
| |
Catch up with three interface renamings which have happened in folks master.
This bumps Empathy's folks dependency to 0.3.3. Closes: bgo#637097
|
|
|
|
| |
empathy_pixbuf_avatar_from_individual_scaled_finish
|
| |
|
| |
|
| |
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|
|
|
|
|
| |
The future!
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
| |
They were removed from folks with commit
def47dffa31a95ec6bd333f43c69822416098283. This doesn't require a dependency
bump, since they're being replaced with calls to methods which exist in folks
0.3.1. See: bgo#629078. Closes: bgo#634754
|
| |
|
|
|
|
| |
Helps bgo#625969.
|
|
|
|
|
|
|
| |
When adding a new contact _with_ an alias set, the code in
EmpathyIndividualStore was listening to (and acting on) property notifications
(such as alias changes) for the individual before adding the individual to the
store, resulting in duplicate contact listings. Closes: bgo#629380
|
|
|
|
|
|
|
|
| |
EmpathyIndividualStore connects to some signals on all of the (Telepathy)
Personas in each Individual it stores. If an Individual changes its set of
Personas, some of those signals might end up never getting disconnected. This
fixes that by listening to FolksIndividual::personas-changed and disconnecting
signals as appropriate. Closes: bgo#628153
|
|
|
|
| |
Closes: bgo#628421
|
| |
|
| |
|
|
|
|
|
|
|
| |
Automatically cancel all pending avatar load operations when disposing of
an EmpathyIndividualStore. This prevents crashes when linking individuals in
the case that the EmpathyIndividualStore in the linking dialogue gets
notified of the new linked individual just before it's destroyed.
|
| |
|
|
|
|
| |
Closes: bgo#626162
|
| |
|
|
|
|
| |
Added missing default cases and missing enum cases.
|
|
|
|
|
|
|
| |
This rewrites the weak pointer code for active individuals in
EmpathyIndividualStore to use weak references, which has the added benefit of
meaning we can remove the timeout if the individual disappears, rather than
executing it anyway and just bailing out. Closes: bgo#625641
|
|
|
|
|
|
| |
the show offline property was moved from the individual store to the
individual view. this allows to easily and automatically search through
offline contacts as well.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The libfolks Capabilities interface will be removed temporarily, so we can't
rely upon it for now.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
empathy_contact_dup_from_folks_individual().
|
|
|
|
| |
folks_individual_from_empathy_contact() to make it clear that the return value has been referenced.
|
| |
|
| |
|
|
|
|
| |
style.
|
| |
|
| |
|
| |
|
|
|
|
| |
store in the individual store.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
with mainline Empathy.
|