Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixes a segfault in empathy-individual-store.c | Cosimo Alfarano | 2011-09-02 | 1 | -0/+8 |
| | | | | | | | | | | | When a contact cannot be obtained from an individual, icon_name and contact will be NULL, leading to g_hash_table_lookup for a NULL-value, segfaulting. Although there's probably an underlying error somewhere, the NULL case should be handled, being a valid return value for the method; https://bugzilla.gnome.org/show_bug.cgi?id=657914 | ||||
* | coding style fixEMPATHY_3_1_90 | Guillaume Desmottes | 2011-08-29 | 1 | -2/+2 |
| | |||||
* | contact list: optimize loading contacts | Alban Crequy | 2011-08-29 | 1 | -90/+111 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous algorithm was O(n^2) with the number of contacts. Each contact can be in several groups, so when a contact is added or updated, we iterated over all the contact list to find the rows representing the contact. When connecting to an account and getting all the contacts, this was too slow. The groups are stored in the GtkTreeStore and suffer from the same problem: to look for a group, it needed to iterate on all contacts. The new algorithm maintains a hash from the contact to the list of rows representing it, and another hash from the group to the row representing it. On Empathy 2.30.2 when tested on MeeGo with 300 contacts, loading the contacts is faster: roughly 9 seconds before the patch, 3 seconds after. On Empathy 3.1.5, it seems to load in background so I don't know how to measure the time lost in GtkTreeStore. But before the patch, GProf says 23% is lost in individual_store_find_contact_foreach(), and after the patch it is not visible anymore. And "time" says we win 5s of CPU when starting+quitting Empathy: Before the patch: After the patch: real 0m23.485s real 0m23.460s user 0m13.805s user 0m8.305s sys 0m0.308s sys 0m0.316s https://bugzilla.gnome.org/show_bug.cgi?id=657086 | ||||
* | Don't assume that all FolksIndividuals have a corresponding EmpathyContact. | Travis Reitter | 2011-08-22 | 1 | -16/+23 |
| | | | | | | | Closes: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a valid TpContact Signed-off-by: Jonny Lamb <jonnylamb@gnome.org> | ||||
* | Don't assume that all TpfPersonas contain valid TpContacts | Travis Reitter | 2011-08-22 | 1 | -23/+34 |
| | | | | | | | Helps: bgo#653599 - Empathy shouldn't assume all TpfPersonas contain a valid TpContact Signed-off-by: Jonny Lamb <jonnylamb@gnome.org> | ||||
* | individual-store: keep track of the number of events associated with each row | Guillaume Desmottes | 2011-06-08 | 1 | -0/+1 |
| | |||||
* | Only retrieve server-stored groups for Individuals with TpContacts. | Travis Reitter | 2011-06-07 | 1 | -12/+13 |
| | | | | Helps: bgo#648822 - Port Empathy to Folks 0.5.1 | ||||
* | Adapt to API change in folks_group_details_get_groups(). | Travis Reitter | 2011-06-07 | 1 | -7/+14 |
| | | | | Helps: bgo#648822 - Port Empathy to Folks 0.5.1 | ||||
* | Adapt to API break in folks_individual_get_personas. | Travis Reitter | 2011-06-07 | 1 | -42/+79 |
| | | | | Helps: bgo#648822 - Port Empathy to Folks 0.5.1 | ||||
* | Don't conflate TpfPersona and FolksPersona. | Travis Reitter | 2011-06-07 | 1 | -2/+2 |
| | |||||
* | export individual_store_add_individual_and_connect and ↵ | Guillaume Desmottes | 2011-06-01 | 1 | -2/+2 |
| | | | | individual_store_remove_individual_and_disconnect | ||||
* | individual_store_get_individual_status_icon_with_icon_name: look in the ↵ | Guillaume Desmottes | 2011-05-02 | 1 | -1/+6 |
| | | | | cache before creating new pixbuf | ||||
* | Fix warnings from GCC 4.6 about variables that are set but not used. | Kjartan Maraas | 2011-03-17 | 1 | -23/+0 |
| | |||||
* | Adjust for Folks PresenceOwner -> PresenceDetails rename | Travis Reitter | 2011-03-15 | 1 | -17/+17 |
| | | | | | Fixes bgo#644470 - Empathy needs to catch up with Folks interface name change (API/ABI breaks) | ||||
* | Adjust for Folks Groupable -> GroupDetails rename | Travis Reitter | 2011-03-15 | 1 | -1/+2 |
| | | | | | Helps bgo#644470 - Empathy needs to catch up with Folks interface name change (API/ABI breaks) | ||||
* | Adjust for Folks Favouritable -> FavouriteDetails rename | Travis Reitter | 2011-03-15 | 1 | -1/+2 |
| | | | | | Helps bgo#644470 - Empathy needs to catch up with Folks interface name change (API/ABI breaks) | ||||
* | Adjust for Folks Aliasable -> AliasDetails rename | Travis Reitter | 2011-03-15 | 1 | -12/+14 |
| | | | | | Helps bgo#644470 - Empathy needs to catch up with Folks interface name change (API/ABI breaks) | ||||
* | Bug 637151 — Hide the user Individual from the contact list | Philip Withnall | 2011-02-18 | 1 | -2/+2 |
| | | | | | | | | | | Generalise the mechanism used to determine whether a persona is to be displayed by Empathy to also take into account whether the persona is the user and, if so, whether they're in the contact list. This bumps the libfolks dependency to 0.3.5. Closes: bgo#637151 | ||||
* | Adjust for FolksHasPresence -> FolksPresenceOwner | Travis Reitter | 2011-02-01 | 1 | -14/+17 |
| | | | | Fixes bgo#637847. | ||||
* | Bug 637097 — Port to latest folks API changes | Philip Withnall | 2010-12-14 | 1 | -12/+15 |
| | | | | | Catch up with three interface renamings which have happened in folks master. This bumps Empathy's folks dependency to 0.3.3. Closes: bgo#637097 | ||||
* | properly manage the reference of the pixbuf returned by ↵ | Guillaume Desmottes | 2010-11-24 | 1 | -0/+1 |
| | | | | empathy_pixbuf_avatar_from_individual_scaled_finish | ||||
* | individual_avatar_pixbuf_received_cb: don't leak the iters | Guillaume Desmottes | 2010-11-18 | 1 | -0/+2 |
| | |||||
* | factor out free_iters | Guillaume Desmottes | 2010-11-18 | 1 | -7/+10 |
| | |||||
* | individual_store_name_sort_func: don't leak names | Guillaume Desmottes | 2010-11-18 | 1 | -0/+2 |
| | |||||
* | empathy-individual-store: only check for presence in presence-enabled personas | Jonny Lamb | 2010-11-16 | 1 | -1/+7 |
| | | | | Signed-off-by: Jonny Lamb <jonnylamb@gnome.org> | ||||
* | contact: enable showing a phone next to contacts who are on phones | Jonny Lamb | 2010-11-16 | 1 | -0/+38 |
| | | | | | | The future! Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> | ||||
* | individual_store_contact_sort: account is not supposed to be NULL | Guillaume Desmottes | 2010-11-15 | 1 | -0/+3 |
| | |||||
* | Stop using removed Individual convenience methods from folks | Philip Withnall | 2010-11-13 | 1 | -20/+22 |
| | | | | | | | They were removed from folks with commit def47dffa31a95ec6bd333f43c69822416098283. This doesn't require a dependency bump, since they're being replaced with calls to methods which exist in folks 0.3.1. See: bgo#629078. Closes: bgo#634754 | ||||
* | Allow to drop contacts on the group names (#619961) | Vitaly Minko | 2010-10-28 | 1 | -1/+1 |
| | |||||
* | Use Folks to check the ability to remove Individuals in the store & view. | Travis Reitter | 2010-10-16 | 1 | -10/+4 |
| | | | | Helps bgo#625969. | ||||
* | Add individuals to the EmpathyIndividualStore before updating them | Philip Withnall | 2010-09-15 | 1 | -1/+2 |
| | | | | | | | When adding a new contact _with_ an alias set, the code in EmpathyIndividualStore was listening to (and acting on) property notifications (such as alias changes) for the individual before adding the individual to the store, resulting in duplicate contact listings. Closes: bgo#629380 | ||||
* | Ensure we disconnect from signals on Individuals' Personas as they're removed | Philip Withnall | 2010-09-02 | 1 | -34/+48 |
| | | | | | | | | EmpathyIndividualStore connects to some signals on all of the (Telepathy) Personas in each Individual it stores. If an Individual changes its set of Personas, some of those signals might end up never getting disconnected. This fixes that by listening to FolksIndividual::personas-changed and disconnecting signals as appropriate. Closes: bgo#628153 | ||||
* | Fix the audio/video icon in the contact list | Philip Withnall | 2010-09-01 | 1 | -31/+51 |
| | | | | Closes: bgo#628421 | ||||
* | Fix the "Show Protocols" option with linked contacts | Philip Withnall | 2010-08-26 | 1 | -1/+1 |
| | |||||
* | Ensure we disconnect signals from all Personas in an Individual | Philip Withnall | 2010-08-19 | 1 | -19/+58 |
| | |||||
* | Allow cancellation of avatar load operations | Philip Withnall | 2010-08-19 | 1 | -9/+48 |
| | | | | | | | Automatically cancel all pending avatar load operations when disposing of an EmpathyIndividualStore. This prevents crashes when linking individuals in the case that the EmpathyIndividualStore in the linking dialogue gets notified of the new linked individual just before it's destroyed. | ||||
* | Minor coding style fixes in EmpathyIndividual[Store|View] | Philip Withnall | 2010-08-09 | 1 | -2/+2 |
| | |||||
* | Fix capability change notification in the EmpathyIndividualStore | Philip Withnall | 2010-08-09 | 1 | -6/+35 |
| | | | | Closes: bgo#626162 | ||||
* | Fix constness of various variables and parameters | Philip Withnall | 2010-08-05 | 1 | -2/+2 |
| | |||||
* | Fix missing entries in switch statements | Philip Withnall | 2010-08-05 | 1 | -0/+3 |
| | | | | Added missing default cases and missing enum cases. | ||||
* | Fix memory corruption introduced by not removing a weak pointer | Philip Withnall | 2010-08-05 | 1 | -17/+39 |
| | | | | | | | This rewrites the weak pointer code for active individuals in EmpathyIndividualStore to use weak references, which has the added benefit of meaning we can remove the timeout if the individual disappears, rather than executing it anyway and just bailing out. Closes: bgo#625641 | ||||
* | refactored show_offline property to the view | Felix Kaser | 2010-08-03 | 1 | -103/+3 |
| | | | | | | the show offline property was moved from the individual store to the individual view. this allows to easily and automatically search through offline contacts as well. | ||||
* | fixing a method name typo | Felix Kaser | 2010-08-03 | 1 | -2/+2 |
| | |||||
* | Merge remote branch 'pwith/folks-integ-rebase1-fixes-rebase1' into folks-fixes | Travis Reitter | 2010-07-22 | 1 | -8/+19 |
| | |||||
* | Re-add support for the "People Nearby" group | Philip Withnall | 2010-07-21 | 1 | -4/+12 |
| | |||||
* | Calculate contact capabilities ourselves. | Travis Reitter | 2010-07-21 | 1 | -12/+33 |
| | | | | | The libfolks Capabilities interface will be removed temporarily, so we can't rely upon it for now. | ||||
* | Enclose a non-trivial expression in () in an assignment. | Travis Reitter | 2010-07-21 | 1 | -1/+1 |
| | |||||
* | Also sort the IndividualStore by underlying protocol and account ID. | Travis Reitter | 2010-07-21 | 1 | -3/+24 |
| | |||||
* | Don't enclose trivial blocks in {}. | Travis Reitter | 2010-07-21 | 1 | -33/+11 |
| | |||||
* | Use explicit '!= NULL' for pointer boolean expressions. | Travis Reitter | 2010-07-21 | 1 | -2/+2 |
| | |||||
* | Don't leak references to the contacts returned from ↵ | Travis Reitter | 2010-07-21 | 1 | -0/+4 |
| | | | | empathy_contact_dup_from_folks_individual(). | ||||
* | Add 'dup' to the names of empathy_contact_from_folks_individual() and ↵ | Travis Reitter | 2010-07-21 | 1 | -2/+2 |
| | | | | folks_individual_from_empathy_contact() to make it clear that the return value has been referenced. | ||||
* | Use the gio async pattern for fetching Individuals' avatars | Travis Reitter | 2010-07-21 | 1 | -10/+27 |
| | |||||
* | Take advantage of the tp_clear_* utility functions. | Travis Reitter | 2010-07-21 | 1 | -23/+5 |
| | |||||
* | Use explicit boolean expressions for if-conditionals, according to Telepathy ↵ | Travis Reitter | 2010-07-21 | 1 | -1/+1 |
| | | | | style. | ||||
* | Add some more validation when sorting the contact list. | Travis Reitter | 2010-07-21 | 1 | -8/+10 |
| | |||||
* | Allow changing of individuals' aliases | Philip Withnall | 2010-07-21 | 1 | -3/+1 |
| | |||||
* | Fix some referencing bugs with the IndividualStore and IndividualView | Philip Withnall | 2010-07-21 | 1 | -5/+2 |
| | |||||
* | Follow the new tree store insertion convention used by the contact list ↵ | Travis Reitter | 2010-07-21 | 1 | -7/+8 |
| | | | | store in the individual store. | ||||
* | Finish adding favourites support | Philip Withnall | 2010-07-21 | 1 | -20/+21 |
| | |||||
* | Support contact removal | Travis Reitter | 2010-07-21 | 1 | -2/+8 |
| | |||||
* | Use the new FolksFavourite interface for favourites support | Philip Withnall | 2010-07-21 | 1 | -3/+1 |
| | |||||
* | Avoid potential segfaults if there are no contacts on the first pass. | Travis Reitter | 2010-07-21 | 1 | -5/+8 |
| | |||||
* | Re-implement the context menu for Individuals | Travis Reitter | 2010-07-21 | 1 | -23/+18 |
| | |||||
* | Implement avatar support. | Travis Reitter | 2010-07-21 | 1 | -10/+23 |
| | |||||
* | Base the contact list around libfolks metacontacts. Not yet to feature-parity | Travis Reitter | 2010-07-21 | 1 | -0/+1830 |
with mainline Empathy. |