| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
This doesn't fix bgo#647891, but I think it makes the loop clearer.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
|
|
|
|
| |
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=609419
|
|
|
|
| |
Added missing default cases and missing enum cases.
|
|
|
|
| |
The "name" API was a relic of Gossip.
|
|
|
|
|
|
| |
We can't rely on the fact that compare_separator_and_groups only returns
0 in the case it compares two contacts. But we can completely rely on its
result if we give it at least one non-contact.
|
| |
|
|
|
|
|
|
| |
We can't assume that the group and seperator sorting function never returns 0,
so don't use that to imply that both A and B are contacts. Instead just check
if A and B are contacts...
|
| |
|
| |
|
|
|
|
| |
the advantage of insert_with_values is that only the row-added signal is emitted and not first row-added (while the row is empty) and then row-changed
|
|
|
|
|
|
| |
(fixes #612864)
Signed-off-by: Jonny Lamb <jonnylamb@gnome.org>
|
|
|
|
| |
Further, set show-groups = False for the contact list in EmpathyChat
|
| |
|
|
|
|
| |
There is no reason to use them when favourite contacts are enabled any more.
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Even if we choose not to sort People Nearby, this patch is useful because it
makes how the sorting of groups is done much clearer and allows us to add
other fake groups in the future.
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when the contact list was in compact mode your contacts'
status mesasges were not shown. With this patch, status messages are
shown in the space to the right of the contact's name, in the same
small, grey font as in the expanded view.
Only custom messages are shown; fallback strings like _("Available") are
redundant and made the list way too hard to read, so are not shown.
This patch does show that most of my contacts are too boring to have
status messages...
|
|
|
|
| |
Fake groups can't be modified.
|
|
|
|
| |
We don't need it any more.
|
| |
|
| |
|
|
|
|
| |
They are already displayed in a separated group on top of the contact list
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
specially-named favourites group.
|
| |
|
|
|
|
| |
turn it on.
|
|
|
|
| |
star next to their name and adds them to the top of the contact list)
|
|
|
|
| |
There is no reason to not to (#607207).
|
|
|
|
| |
variable
|
| |
|
|
|
|
| |
icon_name is NULL
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following comments should be fixed in this commit:
- tp_group_update_members: add "old" and "new" in comments so we known which
contact we are talking about.
- Always use TpHandle instead of guint when storing handles in variables.
- contact_list_store_member_renamed_cb: would be good to share the common code
with contact_list_store_members_changed_cb in a common function
One comment about the last one: I split out common code into two new functions:
contact_list_store_add_contact_and_connect(), and the matching
contact_list_store_remove_contact_and_disconnect(). I wondered whether the
signal connection/disconnection should just be added to the _add_contact() and
_remove_contact() functions directly, but they do seem to be used in other
places without connecting to signals, so i thought it would be safer to simply
add some wrapper functions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Telepathy-glib has a enum value for the MembersChanged signal to signify that a
user's ID has changed. Previously, empathy was simply interpreting this as if a
user with the old name had left the chat and a different user with the new name
had entered the chat. This change handles this case more gracefully by updating
the contact's id (and name) when this change reason is present
One thing that does not yet work with this patch is if you are engaged in a
private chat with a person and they change their nick in the middle of the chat.
Then the EmpathyContact* that you are chatting with is no longer the
EmpathyContact* representing the remote user, so messages won't be delivered
properly. When we detect that a user has been 'renamed', we probably need to
somehow go through all of the private chats with that person and swap out the
old (invalid) EmpathyContact* and replace it with the new one so that the chat
can continue without interruption.
|
| |
|
|
|
|
|
| |
This method just disconnect signals, release references and remove idle
callbacks so it should really be a dispose, not a finalize.
|
|
|
|
|
| |
This ensures that the setup cb isn't called on a destroyed object
(#598452).
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
svn path=/trunk/; revision=2249
|
|
|
|
|
|
| |
branch.
svn path=/trunk/; revision=2086
|
|
|
|
| |
svn path=/trunk/; revision=2062
|
|
|
|
| |
svn path=/trunk/; revision=2053
|
|
|
|
|
|
| |
G_TYPE_INSTANCE_GET_PRIVATE all the time.
svn path=/trunk/; revision=1082
|
|
|
|
| |
svn path=/trunk/; revision=1066
|
|
|
|
| |
svn path=/trunk/; revision=1038
|
|
|
|
|
|
| |
Fixes bug #528287.
svn path=/trunk/; revision=955
|
|
|
|
| |
svn path=/trunk/; revision=943
|
|
|
|
| |
svn path=/trunk/; revision=942
|
|
|
|
| |
svn path=/trunk/; revision=804
|
|
|
|
|
|
| |
some _run_until_ready.
svn path=/trunk/; revision=755
|
|
|
|
| |
svn path=/trunk/; revision=734
|
|
|
|
| |
svn path=/trunk/; revision=688
|
|
|
|
|
|
| |
properties directly in EmpathyContact
svn path=/trunk/; revision=601
|
|
|
|
| |
svn path=/trunk/; revision=587
|
|
|
|
| |
svn path=/trunk/; revision=586
|
|
|
|
| |
svn path=/trunk/; revision=585
|
|
|
|
| |
svn path=/trunk/; revision=574
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-10-28 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-contact-list-view.c:
* libempathy-gtk/empathy-contact-list-store.c:
* libempathy-gtk/empathy-contact-list-store.h:
* doc/libempathy-gtk/libempathy-gtk.types:
* doc/libempathy-gtk/tmpl/empathy-contact-list-store.sgml: Rename
COL_XXX to EMPATHY_CONTACT_LIST_STORE_COL_XXX since it's in public API.
Fixes bug #470804.
svn path=/trunk/; revision=405
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-10-13 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-main-window.c:
* libempathy-gtk/empathy-presence-chooser.c:
* libempathy-gtk/empathy-contact-list-view.c:
* libempathy-gtk/empathy-contact-widget.c:
* libempathy-gtk/empathy-chat.c:
* libempathy-gtk/empathy-contact-list-store.c:
* libempathy-gtk/empathy-chat-window.c:
* libempathy/empathy-idle.c:
* tests/contact-manager.c: Use g_timeout_add_seconds when appropriated
to avoid weaking the process too much.
svn path=/trunk/; revision=370
|
|
|
|
|
|
|
|
|
|
| |
2007-10-01 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-contact-list-store.c: Disconnect signals on
list and contacts when finalizing the store.
svn path=/trunk/; revision=345
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-09-08 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-images.h:
* libempathy-gtk/empathy-chat.glade:
* libempathy-gtk/empathy-contact-list-view.c:
* libempathy-gtk/empathy-contact-list-store.c:
* libempathy-gtk/empathy-contact-list-store.h:
* libempathy-gtk/Makefile.am:
* libempathy-gtk/empathy-chat-window.c:
* libempathy/empathy-contact.c:
* libempathy/empathy-contact.h: Adding UI to start a VoIP call. It does
nothing yet. Most of the code is ported from Gossip patch
(Raphael Slinckx, Xavier Claessens).
svn path=/trunk/; revision=292
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-09-08 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-contact-list-view.c:
* libempathy-gtk/empathy-contact-list-store.c: Make use of the search
function to correctly find when typing in the contact list view.
Fixes bug #472309 (Will Thompson, Xavier Claessens).
svn path=/trunk/; revision=290
|
|
|
|
|
|
| |
#459540 and bug #462907.
svn path=/trunk/; revision=280
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-08-07 Marco Barisione <marco@barisione.org>
* libempathy/Makefile.am:
* libempathy/empathy-marshal-main.c: Remove empathy-marshal-main.c and
include empathy-marshal.h from empathy-marshal.c.
* libempathy/Makefile.am:
* libempathy-gtk/Makefile.am: Generate files for enum types with
glib-mkenums.
* libempathy/empathy-contact.c:
* libempathy/empathy-idle.c:
* libempathy/empathy-message.c:
* libempathy/empathy-presence.c:
* libempathy-gtk/empathy-main-window.c:
* libempathy-gtk/empathy-preferences.c:
* doc/libempathy-gtk/libempathy-gtk.types:
* doc/libempathy-gtk/tmpl/empathy-contact-list-store.sgml: Use
g_param_spec_enum() and g_param_spec_flags() instead of
g_param_spec_(u)int.
Fixes bug #462465.
* libempathy-gtk/empathy-contact-list-store.c:
* libempathy-gtk/empathy-contact-list-store.h: Remove
empathy_contact_list_store_sort_get_type() as it's now auto-generated
by glib-mkenums.
svn path=/trunk/; revision=234
|
|
|
|
|
|
|
|
|
| |
2007-07-14 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/empathy-contact-list-store.c: Show avatars by default.
svn path=/trunk/; revision=188
|
|
2007-06-22 Xavier Claessens <xclaesse@gmail.com>
* libempathy/*.[ch]:
* libempathy-gtk/*.[ch]:
* src/*.[ch]: Rename all filenames starting with "gossip" by "empathy",
change namespace of all gossip_*() functions to empathy_*().
Fixes bug #444490 (Mario Danic, Xavier Claessens).
svn path=/trunk/; revision=170
|