aboutsummaryrefslogtreecommitdiffstats
path: root/src/empathy-map-view.c
diff options
context:
space:
mode:
authorXavier Claessens <xclaesse@gmail.com>2010-02-11 01:51:53 +0800
committerXavier Claessens <xclaesse@gmail.com>2010-02-11 03:14:20 +0800
commit41f9f0a717f8519cf8c69cb043198980fe503ebc (patch)
tree3cff33d8c48cc69a2778f27f56b15372416decba /src/empathy-map-view.c
parentddbfc6ec6a3b2ffab1f83471dbf1f82630292f8a (diff)
downloadgsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar.gz
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar.bz2
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar.lz
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar.xz
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.tar.zst
gsoc2013-empathy-41f9f0a717f8519cf8c69cb043198980fe503ebc.zip
Fix leaked GtkMenu
GtkMenu is initially unowned, which means ref_count is 1 and floating flag is set. gtk_menu_popup temporarily adds a ref, that will be dropped when the menu is popped down. So once the menu is popped up, we call g_object_ref_sink() to clear the floating flag, and g_object_unref() to drop the initial ref. Only the ref from gtk_menu_popup stay, and the menu will be finalized when it is popped down. Fixes bug #609567
Diffstat (limited to 'src/empathy-map-view.c')
-rw-r--r--src/empathy-map-view.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/empathy-map-view.c b/src/empathy-map-view.c
index b7b37549f..fd6106c95 100644
--- a/src/empathy-map-view.c
+++ b/src/empathy-map-view.c
@@ -175,6 +175,8 @@ marker_clicked_cb (ChamplainMarker *marker,
gtk_widget_show (menu);
gtk_menu_popup (GTK_MENU (menu), NULL, NULL, NULL, NULL,
event->button, event->time);
+ g_object_ref_sink (menu);
+ g_object_unref (menu);
return FALSE;
}