diff options
| author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 22:31:29 +0800 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 22:57:00 +0800 |
| commit | 5bb2c1c62a06e682ab48d530cae5f9614a90a75e (patch) | |
| tree | a847e5c1980d69126b8d7974808cb70923becb33 /src/empathy-main-window.c | |
| parent | ba6e07cc5a0bf75118c12fd5ebf05e4453a5dc80 (diff) | |
| download | gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.gz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.bz2 gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.lz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.xz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.zst gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.zip | |
Use _unref instead of _free _destroy when possible.unref
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'src/empathy-main-window.c')
| -rw-r--r-- | src/empathy-main-window.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/empathy-main-window.c b/src/empathy-main-window.c index 367ae067f..0e4b8bae5 100644 --- a/src/empathy-main-window.c +++ b/src/empathy-main-window.c @@ -1372,8 +1372,8 @@ empathy_main_window_finalize (GObject *window) g_object_unref (priv->individual_store); g_object_unref (priv->contact_manager); g_object_unref (priv->sound_mgr); - g_hash_table_destroy (priv->errors); - g_hash_table_destroy (priv->auths); + g_hash_table_unref (priv->errors); + g_hash_table_unref (priv->auths); /* disconnect all handlers of status-changed signal */ g_hash_table_iter_init (&iter, priv->status_changed_handlers); @@ -1381,7 +1381,7 @@ empathy_main_window_finalize (GObject *window) g_signal_handler_disconnect (TP_ACCOUNT (key), GPOINTER_TO_UINT (value)); - g_hash_table_destroy (priv->status_changed_handlers); + g_hash_table_unref (priv->status_changed_handlers); g_signal_handlers_disconnect_by_func (priv->event_manager, main_window_event_added_cb, |