Split EmpathyImportDialog and EmpathyImportWidget

Also, take this as a chance to GObject-ify everything.

1 files changed, 154 insertions, 339 deletions

diff --git a/src/empathy-import-dialog.c b/src/empathy-import-dialog.c
index a70a6eedd..4866b81c5 100644
--- a/src/empathy-import-dialog.c
+++ b/src/empathy-import-dialog.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008 Collabora Ltd.
+ * Copyright (C) 2008-2009 Collabora Ltd.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as
@@ -17,7 +17,8 @@
  * Boston, MA  02110-1301  USA
  *
  * Authors: Jonny Lamb <jonny.lamb@collabora.co.uk>
- * */
+ *          Cosimo Cecchi <cosimo.cecchi@collabora.co.uk>
+ */
 
 #include <config.h>
 
@@ -31,6 +32,7 @@
 
 #include "empathy-import-dialog.h"
 #include "empathy-import-pidgin.h"
+#include "empathy-import-widget.h"
 
 #define DEBUG_FLAG EMPATHY_DEBUG_OTHER
 #include <libempathy/empathy-debug.h>
@@ -39,25 +41,22 @@
 #include <libempathy/empathy-connection-managers.h>
 #include <libempathy-gtk/empathy-ui-utils.h>
 
-typedef struct
-{
-  GtkWidget *window;
-  GtkWidget *treeview;
-  GtkWidget *button_ok;
-  GtkWidget *button_cancel;
-  GList *accounts;
-} EmpathyImportDialog;
-
-enum
-{
-  COL_IMPORT = 0,
-  COL_PROTOCOL,
-  COL_NAME,
-  COL_SOURCE,
-  COL_ACCOUNT_DATA,
-  COL_COUNT
+enum {
+  PROP_PARENT = 1,
+  PROP_SHOW_WARNING
 };
 
+typedef struct {
+  GtkWindow *parent_window;
+
+  EmpathyImportWidget *iw;
+
+  gboolean show_warning;
+} EmpathyImportDialogPriv;
+
+G_DEFINE_TYPE (EmpathyImportDialog, empathy_import_dialog, GTK_TYPE_DIALOG)
+#define GET_PRIV(obj) EMPATHY_GET_PRIV (obj, EmpathyImportDialog)
+
 EmpathyImportAccountData *
 empathy_import_account_data_new (const gchar *source)
 {
@@ -92,377 +91,193 @@ empathy_import_account_data_free (EmpathyImportAccountData *data)
   g_slice_free (EmpathyImportAccountData, data);
 }
 
-static void
-import_dialog_create_account_cb (GObject *source,
-  GAsyncResult *result,
-  gpointer user_data)
+gboolean
+empathy_import_dialog_accounts_to_import (void)
 {
-  EmpathyImportAccountData *data = (EmpathyImportAccountData *) user_data;
-  EmpathyAccount *account;
-  GError *error = NULL;
-
-  account = empathy_account_manager_create_account_finish (
-    EMPATHY_ACCOUNT_MANAGER (source), result, &error);
-
-  if (account == NULL)
-    {
-      DEBUG ("Failed to create account: %s",
-          error ? error->message : "No error given");
-      g_clear_error (&error);
-      empathy_import_account_data_free (data);
-      return;
-    }
-
-  DEBUG ("account created\n");
-
-  g_object_unref (account);
+  return empathy_import_pidgin_accounts_to_import ();
 }
 
 static void
-import_dialog_add_account (EmpathyImportAccountData *data)
+import_dialog_add_import_widget (EmpathyImportDialog *self)
 {
-  EmpathyAccountManager *account_manager;
-  gchar *display_name;
-  GHashTable *properties;
-  GValue *username;
-
-  account_manager = empathy_account_manager_dup_singleton ();
-
-  DEBUG ("connection_manager: %s\n", data->connection_manager);
-
-  /* Set the display name of the account */
-  username = g_hash_table_lookup (data->settings, "account");
-  display_name = g_strdup_printf ("%s (%s)",
-      data->protocol,
-      g_value_get_string (username));
-
-  DEBUG ("display name: %s\n", display_name);
-
-  properties = g_hash_table_new (NULL, NULL);
-
-  empathy_account_manager_create_account_async (account_manager,
-      (const gchar*) data->connection_manager, data->protocol, display_name,
-      data->settings, properties, import_dialog_create_account_cb, NULL);
-
-  g_hash_table_unref (properties);
-  g_free (display_name);
-  g_object_unref (account_manager);
+  EmpathyImportWidget *iw;
+  EmpathyImportDialogPriv *priv = GET_PRIV (self);
+  GtkWidget *widget, *area;
+
+  area = gtk_dialog_get_content_area (GTK_DIALOG (self));
+  
+  iw = empathy_import_widget_new ();
+  widget = empathy_import_widget_get_widget (iw);
+  gtk_box_pack_start (GTK_BOX (area), widget, FALSE, FALSE, 0);
+  gtk_widget_show (widget);
+
+  priv->iw = iw;
+  
+  gtk_dialog_add_buttons (GTK_DIALOG (self), GTK_STOCK_CANCEL,
+      GTK_RESPONSE_CANCEL, GTK_STOCK_OK, GTK_RESPONSE_OK, NULL);
 }
 
-static gboolean
-import_dialog_account_id_in_list (GList *accounts,
-                                  const gchar *account_id)
+static void
+import_dialog_show_warning_message (EmpathyImportDialog *self)
 {
-  GList *l;
+  GtkWidget *hbox, *vbox, *w;
 
-  for (l = accounts; l; l = l->next)
-    {
-      EmpathyAccount *account = l->data;
-      const gchar *account_string;
-      GValue *value;
-      gboolean result;
-      const GHashTable *parameters;
+  vbox = gtk_vbox_new (FALSE, 12);
+  hbox = gtk_hbox_new (FALSE, 12);
 
-      parameters = empathy_account_get_parameters (account);
+  w = gtk_label_new (_("No accounts to import could be found. Empathy "
+          "currently only supports importing accounts from Pidgin."));
+  gtk_label_set_line_wrap  (GTK_LABEL (w), TRUE);
+  gtk_label_set_selectable (GTK_LABEL (w), TRUE);
+  gtk_misc_set_alignment   (GTK_MISC  (w), 0.0, 0.0);
+  gtk_box_pack_start (GTK_BOX (vbox), w, FALSE, FALSE, 0);
 
-      value = g_hash_table_lookup ((GHashTable *) parameters, "account");
+  w = gtk_image_new_from_stock (GTK_STOCK_DIALOG_WARNING,
+      GTK_ICON_SIZE_DIALOG);
+  gtk_misc_set_alignment (GTK_MISC (w), 0.5, 0.0);
+  gtk_box_pack_start (GTK_BOX (hbox), w, FALSE, FALSE, 0);
 
-      if (value == NULL)
-        continue;
+  gtk_box_pack_start (GTK_BOX (hbox), vbox, TRUE, TRUE, 0);
 
-      account_string = g_value_get_string (value);
+  w = gtk_dialog_get_content_area (GTK_DIALOG (self));
+  gtk_box_pack_start (GTK_BOX (w), hbox, FALSE, FALSE, 0);
 
-      result = tp_strdiff (account_string, account_id);
+  gtk_box_set_spacing (GTK_BOX (w), 14); /* 14 + 2 * 5 = 24 */
 
-      if (!result)
-        return TRUE;
-    }
+  gtk_dialog_add_button (GTK_DIALOG (self), GTK_STOCK_CLOSE,
+      GTK_RESPONSE_CLOSE);
 
-  return FALSE;
+  gtk_widget_show_all (w);
 }
 
-static gboolean protocol_is_supported (EmpathyImportAccountData *data)
+static void
+impl_signal_response (GtkDialog *dialog,
+    gint response_id)
 {
-  EmpathyConnectionManagers *cm =
-      empathy_connection_managers_dup_singleton ();
-  GList *cms = empathy_connection_managers_get_cms (cm);
-  GList *l;
-  gboolean proto_is_supported = FALSE;
+  EmpathyImportDialogPriv *priv = GET_PRIV (dialog);
 
-  for (l = cms; l; l = l->next)
-    {
-      TpConnectionManager *tp_cm = l->data;
-      const gchar *cm_name = tp_connection_manager_get_name (tp_cm);
-      if (tp_connection_manager_has_protocol (tp_cm,
-          (const gchar*)data->protocol))
-        {
-          data->connection_manager = g_strdup (cm_name);
-          proto_is_supported = TRUE;
-          break;
-        }
-    }
-
-  g_object_unref (cm);
+  if (response_id == GTK_RESPONSE_OK)
+    empathy_import_widget_add_selected_accounts (priv->iw);
 
-  return proto_is_supported;
+  gtk_widget_destroy (GTK_WIDGET (dialog));
 }
 
 static void
-import_dialog_add_accounts_to_model (EmpathyImportDialog *dialog)
+do_get_property (GObject *object,
+    guint property_id,
+    GValue *value,
+    GParamSpec *pspec)
 {
-  GtkTreeModel *model;
-  GtkTreeIter iter;
-  GList *l;
-  EmpathyAccountManager *manager = empathy_account_manager_dup_singleton ();
+  EmpathyImportDialogPriv *priv = GET_PRIV (object);
 
-  model = gtk_tree_view_get_model (GTK_TREE_VIEW (dialog->treeview));
-
-  for (l = dialog->accounts; l; l = l->next)
+  switch (property_id)
     {
-      GValue *value;
-      EmpathyImportAccountData *data = l->data;
-      gboolean import;
-      GList *accounts;
-
-      if (!protocol_is_supported (data))
-        continue;
-
-      value = g_hash_table_lookup (data->settings, "account");
-
-      accounts = empathy_account_manager_dup_accounts (manager);
-
-      /* Only set the "Import" cell to be active if there isn't already an
-       * account set up with the same account id. */
-      import = !import_dialog_account_id_in_list (accounts,
-          g_value_get_string (value));
-
-      g_list_foreach (accounts, (GFunc) g_object_unref, NULL);
-      g_list_free (accounts);
-
-      gtk_list_store_append (GTK_LIST_STORE (model), &iter);
-
-      gtk_list_store_set (GTK_LIST_STORE (model), &iter,
-          COL_IMPORT, import,
-          COL_PROTOCOL, data->protocol,
-          COL_NAME, g_value_get_string (value),
-          COL_SOURCE, data->source,
-          COL_ACCOUNT_DATA, data,
-          -1);
+    case PROP_PARENT:
+      g_value_set_object (value, priv->parent_window);
+      break;
+    case PROP_SHOW_WARNING:
+      g_value_set_boolean (value, priv->show_warning);
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
     }
-
-  g_object_unref (manager);
-}
-
-static void
-import_dialog_cell_toggled_cb (GtkCellRendererToggle *cell_renderer,
-                               const gchar *path_str,
-                               EmpathyImportDialog *dialog)
-{
-  GtkTreeModel *model;
-  GtkTreeIter iter;
-  GtkTreePath *path;
-
-  path = gtk_tree_path_new_from_string (path_str);
-  model = gtk_tree_view_get_model (GTK_TREE_VIEW (dialog->treeview));
-
-  gtk_tree_model_get_iter (model, &iter, path);
-
-  gtk_list_store_set (GTK_LIST_STORE (model), &iter,
-      COL_IMPORT, !gtk_cell_renderer_toggle_get_active (cell_renderer),
-      -1);
-
-  gtk_tree_path_free (path);
 }
 
 static void
-import_dialog_set_up_account_list (EmpathyImportDialog *dialog)
-{
-  GtkListStore *store;
-  GtkTreeView *view;
-  GtkTreeViewColumn *column;
-  GtkCellRenderer *cell;
-
-  store = gtk_list_store_new (COL_COUNT, G_TYPE_BOOLEAN, G_TYPE_STRING,
-      G_TYPE_STRING, G_TYPE_STRING, G_TYPE_POINTER);
-
-  gtk_tree_view_set_model (GTK_TREE_VIEW (dialog->treeview),
-      GTK_TREE_MODEL (store));
-
-  g_object_unref (store);
-
-  view = GTK_TREE_VIEW (dialog->treeview);
-  gtk_tree_view_set_headers_visible (view, TRUE);
-
-  /* Import column */
-  cell = gtk_cell_renderer_toggle_new ();
-  gtk_tree_view_insert_column_with_attributes (view, -1,
-      /* Translators: this is the header of a treeview column */
-      _("Import"), cell,
-      "active", COL_IMPORT,
-      NULL);
-
-  g_signal_connect (cell, "toggled",
-      G_CALLBACK (import_dialog_cell_toggled_cb), dialog);
-
-  /* Protocol column */
-  column = gtk_tree_view_column_new ();
-  gtk_tree_view_column_set_title (column, _("Protocol"));
-  gtk_tree_view_column_set_expand (column, TRUE);
-  gtk_tree_view_append_column (view, column);
-
-  cell = gtk_cell_renderer_text_new ();
-  g_object_set (cell,
-      "editable", FALSE,
-      NULL);
-  gtk_tree_view_column_pack_start (column, cell, TRUE);
-  gtk_tree_view_column_add_attribute (column, cell, "text", COL_PROTOCOL);
-
-  /* Account column */
-  column = gtk_tree_view_column_new ();
-  gtk_tree_view_column_set_title (column, _("Account"));
-  gtk_tree_view_column_set_expand (column, TRUE);
-  gtk_tree_view_append_column (view, column);
-
-  cell = gtk_cell_renderer_text_new ();
-  g_object_set (cell,
-      "editable", FALSE,
-      NULL);
-  gtk_tree_view_column_pack_start (column, cell, TRUE);
-  gtk_tree_view_column_add_attribute (column, cell, "text", COL_NAME);
-
-  /* Source column */
-  column = gtk_tree_view_column_new ();
-  gtk_tree_view_column_set_title (column, _("Source"));
-  gtk_tree_view_column_set_expand (column, TRUE);
-  gtk_tree_view_append_column (view, column);
-
-  cell = gtk_cell_renderer_text_new ();
-  g_object_set (cell,
-      "editable", FALSE,
-      NULL);
-  gtk_tree_view_column_pack_start (column, cell, TRUE);
-  gtk_tree_view_column_add_attribute (column, cell, "text", COL_SOURCE);
-
-  import_dialog_add_accounts_to_model (dialog);
-}
-
-static gboolean
-import_dialog_tree_model_foreach (GtkTreeModel *model,
-                                  GtkTreePath *path,
-                                  GtkTreeIter *iter,
-                                  gpointer user_data)
+do_set_property (GObject *object,
+    guint property_id,
+    const GValue *value,
+    GParamSpec *pspec)
 {
-  gboolean to_import;
-  EmpathyImportAccountData *data;
-
-  gtk_tree_model_get (model, iter,
-      COL_IMPORT, &to_import,
-      COL_ACCOUNT_DATA, &data,
-      -1);
-
-  if (to_import)
-    import_dialog_add_account (data);
-
-  return FALSE;
-}
+  EmpathyImportDialogPriv *priv = GET_PRIV (object);
 
-static void
-import_dialog_response_cb (GtkWidget *widget,
-                           gint response,
-                           EmpathyImportDialog *dialog)
-{
-  if (response == GTK_RESPONSE_OK)
+  switch (property_id)
     {
-      GtkTreeModel *model;
-
-      model = gtk_tree_view_get_model (GTK_TREE_VIEW (dialog->treeview));
-      gtk_tree_model_foreach (model, import_dialog_tree_model_foreach, dialog);
+    case PROP_PARENT:
+      priv->parent_window = g_value_get_object (value);
+      break;
+    case PROP_SHOW_WARNING:
+      priv->show_warning = g_value_get_boolean (value);
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
     }
-
-  gtk_widget_destroy (dialog->window);
 }
 
 static void
-import_dialog_destroy_cb (GtkWidget *widget,
-                          EmpathyImportDialog *dialog)
+do_constructed (GObject *obj)
 {
-  g_list_foreach (dialog->accounts, (GFunc) empathy_import_account_data_free,
-    NULL);
-  g_list_free (dialog->accounts);
-  g_slice_free (EmpathyImportDialog, dialog);
-}
+  EmpathyImportDialog *self = EMPATHY_IMPORT_DIALOG (obj);
+  EmpathyImportDialogPriv *priv = GET_PRIV (self);
+  gboolean have_accounts;
 
-gboolean
-empathy_import_dialog_accounts_to_import (void)
-{
-  return empathy_import_pidgin_accounts_to_import ();
-}
+  have_accounts = empathy_import_dialog_accounts_to_import ();
 
-void
-empathy_import_dialog_show (GtkWindow *parent,
-                            gboolean warning)
-{
-  static EmpathyImportDialog *dialog = NULL;
-  GtkBuilder *gui;
-  gchar *filename;
-  GList *accounts = NULL;
-
-  /* This window is a singleton. If it already exist, present it */
-  if (dialog)
-    {
-      gtk_window_present (GTK_WINDOW (dialog->window));
-      return;
-    }
-
-  /* Load all accounts from all supported applications */
-  accounts = g_list_concat (accounts, empathy_import_pidgin_load ());
-
-  /* Check if we have accounts to import before creating the window */
-  if (!accounts)
+  if (!have_accounts)
     {
-      GtkWidget *message;
-
-      if (warning)
+      if (priv->show_warning)
         {
-          message = gtk_message_dialog_new (parent,
-              GTK_DIALOG_MODAL, GTK_MESSAGE_WARNING, GTK_BUTTONS_CLOSE,
-              _("No accounts to import could be found. Empathy currently only "
-                "supports importing accounts from Pidgin."));
-
-          gtk_dialog_run (GTK_DIALOG (message));
-          gtk_widget_destroy (message);
+          import_dialog_show_warning_message (self);
         }
       else
         DEBUG ("No accounts to import; closing dialog silently.");
-
-      return;
+    }
+  else
+    {
+      import_dialog_add_import_widget (self);
     }
 
-  /* We have accounts, let's display the window with them */
-  dialog = g_slice_new0 (EmpathyImportDialog);
-  dialog->accounts = accounts;
-
-  filename = empathy_file_lookup ("empathy-import-dialog.ui", "src");
-  gui = empathy_builder_get_file (filename,
-      "import_dialog", &dialog->window,
-      "treeview", &dialog->treeview,
-      NULL);
-
-  empathy_builder_connect (gui, dialog,
-      "import_dialog", "destroy", import_dialog_destroy_cb,
-      "import_dialog", "response", import_dialog_response_cb,
-      NULL);
-
-  g_object_add_weak_pointer (G_OBJECT (dialog->window), (gpointer) &dialog);
+  if (priv->parent_window)
+    gtk_window_set_transient_for (GTK_WINDOW (self), priv->parent_window);
+}
 
-  g_free (filename);
-  g_object_unref (gui);
+static void
+empathy_import_dialog_init (EmpathyImportDialog *self)
+{
+  EmpathyImportDialogPriv *priv = G_TYPE_INSTANCE_GET_PRIVATE (self,
+      EMPATHY_TYPE_IMPORT_DIALOG, EmpathyImportDialogPriv);
 
-  if (parent)
-    gtk_window_set_transient_for (GTK_WINDOW (dialog->window), parent);
+  self->priv = priv;
 
-  import_dialog_set_up_account_list (dialog);
+  gtk_container_set_border_width (GTK_CONTAINER (self), 5);
+  gtk_window_set_title (GTK_WINDOW (self), _("Import Accounts"));
+  gtk_window_set_modal (GTK_WINDOW (self), TRUE);
+  gtk_dialog_set_has_separator (GTK_DIALOG (self), FALSE);
+}
 
-  gtk_widget_show (dialog->window);
+static void
+empathy_import_dialog_class_init (EmpathyImportDialogClass *klass)
+{
+  GObjectClass *oclass = G_OBJECT_CLASS (klass);
+  GtkDialogClass *gtkclass = GTK_DIALOG_CLASS (klass);
+  GParamSpec *param_spec;
+
+  oclass->constructed = do_constructed;
+  oclass->get_property = do_get_property;
+  oclass->set_property = do_set_property;
+
+  gtkclass->response = impl_signal_response;
+
+  param_spec = g_param_spec_object ("parent-window",
+      "parent-window", "The parent window",
+      GTK_TYPE_WINDOW,
+      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_CONSTRUCT_ONLY);
+  g_object_class_install_property (oclass, PROP_PARENT, param_spec);
+
+  param_spec = g_param_spec_boolean ("show-warning",
+      "show-warning", "Whether a warning should be shown when there are no "
+       "sources for importing accounts.",
+      FALSE,
+      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_CONSTRUCT_ONLY);
+  g_object_class_install_property (oclass, PROP_SHOW_WARNING, param_spec);
+
+  g_type_class_add_private (klass, sizeof (EmpathyImportDialogPriv));
 }
 
+GtkWidget *
+empathy_import_dialog_new (GtkWindow *parent,
+    gboolean warning)
+{
+  return g_object_new (EMPATHY_TYPE_IMPORT_DIALOG, "parent-window",
+      parent, "show-warning", warning, NULL);
+}