aboutsummaryrefslogtreecommitdiffstats
path: root/libempathy
diff options
context:
space:
mode:
authorJonathon Jongsma <jonathon.jongsma@collabora.co.uk>2009-02-14 01:35:42 +0800
committerGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2009-11-19 03:09:34 +0800
commitea9f4b06393425e7496a3494e084520da3de7618 (patch)
tree0e44ddd8d2648f4ee79f7a57ba583ead70519942 /libempathy
parent500093ef89387aead8be8086e33c05fa250446e9 (diff)
downloadgsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar.gz
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar.bz2
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar.lz
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar.xz
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.tar.zst
gsoc2013-empathy-ea9f4b06393425e7496a3494e084520da3de7618.zip
Fixed some of Gillaume's review comments from Bug #571642
The following comments should be fixed in this commit: - tp_group_update_members: add "old" and "new" in comments so we known which contact we are talking about. - Always use TpHandle instead of guint when storing handles in variables. - contact_list_store_member_renamed_cb: would be good to share the common code with contact_list_store_members_changed_cb in a common function One comment about the last one: I split out common code into two new functions: contact_list_store_add_contact_and_connect(), and the matching contact_list_store_remove_contact_and_disconnect(). I wondered whether the signal connection/disconnection should just be added to the _add_contact() and _remove_contact() functions directly, but they do seem to be used in other places without connecting to signals, so i thought it would be safer to simply add some wrapper functions.
Diffstat (limited to 'libempathy')
0 files changed, 0 insertions, 0 deletions