diff options
author | Xavier Claessens <xclaesse@gmail.com> | 2007-05-31 14:34:41 +0800 |
---|---|---|
committer | Xavier Claessens <xclaesse@src.gnome.org> | 2007-05-31 14:34:41 +0800 |
commit | 6fe758a0d83f6872585a177a2e821d4105642308 (patch) | |
tree | 50d79a5ae475063c38e4e62cdaaa3c3817220077 /libempathy/empathy-tp-contact-list.c | |
parent | a0c9dc2f22f510378063be5a8c872bfe8c92bd10 (diff) | |
download | gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar.gz gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar.bz2 gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar.lz gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar.xz gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.tar.zst gsoc2013-empathy-6fe758a0d83f6872585a177a2e821d4105642308.zip |
Fix warning when selecting all accounts.
2007-05-31 Xavier Claessens <xclaesse@gmail.com>
* libempathy-gtk/gossip-account-chooser.c: Fix warning when selecting
all accounts.
* src/empathy-accounts-main.c:
* libempathy-gtk/empathy-status-icon.c:
* libempathy-gtk/gossip-accounts-dialog.h:
* libempathy-gtk/gossip-accounts-dialog.c:
* libempathy-gtk/gossip-preferences.h:
* libempathy-gtk/gossip-preferences.c: Set parent window.
* libempathy-gtk/empathy-main-window.c: Implement favorite chatroom
menu and fix a leak.
* libempathy-gtk/Makefile.am:
* libempathy/Makefile.am:
* libempathy/gossip-chatroom.c:
* libempathy/gossip-chatroom.h:
* libempathy/gossip-chatroom-manager.c:
* libempathy/gossip-chatroom-manager.h:
* libempathy/gossip-chatroom-manager.dtd:
* libempathy-gtk/gossip-chatrooms-window.glade:
* libempathy-gtk/gossip-chatrooms-window.c:
* libempathy-gtk/gossip-chatrooms-window.h: New files to implement
favorite chatrooms and a window to show them.
* libempathy-gtk/gossip-chat.c: Fix tooltip leaked.
* libempathy-gtk/gossip-chat-window.h:
* libempathy-gtk/gossip-chat-window.c: Do not use deprecated
gtk_object_sink(). Implement favorite chatroom features. Find a chat
by comparing the account AND the chat ID.
* src/empathy-chat-main.c:
* libempathy/empathy-tp-chat.h:
* libempathy/empathy-tp-chat.c:
* libempathy/gossip-utils.h:
* libempathy/gossip-utils.c: empathy_tp_chat_get_id() returns the Text
channel's name. The chat ID is unique only for a specified account.
* libempathy/empathy-tp-contact-list.c: Fix some leaks and add a FIXME
comment for a leak not yet fixed.
* TODO: Would be cool to have a glade catalog for libempathy-gtk.
svn path=/trunk/; revision=100
Diffstat (limited to 'libempathy/empathy-tp-contact-list.c')
-rw-r--r-- | libempathy/empathy-tp-contact-list.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/libempathy/empathy-tp-contact-list.c b/libempathy/empathy-tp-contact-list.c index 64bec75ff..6af5ed064 100644 --- a/libempathy/empathy-tp-contact-list.c +++ b/libempathy/empathy-tp-contact-list.c @@ -641,6 +641,7 @@ empathy_tp_contact_list_get_from_handles (EmpathyTpContactList *list, } if (new_handles->len == 0) { + g_array_free (new_handles, TRUE); return contacts; } @@ -1448,6 +1449,7 @@ tp_contact_list_group_members_added_cb (GossipTelepathyGroup *group, contact = GOSSIP_CONTACT (l->data); contact_groups = gossip_contact_get_groups (contact); + /* FIXME: this leaks */ if (!g_list_find_custom (contact_groups, group_name, (GCompareFunc) strcmp)) { @@ -1663,6 +1665,7 @@ tp_contact_list_request_avatar_cb (DBusGProxy *proxy, n_avatar_requests--; tp_contact_list_start_avatar_requests (data->list); + g_object_unref (contact); g_slice_free (TpContactListAvatarRequestData, data); } @@ -1699,6 +1702,7 @@ tp_contact_list_aliases_update_cb (DBusGProxy *proxy, tp_contact_list_block_contact (list, contact); gossip_contact_set_name (contact, alias); tp_contact_list_unblock_contact (list, contact); + g_object_unref (contact); gossip_debug (DEBUG_DOMAIN, "contact %d renamed to %s (update cb)", handle, alias); @@ -1727,6 +1731,7 @@ tp_contact_list_request_aliases_cb (DBusGProxy *proxy, tp_contact_list_block_contact (data->list, contact); gossip_contact_set_name (contact, *name); tp_contact_list_unblock_contact (data->list, contact); + g_object_unref (contact); gossip_debug (DEBUG_DOMAIN, "contact %d renamed to %s (request cb)", data->handles[i], *name); @@ -1781,6 +1786,8 @@ tp_contact_list_parse_presence_foreach (guint handle, tp_contact_list_block_contact (list, contact); gossip_contact_set_presence (contact, presence); tp_contact_list_unblock_contact (list, contact); + + g_object_unref (contact); } static void |