diff options
| author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 22:31:29 +0800 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 22:57:00 +0800 |
| commit | 5bb2c1c62a06e682ab48d530cae5f9614a90a75e (patch) | |
| tree | a847e5c1980d69126b8d7974808cb70923becb33 /libempathy/empathy-tp-chat.c | |
| parent | ba6e07cc5a0bf75118c12fd5ebf05e4453a5dc80 (diff) | |
| download | gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.gz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.bz2 gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.lz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.xz gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.tar.zst gsoc2013-empathy-5bb2c1c62a06e682ab48d530cae5f9614a90a75e.zip | |
Use _unref instead of _free _destroy when possible.unref
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'libempathy/empathy-tp-chat.c')
| -rw-r--r-- | libempathy/empathy-tp-chat.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libempathy/empathy-tp-chat.c b/libempathy/empathy-tp-chat.c index 087090ad4..d34f581ef 100644 --- a/libempathy/empathy-tp-chat.c +++ b/libempathy/empathy-tp-chat.c @@ -762,7 +762,7 @@ tp_chat_finalize (GObject *object) g_queue_free (self->priv->messages_queue); g_queue_free (self->priv->pending_messages_queue); - g_hash_table_destroy (self->priv->messages_being_sent); + g_hash_table_unref (self->priv->messages_being_sent); g_free (self->priv->title); g_free (self->priv->subject); @@ -1441,7 +1441,7 @@ empathy_tp_chat_join (EmpathyTpChat *self) tp_cli_channel_interface_group_call_add_members ((TpChannel *) self, -1, members, "", add_members_cb, NULL, NULL, G_OBJECT (self)); - g_array_free (members, TRUE); + g_array_unref (members); } gboolean |