aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEmilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>2011-06-16 23:30:02 +0800
committerEmilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>2011-06-17 00:24:00 +0800
commit8604502634bae7b65c4d207faa12f80d53463085 (patch)
treed3bb74f78bb89be1f816384fbd3d4f2231fff844
parent0f7b303eca8ee3c3bdd947ea47249a522c523797 (diff)
downloadgsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar.gz
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar.bz2
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar.lz
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar.xz
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.tar.zst
gsoc2013-empathy-8604502634bae7b65c4d207faa12f80d53463085.zip
Hide the password entry for Skype accounts in the assistant
As it wasn't working and it's quite complex to make it work. Empathy will ask for the password in an infobar when the user creates it, which was already happening anyway. Conflicts: libempathy-gtk/empathy-account-widget-skype.c
-rw-r--r--libempathy-gtk/empathy-account-widget-skype.c13
-rw-r--r--libempathy-gtk/empathy-account-widget-skype.ui2
2 files changed, 13 insertions, 2 deletions
diff --git a/libempathy-gtk/empathy-account-widget-skype.c b/libempathy-gtk/empathy-account-widget-skype.c
index c47dab5ed..b6fcbff9e 100644
--- a/libempathy-gtk/empathy-account-widget-skype.c
+++ b/libempathy-gtk/empathy-account-widget-skype.c
@@ -795,7 +795,7 @@ empathy_account_widget_build_skype (EmpathyAccountWidget *self,
static TpBaseClient *auth_observer = NULL;
EmpathyAccountWidgetPriv *priv = GET_PRIV (self);
TpAccount *account = empathy_account_settings_get_account (priv->settings);
- GtkWidget *password_entry, *remember_password;
+ GtkWidget *password_entry, *password_label, *remember_password;
/* additional apply function */
self->ui_details->additional_apply_async =
@@ -810,10 +810,21 @@ empathy_account_widget_build_skype (EmpathyAccountWidget *self,
"table_common_skype_settings_setup", &priv->table_common_settings,
"vbox_skype_settings_setup", &self->ui_details->widget,
"skype-info-vbox", &skype_info,
+ "label_password_setup", &password_label,
"entry_password_setup", &password_entry,
"remember-password-setup", &remember_password,
NULL);
+ if (priv->simple)
+ {
+ /* The assistant doesn't work well with Skype passwords as
+ * the observer goes away before the account goes offline,
+ * so just hide the password and let Empathy ask for it later. */
+ gtk_widget_hide (password_label);
+ gtk_widget_hide (password_entry);
+ gtk_widget_hide (remember_password);
+ }
+
account_widget_build_skype_set_pixmap (self->ui_details->gui,
"plugged-into-skype-logo", "plugged-into-skype.png");
account_widget_build_skype_set_pixmap (self->ui_details->gui,
diff --git a/libempathy-gtk/empathy-account-widget-skype.ui b/libempathy-gtk/empathy-account-widget-skype.ui
index c59eeddd3..dd06d6e3b 100644
--- a/libempathy-gtk/empathy-account-widget-skype.ui
+++ b/libempathy-gtk/empathy-account-widget-skype.ui
@@ -66,7 +66,7 @@ Get one at &lt;a href="http://www.skype.com/go/register"&gt;Skype.com&lt;/a&gt;<
</packing>
</child>
<child>
- <object class="GtkLabel" id="label2">
+ <object class="GtkLabel" id="label_password_setup">
<property name="visible">True</property>
<property name="label" translatable="yes">&lt;a href="https://login.skype.com/account/password-reset-request"&gt;Forgotten your password?&lt;/a&gt;</property>
<property name="use_markup">True</property>