aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilip Withnall <philip.withnall@collabora.co.uk>2010-08-30 17:58:40 +0800
committerPhilip Withnall <philip.withnall@collabora.co.uk>2010-08-30 19:03:06 +0800
commit054086355fe0cb29c40c08da0e9b1f106ff5407a (patch)
tree0b511a9dc37fbb2b2a4985787d70cfc7e647b890
parent788b62fd3efbfefcd2788772693af497d0123dc6 (diff)
downloadgsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar.gz
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar.bz2
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar.lz
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar.xz
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.tar.zst
gsoc2013-empathy-054086355fe0cb29c40c08da0e9b1f106ff5407a.zip
Fix a logic error when expanding groups in EmpathyIndividualView
This prevents use of uninitialised memory in the second part of the expression, and should cause groups to be added to the table of groups to expand/contract more frequently (correctly). Helps: bgo#628106
-rw-r--r--libempathy-gtk/empathy-individual-view.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libempathy-gtk/empathy-individual-view.c b/libempathy-gtk/empathy-individual-view.c
index cffb5c99a..1c8dd21cf 100644
--- a/libempathy-gtk/empathy-individual-view.c
+++ b/libempathy-gtk/empathy-individual-view.c
@@ -1512,7 +1512,7 @@ individual_view_row_has_child_toggled_cb (GtkTreeModel *model,
* a hash table, and expand or contract them as appropriate all at once in
* an idle handler which iterates over all the group rows. */
if (g_hash_table_lookup_extended (priv->expand_groups, name, NULL,
- &will_expand) == FALSE &&
+ &will_expand) == FALSE ||
GPOINTER_TO_INT (will_expand) != should_expand)
{
g_hash_table_insert (priv->expand_groups, g_strdup (name),