diff options
| author | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2009-12-10 00:15:09 +0800 |
|---|---|---|
| committer | Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> | 2009-12-10 00:15:09 +0800 |
| commit | db0b0f0ad369618f8204bbdf918aa574ccb25c8c (patch) | |
| tree | cc372f3745ff31fb49a33413756449b5e190a974 | |
| parent | 7b4335bd88919c0d377ee0f67f1158d4f6b7dc2d (diff) | |
| download | gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar.gz gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar.bz2 gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar.lz gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar.xz gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.tar.zst gsoc2013-empathy-db0b0f0ad369618f8204bbdf918aa574ccb25c8c.zip | |
tp_contact_list_remove: add FIXME about potential race
| -rw-r--r-- | libempathy/empathy-tp-contact-list.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/libempathy/empathy-tp-contact-list.c b/libempathy/empathy-tp-contact-list.c index 9ef71b4f9..9b67ec7e2 100644 --- a/libempathy/empathy-tp-contact-list.c +++ b/libempathy/empathy-tp-contact-list.c @@ -1060,6 +1060,8 @@ tp_contact_list_remove (EmpathyContactList *list, handle = empathy_contact_get_handle (contact); + /* FIXME: this is racy if tp_contact_list_remove is called before the + * 'stored' list has been retrieved. */ if (priv->stored != NULL) { tp_cli_channel_interface_group_call_remove_members (priv->stored, -1, &handles, message, NULL, NULL, NULL, NULL); |