aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2009-10-29 21:18:51 +0800
committerGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>2009-10-29 21:31:36 +0800
commit120fc9120a2de2d0c3064d5aef10a62fe6993d35 (patch)
treee81f0bbac91dd35408abe276b33cc4aeba21be77
parent90aeac3daa6f7e4939d79609750ab46b64532f00 (diff)
downloadgsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar.gz
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar.bz2
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar.lz
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar.xz
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.tar.zst
gsoc2013-empathy-120fc9120a2de2d0c3064d5aef10a62fe6993d35.zip
empathy-accounts-dialog: do_constructor: don't ref the dialog if it already exists (#600023)
This breaks the concept of a constructor but the caller isn't supposed to unref it itself anyway (it's unreffed in accounts_dialog_destroy_cb).
-rw-r--r--src/empathy-accounts-dialog.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/empathy-accounts-dialog.c b/src/empathy-accounts-dialog.c
index a22704fd4..339b6c5a7 100644
--- a/src/empathy-accounts-dialog.c
+++ b/src/empathy-accounts-dialog.c
@@ -1747,7 +1747,9 @@ do_constructor (GType type,
if (dialog_singleton)
{
retval = G_OBJECT (dialog_singleton);
- g_object_ref (retval);
+ /* We don't ref the object as the caller is not suppose to unref it.
+ * The dialog is unreffed in accounts_dialog_destroy_cb when the window
+ * has been destroyed. */
}
else
{