From ecd7199c4367bbffd5000ab6ee9bad3ef88de5d2 Mon Sep 17 00:00:00 2001 From: Gustav Simonsson Date: Tue, 24 Nov 2015 11:30:35 +0100 Subject: common/versions, cmd/utils: add geth version contract --- node/node.go | 1 + 1 file changed, 1 insertion(+) (limited to 'node') diff --git a/node/node.go b/node/node.go index 18c3f91d8..0864253f4 100644 --- a/node/node.go +++ b/node/node.go @@ -530,6 +530,7 @@ func (n *Node) Server() *p2p.Server { } // Service retrieves a currently running service registered of a specific type. +// NOTE: must be called with double pointer to service func (n *Node) Service(service interface{}) error { n.lock.RLock() defer n.lock.RUnlock() -- cgit v1.2.3 From 586eddfd09558bfd71f23c2e50c270d2ca665d49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= Date: Thu, 28 Apr 2016 12:00:11 +0300 Subject: release, all: integrate the release service into geth --- node/node.go | 3 +-- node/service.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'node') diff --git a/node/node.go b/node/node.go index 0864253f4..06a1b7aed 100644 --- a/node/node.go +++ b/node/node.go @@ -311,7 +311,7 @@ func (n *Node) startIPC(apis []rpc.API) error { glog.V(logger.Error).Infof("IPC accept failed: %v", err) continue } - go handler.ServeCodec(rpc.NewJSONCodec(conn), rpc.OptionMethodInvocation | rpc.OptionSubscriptions) + go handler.ServeCodec(rpc.NewJSONCodec(conn), rpc.OptionMethodInvocation|rpc.OptionSubscriptions) } }() // All listeners booted successfully @@ -530,7 +530,6 @@ func (n *Node) Server() *p2p.Server { } // Service retrieves a currently running service registered of a specific type. -// NOTE: must be called with double pointer to service func (n *Node) Service(service interface{}) error { n.lock.RLock() defer n.lock.RUnlock() diff --git a/node/service.go b/node/service.go index 77b2ddc92..4d9a6e42c 100644 --- a/node/service.go +++ b/node/service.go @@ -68,7 +68,7 @@ type ServiceConstructor func(ctx *ServiceContext) (Service, error) // - Restart logic is not required as the node will create a fresh instance // every time a service is started. type Service interface { - // Protocol retrieves the P2P protocols the service wishes to start. + // Protocols retrieves the P2P protocols the service wishes to start. Protocols() []p2p.Protocol // APIs retrieves the list of RPC descriptors the service provides -- cgit v1.2.3