From 26aea736736dc70257b1c11676f626ab775e9339 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jano=C5=A1=20Gulja=C5=A1?= Date: Thu, 7 Feb 2019 11:40:36 +0100 Subject: cmd, node, p2p/simulations: fix node account manager leak (#19004) * node: close AccountsManager in new Close method * p2p/simulations, p2p/simulations/adapters: handle node close on shutdown * node: move node ephemeralKeystore cleanup to stop method * node: call Stop in Node.Close method * cmd/geth: close node.Node created with makeFullNode in cli commands * node: close Node instances in tests * cmd/geth, node: minor code style fixes * cmd, console, miner, mobile: proper node Close() termination --- miner/stress_clique.go | 2 +- miner/stress_ethash.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'miner') diff --git a/miner/stress_clique.go b/miner/stress_clique.go index 7e19975ae..8a355a4dc 100644 --- a/miner/stress_clique.go +++ b/miner/stress_clique.go @@ -69,7 +69,7 @@ func main() { if err != nil { panic(err) } - defer node.Stop() + defer node.Close() for node.Server().NodeInfo().Ports.Listener == 0 { time.Sleep(250 * time.Millisecond) diff --git a/miner/stress_ethash.go b/miner/stress_ethash.go index 044ca9a21..040af9fba 100644 --- a/miner/stress_ethash.go +++ b/miner/stress_ethash.go @@ -69,7 +69,7 @@ func main() { if err != nil { panic(err) } - defer node.Stop() + defer node.Close() for node.Server().NodeInfo().Ports.Listener == 0 { time.Sleep(250 * time.Millisecond) -- cgit v1.2.3