aboutsummaryrefslogtreecommitdiffstats
path: root/trie
diff options
context:
space:
mode:
authorPéter Szilágyi <peterke@gmail.com>2019-04-05 18:09:28 +0800
committerPéter Szilágyi <peterke@gmail.com>2019-04-08 17:00:42 +0800
commit80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c (patch)
treeda13b1a8f5b9539dc42e6c36075ffcd51f8e969a /trie
parentfca5f9fd6fc8a45166ff21cbb41df9e2005dc314 (diff)
downloadgo-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar.gz
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar.bz2
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar.lz
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar.xz
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.tar.zst
go-tangerine-80a2a35bc3aaf208b5f91a1fb1d803975d4bb01c.zip
trie: there's no point in retrieving the metaroot
Diffstat (limited to 'trie')
-rw-r--r--trie/database.go5
-rw-r--r--trie/database_test.go33
2 files changed, 38 insertions, 0 deletions
diff --git a/trie/database.go b/trie/database.go
index 739a98add..c39af85cf 100644
--- a/trie/database.go
+++ b/trie/database.go
@@ -17,6 +17,7 @@
package trie
import (
+ "errors"
"fmt"
"io"
"sync"
@@ -391,6 +392,10 @@ func (db *Database) node(hash common.Hash, cachegen uint16) node {
// Node retrieves an encoded cached trie node from memory. If it cannot be found
// cached, the method queries the persistent database for the content.
func (db *Database) Node(hash common.Hash) ([]byte, error) {
+ // It doens't make sense to retrieve the metaroot
+ if hash == (common.Hash{}) {
+ return nil, errors.New("not found")
+ }
// Retrieve the node from the clean cache if available
if db.cleans != nil {
if enc, err := db.cleans.Get(string(hash[:])); err == nil && enc != nil {
diff --git a/trie/database_test.go b/trie/database_test.go
new file mode 100644
index 000000000..65b65678b
--- /dev/null
+++ b/trie/database_test.go
@@ -0,0 +1,33 @@
+// Copyright 2019 The go-ethereum Authors
+// This file is part of the go-ethereum library.
+//
+// The go-ethereum library is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// The go-ethereum library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
+
+package trie
+
+import (
+ "testing"
+
+ "github.com/ethereum/go-ethereum/common"
+ "github.com/ethereum/go-ethereum/ethdb"
+)
+
+// Tests that the trie database returns a missing trie node error if attempting
+// to retrieve the meta root.
+func TestDatabaseMetarootFetch(t *testing.T) {
+ db := NewDatabase(ethdb.NewMemDatabase())
+ if _, err := db.Node(common.Hash{}); err == nil {
+ t.Fatalf("metaroot retrieval succeeded")
+ }
+}