aboutsummaryrefslogtreecommitdiffstats
path: root/light
diff options
context:
space:
mode:
authorFelix Lange <fjl@users.noreply.github.com>2017-02-28 22:09:11 +0800
committerJeffrey Wilcke <jeffrey@ethereum.org>2017-02-28 22:09:11 +0800
commit5f7826270c9e87509fd7731ec64953a5e4761de0 (patch)
tree0d3187b115a0e10afcce1bb38ed8ba977d8bf44f /light
parentd4f60d362b8fcf82db1accf89c146a2a71375841 (diff)
downloadgo-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.gz
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.bz2
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.lz
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.xz
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.tar.zst
go-tangerine-5f7826270c9e87509fd7731ec64953a5e4761de0.zip
all: unify big.Int zero checks, use common/math in more places (#3716)
* common/math: optimize PaddedBigBytes, use it more name old time/op new time/op delta PaddedBigBytes-8 71.1ns ± 5% 46.1ns ± 1% -35.15% (p=0.000 n=20+19) name old alloc/op new alloc/op delta PaddedBigBytes-8 48.0B ± 0% 32.0B ± 0% -33.33% (p=0.000 n=20+20) * all: unify big.Int zero checks Various checks were in use. This commit replaces them all with Int.Sign, which is cheaper and less code. eg templates: func before(x *big.Int) bool { return x.BitLen() == 0 } func after(x *big.Int) bool { return x.Sign() == 0 } func before(x *big.Int) bool { return x.BitLen() > 0 } func after(x *big.Int) bool { return x.Sign() != 0 } func before(x *big.Int) int { return x.Cmp(common.Big0) } func after(x *big.Int) int { return x.Sign() } * common/math, crypto/secp256k1: make ReadBits public in package math
Diffstat (limited to 'light')
-rw-r--r--light/state_object.go2
-rw-r--r--light/txpool.go2
2 files changed, 2 insertions, 2 deletions
diff --git a/light/state_object.go b/light/state_object.go
index 03d4868cd..d023270d5 100644
--- a/light/state_object.go
+++ b/light/state_object.go
@@ -202,7 +202,7 @@ func (self *StateObject) Copy() *StateObject {
// empty returns whether the account is considered empty.
func (self *StateObject) empty() bool {
- return self.nonce == 0 && self.balance.BitLen() == 0 && bytes.Equal(self.codeHash, emptyCodeHash)
+ return self.nonce == 0 && self.balance.Sign() == 0 && bytes.Equal(self.codeHash, emptyCodeHash)
}
// Balance returns the account balance
diff --git a/light/txpool.go b/light/txpool.go
index 365f02d25..ecd6cfa26 100644
--- a/light/txpool.go
+++ b/light/txpool.go
@@ -365,7 +365,7 @@ func (pool *TxPool) validateTx(ctx context.Context, tx *types.Transaction) error
// Transactions can't be negative. This may never happen
// using RLP decoded transactions but may occur if you create
// a transaction using the RPC for example.
- if tx.Value().Cmp(common.Big0) < 0 {
+ if tx.Value().Sign() < 0 {
return core.ErrNegativeValue
}