core, dex: polish sync (#75)

- Broadcasting blocks at chain head event is not correct when the full
  node is not running in block proposer mode. Introduce NewFinalizedBlockEvent,
  this event is post by the full node which runs in block proposer mode when a
  block is witnessed and resulting in some blocks are considered finalized.

- Non block proposer node will still broadcast blocks
  at the following moment (same as ethereum):
  1. a sync with a peer is terminated successfully
  2. a block passes the fetcher's header check during inserting blocks
  3. a block is successfully inserted by fetcher

- Don't trigger a sync when we are not behind other peers more than
  acceptable distance. Fetcher is able to cover this.

1 files changed, 23 insertions, 0 deletions

diff --git a/dex/app.go b/dex/app.go
index 8723420c5..92e1a6aaa 100644
--- a/dex/app.go
+++ b/dex/app.go
@@ -31,6 +31,7 @@ import (
 	"github.com/dexon-foundation/dexon/core"
 	"github.com/dexon-foundation/dexon/core/types"
 	"github.com/dexon-foundation/dexon/ethdb"
+	"github.com/dexon-foundation/dexon/event"
 	"github.com/dexon-foundation/dexon/log"
 	"github.com/dexon-foundation/dexon/rlp"
 )
@@ -47,6 +48,9 @@ type DexconApp struct {
 	chainDB    ethdb.Database
 	config     *Config
 
+	finalizedBlockFeed event.Feed
+	scope              event.SubscriptionScope
+
 	chainLocks      sync.Map
 	chainLatestRoot sync.Map
 }
@@ -490,6 +494,7 @@ func (d *DexconApp) BlockDelivered(
 		Randomness: result.Randomness,
 	}, txs, nil, nil)
 
+	h := d.blockchain.CurrentBlock().NumberU64() + 1
 	root, err := d.blockchain.ProcessPendingBlock(newBlock, &block.Witness)
 	if err != nil {
 		log.Error("Failed to process pending block", "error", err)
@@ -498,6 +503,15 @@ func (d *DexconApp) BlockDelivered(
 	d.chainLatestRoot.Store(block.Position.ChainID, root)
 
 	d.blockchain.RemoveConfirmedBlock(chainID, blockHash)
+
+	// New blocks are finalized, notify other components.
+	newHeight := d.blockchain.CurrentBlock().NumberU64()
+	for h <= newHeight {
+		b := d.blockchain.GetBlockByNumber(h)
+		go d.finalizedBlockFeed.Send(core.NewFinalizedBlockEvent{b})
+		log.Debug("Send new finalized block event", "number", h)
+		h++
+	}
 }
 
 // BlockConfirmed is called when a block is confirmed and added to lattice.
@@ -509,3 +523,12 @@ func (d *DexconApp) BlockConfirmed(block coreTypes.Block) {
 		panic(err)
 	}
 }
+
+func (d *DexconApp) SubscribeNewFinalizedBlockEvent(
+	ch chan<- core.NewFinalizedBlockEvent) event.Subscription {
+	return d.scope.Track(d.finalizedBlockFeed.Subscribe(ch))
+}
+
+func (d *DexconApp) Stop() {
+	d.scope.Close()
+}