diff options
author | Felix Lange <fjl@twurst.com> | 2017-03-02 21:03:33 +0800 |
---|---|---|
committer | Felix Lange <fjl@twurst.com> | 2017-03-23 22:58:43 +0800 |
commit | 37dd9086ec491900311fc39837f4a62ef5fd3a4a (patch) | |
tree | 0d2c7bb99ad1cd2ffa6d014e44288452a537aba5 /core/types | |
parent | 67c47459f283842bbf0063d9a1dc078251d6f433 (diff) | |
download | go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar.gz go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar.bz2 go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar.lz go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar.xz go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.tar.zst go-tangerine-37dd9086ec491900311fc39837f4a62ef5fd3a4a.zip |
core: refactor genesis handling
This commit solves several issues concerning the genesis block:
* Genesis/ChainConfig loading was handled by cmd/geth code. This left
library users in the cold. They could specify a JSON-encoded
string and overwrite the config, but didn't get any of the additional
checks performed by geth.
* Decoding and writing of genesis JSON was conflated in
WriteGenesisBlock. This made it a lot harder to embed the genesis
block into the forthcoming config file loader. This commit changes
things so there is a single Genesis type that represents genesis
blocks. All uses of Write*Genesis* are changed to use the new type
instead.
* If the chain config supplied by the user was incompatible with the
current chain (i.e. the chain had already advanced beyond a scheduled
fork), it got overwritten. This is not an issue in practice because
previous forks have always had the highest total difficulty. It might
matter in the future though. The new code reverts the local chain to
the point of the fork when upgrading configuration.
The change to genesis block data removes compression library
dependencies from package core.
Diffstat (limited to 'core/types')
-rw-r--r-- | core/types/transaction.go | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/core/types/transaction.go b/core/types/transaction.go index a02f9ed00..86948b5b7 100644 --- a/core/types/transaction.go +++ b/core/types/transaction.go @@ -27,7 +27,6 @@ import ( "github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/common/hexutil" "github.com/ethereum/go-ethereum/crypto" - "github.com/ethereum/go-ethereum/params" "github.com/ethereum/go-ethereum/rlp" ) @@ -119,19 +118,6 @@ func newTransaction(nonce uint64, to *common.Address, amount, gasLimit, gasPrice return &Transaction{data: d} } -func pickSigner(rules params.Rules) Signer { - var signer Signer - switch { - case rules.IsEIP155: - signer = NewEIP155Signer(rules.ChainId) - case rules.IsHomestead: - signer = HomesteadSigner{} - default: - signer = FrontierSigner{} - } - return signer -} - // ChainId returns which chain id this transaction was signed for (if at all) func (tx *Transaction) ChainId() *big.Int { return deriveChainId(tx.data.V) |