diff options
| author | Felix Lange <fjl@twurst.com> | 2017-01-06 23:44:20 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@twurst.com> | 2017-01-07 01:18:07 +0800 |
| commit | f2da6581ba827a2aab091f764ace8017b26450d8 (patch) | |
| tree | 3bf7ed2ec48812064c5eb6191c9848ad7985561b /cmd | |
| parent | 35a7dcb162546f7f31cb6492f716cb93159218d7 (diff) | |
| download | go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar.gz go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar.bz2 go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar.lz go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar.xz go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.tar.zst go-tangerine-f2da6581ba827a2aab091f764ace8017b26450d8.zip | |
all: fix issues reported by honnef.co/go/simple/cmd/gosimple
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/ethtest/main.go | 7 | ||||
| -rw-r--r-- | cmd/geth/accountcmd_test.go | 8 | ||||
| -rw-r--r-- | cmd/utils/cmd.go | 2 |
3 files changed, 6 insertions, 11 deletions
diff --git a/cmd/ethtest/main.go b/cmd/ethtest/main.go index 7ce663dc0..14b839579 100644 --- a/cmd/ethtest/main.go +++ b/cmd/ethtest/main.go @@ -88,12 +88,7 @@ func runTestWithReader(test string, r io.Reader) error { default: err = fmt.Errorf("Invalid test type specified: %v", test) } - - if err != nil { - return err - } - - return nil + return err } func getFiles(path string) ([]string, error) { diff --git a/cmd/geth/accountcmd_test.go b/cmd/geth/accountcmd_test.go index b6abde6d8..113df983e 100644 --- a/cmd/geth/accountcmd_test.go +++ b/cmd/geth/accountcmd_test.go @@ -148,7 +148,7 @@ Passphrase: {{.InputLine "foobar"}} "Unlocked account f466859ead1932d743d622cb74fc058882e8648a", } for _, m := range wantMessages { - if strings.Index(geth.stderrText(), m) == -1 { + if !strings.Contains(geth.stderrText(), m) { t.Errorf("stderr text does not contain %q", m) } } @@ -193,7 +193,7 @@ Passphrase: {{.InputLine "foobar"}} "Unlocked account 289d485d9771714cce91d3393d764e1311907acc", } for _, m := range wantMessages { - if strings.Index(geth.stderrText(), m) == -1 { + if !strings.Contains(geth.stderrText(), m) { t.Errorf("stderr text does not contain %q", m) } } @@ -212,7 +212,7 @@ func TestUnlockFlagPasswordFile(t *testing.T) { "Unlocked account 289d485d9771714cce91d3393d764e1311907acc", } for _, m := range wantMessages { - if strings.Index(geth.stderrText(), m) == -1 { + if !strings.Contains(geth.stderrText(), m) { t.Errorf("stderr text does not contain %q", m) } } @@ -260,7 +260,7 @@ In order to avoid this warning, you need to remove the following duplicate key f "Unlocked account f466859ead1932d743d622cb74fc058882e8648a", } for _, m := range wantMessages { - if strings.Index(geth.stderrText(), m) == -1 { + if !strings.Contains(geth.stderrText(), m) { t.Errorf("stderr text does not contain %q", m) } } diff --git a/cmd/utils/cmd.go b/cmd/utils/cmd.go index a56507e4d..287efc9c8 100644 --- a/cmd/utils/cmd.go +++ b/cmd/utils/cmd.go @@ -95,7 +95,7 @@ func StartNode(stack *node.Node) { func FormatTransactionData(data string) []byte { d := common.StringToByteFunc(data, func(s string) (ret []byte) { - slice := regexp.MustCompile("\\n|\\s").Split(s, 1000000000) + slice := regexp.MustCompile(`\n|\s`).Split(s, 1000000000) for _, dataItem := range slice { d := common.FormatData(dataItem) ret = append(ret, d...) |