diff options
| author | Péter Szilágyi <peterke@gmail.com> | 2019-03-25 16:01:18 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-25 16:01:18 +0800 |
| commit | 86989e3fcd93ac319dfbced226b3902520a5a4a9 (patch) | |
| tree | 12cd70f812c25be27c9fd391190e3b09e8335322 /cmd | |
| parent | e852505acedf6d3728330852b2d816ebf12a2cfb (diff) | |
| download | go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar.gz go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar.bz2 go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar.lz go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar.xz go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.tar.zst go-tangerine-86989e3fcd93ac319dfbced226b3902520a5a4a9.zip | |
core: split out detailed trie access metrics from insertion time (#19316)
* core: split out detailed trie access metrics from insertion time
* cmd, core, metrics: support expensive optional metrics
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/geth/main.go | 3 | ||||
| -rw-r--r-- | cmd/geth/usage.go | 12 | ||||
| -rw-r--r-- | cmd/utils/flags.go | 8 |
3 files changed, 10 insertions, 13 deletions
diff --git a/cmd/geth/main.go b/cmd/geth/main.go index f966905a9..83847fc53 100644 --- a/cmd/geth/main.go +++ b/cmd/geth/main.go @@ -137,7 +137,6 @@ var ( utils.RPCCORSDomainFlag, utils.RPCVirtualHostsFlag, utils.EthStatsURLFlag, - utils.MetricsEnabledFlag, utils.FakePoWFlag, utils.NoCompactionFlag, utils.GpoBlocksFlag, @@ -174,6 +173,8 @@ var ( } metricsFlags = []cli.Flag{ + utils.MetricsEnabledFlag, + utils.MetricsEnabledExpensiveFlag, utils.MetricsEnableInfluxDBFlag, utils.MetricsInfluxDBEndpointFlag, utils.MetricsInfluxDBDatabaseFlag, diff --git a/cmd/geth/usage.go b/cmd/geth/usage.go index a4787fff2..8658a3fdc 100644 --- a/cmd/geth/usage.go +++ b/cmd/geth/usage.go @@ -225,16 +225,8 @@ var AppHelpFlagGroups = []flagGroup{ }, debug.Flags...), }, { - Name: "METRICS AND STATS", - Flags: []cli.Flag{ - utils.MetricsEnabledFlag, - utils.MetricsEnableInfluxDBFlag, - utils.MetricsInfluxDBEndpointFlag, - utils.MetricsInfluxDBDatabaseFlag, - utils.MetricsInfluxDBUsernameFlag, - utils.MetricsInfluxDBPasswordFlag, - utils.MetricsInfluxDBTagsFlag, - }, + Name: "METRICS AND STATS", + Flags: metricsFlags, }, { Name: "WHISPER (EXPERIMENTAL)", diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go index e00f92fa7..bf433242e 100644 --- a/cmd/utils/flags.go +++ b/cmd/utils/flags.go @@ -226,7 +226,7 @@ var ( } // Dashboard settings DashboardEnabledFlag = cli.BoolFlag{ - Name: metrics.DashboardEnabledFlag, + Name: "dashboard", Usage: "Enable the dashboard", } DashboardAddrFlag = cli.StringFlag{ @@ -644,9 +644,13 @@ var ( // Metrics flags MetricsEnabledFlag = cli.BoolFlag{ - Name: metrics.MetricsEnabledFlag, + Name: "metrics", Usage: "Enable metrics collection and reporting", } + MetricsEnabledExpensiveFlag = cli.BoolFlag{ + Name: "metrics.expensive", + Usage: "Enable expensive metrics collection and reporting", + } MetricsEnableInfluxDBFlag = cli.BoolFlag{ Name: "metrics.influxdb", Usage: "Enable metrics export/push to an external InfluxDB database", |