diff options
| author | Janoš Guljaš <janos@users.noreply.github.com> | 2019-01-16 19:56:34 +0800 |
|---|---|---|
| committer | Viktor Trón <viktor.tron@gmail.com> | 2019-01-16 19:56:34 +0800 |
| commit | 96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77 (patch) | |
| tree | b5fca57cd16030b32533b747445b6333e507627a | |
| parent | d37f987639c7a3a8af3a81989d5152a3fca11c97 (diff) | |
| download | go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar.gz go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar.bz2 go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar.lz go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar.xz go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.tar.zst go-tangerine-96c7c18b184ae894f1c6bd5fbfc45fbcfa9ace77.zip | |
swarm/network: fix data race in TestNetworkID test (#18460)
| -rw-r--r-- | swarm/network/networkid_test.go | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/swarm/network/networkid_test.go b/swarm/network/networkid_test.go index 99890118f..8e68e5b52 100644 --- a/swarm/network/networkid_test.go +++ b/swarm/network/networkid_test.go @@ -76,13 +76,12 @@ func TestNetworkID(t *testing.T) { if err != nil { t.Fatalf("Error setting up network: %v", err) } - defer func() { - //shutdown the snapshot network - log.Trace("Shutting down network") - net.Shutdown() - }() //let's sleep to ensure all nodes are connected time.Sleep(1 * time.Second) + // shutdown the the network to avoid race conditions + // on accessing kademlias global map while network nodes + // are accepting messages + net.Shutdown() //for each group sharing the same network ID... for _, netIDGroup := range nodeMap { log.Trace("netIDGroup size", "size", len(netIDGroup)) |