aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoc Yu <rociiu0112@gmail.com>2018-07-18 16:32:49 +0800
committerPéter Szilágyi <peterke@gmail.com>2018-07-18 16:32:49 +0800
commit323428865f65be0c637dfc35fc9728f3108c040a (patch)
tree92e7a13f86cb9d5f743d2f0a19e8bc85a75c6273
parent65c91ad5e7f7c8aadbdc114ae443dc4c0e38489d (diff)
downloadgo-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar.gz
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar.bz2
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar.lz
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar.xz
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.tar.zst
go-tangerine-323428865f65be0c637dfc35fc9728f3108c040a.zip
accounts: add unit tests for URL (#17182)
-rw-r--r--accounts/url.go6
-rw-r--r--accounts/url_test.go96
2 files changed, 99 insertions, 3 deletions
diff --git a/accounts/url.go b/accounts/url.go
index 21df668ef..a5add1021 100644
--- a/accounts/url.go
+++ b/accounts/url.go
@@ -76,12 +76,12 @@ func (u URL) MarshalJSON() ([]byte, error) {
// UnmarshalJSON parses url.
func (u *URL) UnmarshalJSON(input []byte) error {
- var textUrl string
- err := json.Unmarshal(input, &textUrl)
+ var textURL string
+ err := json.Unmarshal(input, &textURL)
if err != nil {
return err
}
- url, err := parseURL(textUrl)
+ url, err := parseURL(textURL)
if err != nil {
return err
}
diff --git a/accounts/url_test.go b/accounts/url_test.go
new file mode 100644
index 000000000..802772871
--- /dev/null
+++ b/accounts/url_test.go
@@ -0,0 +1,96 @@
+// Copyright 2017 The go-ethereum Authors
+// This file is part of the go-ethereum library.
+//
+// The go-ethereum library is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Lesser General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// The go-ethereum library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Lesser General Public License for more details.
+//
+// You should have received a copy of the GNU Lesser General Public License
+// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
+
+package accounts
+
+import (
+ "testing"
+)
+
+func TestURLParsing(t *testing.T) {
+ url, err := parseURL("https://ethereum.org")
+ if err != nil {
+ t.Errorf("unexpected error: %v", err)
+ }
+ if url.Scheme != "https" {
+ t.Errorf("expected: %v, got: %v", "https", url.Scheme)
+ }
+ if url.Path != "ethereum.org" {
+ t.Errorf("expected: %v, got: %v", "ethereum.org", url.Path)
+ }
+
+ _, err = parseURL("ethereum.org")
+ if err == nil {
+ t.Error("expected err, got: nil")
+ }
+}
+
+func TestURLString(t *testing.T) {
+ url := URL{Scheme: "https", Path: "ethereum.org"}
+ if url.String() != "https://ethereum.org" {
+ t.Errorf("expected: %v, got: %v", "https://ethereum.org", url.String())
+ }
+
+ url = URL{Scheme: "", Path: "ethereum.org"}
+ if url.String() != "ethereum.org" {
+ t.Errorf("expected: %v, got: %v", "ethereum.org", url.String())
+ }
+}
+
+func TestURLMarshalJSON(t *testing.T) {
+ url := URL{Scheme: "https", Path: "ethereum.org"}
+ json, err := url.MarshalJSON()
+ if err != nil {
+ t.Errorf("unexpcted error: %v", err)
+ }
+ if string(json) != "\"https://ethereum.org\"" {
+ t.Errorf("expected: %v, got: %v", "\"https://ethereum.org\"", string(json))
+ }
+}
+
+func TestURLUnmarshalJSON(t *testing.T) {
+ url := &URL{}
+ err := url.UnmarshalJSON([]byte("\"https://ethereum.org\""))
+ if err != nil {
+ t.Errorf("unexpcted error: %v", err)
+ }
+ if url.Scheme != "https" {
+ t.Errorf("expected: %v, got: %v", "https", url.Scheme)
+ }
+ if url.Path != "ethereum.org" {
+ t.Errorf("expected: %v, got: %v", "https", url.Path)
+ }
+}
+
+func TestURLComparison(t *testing.T) {
+ tests := []struct {
+ urlA URL
+ urlB URL
+ expect int
+ }{
+ {URL{"https", "ethereum.org"}, URL{"https", "ethereum.org"}, 0},
+ {URL{"http", "ethereum.org"}, URL{"https", "ethereum.org"}, -1},
+ {URL{"https", "ethereum.org/a"}, URL{"https", "ethereum.org"}, 1},
+ {URL{"https", "abc.org"}, URL{"https", "ethereum.org"}, -1},
+ }
+
+ for i, tt := range tests {
+ result := tt.urlA.Cmp(tt.urlB)
+ if result != tt.expect {
+ t.Errorf("test %d: cmp mismatch: expected: %d, got: %d", i, tt.expect, result)
+ }
+ }
+}