From a9959805e572ec438bf31ea97cb4a52e0e9715e9 Mon Sep 17 00:00:00 2001 From: obscuren Date: Thu, 9 Apr 2015 00:44:20 +0200 Subject: Removed from as a requirement and changed Removed the from as a requiremet from the RPC eth_call. Xeth#Call now also default values to: 1. Supplied account 2. First account if any 3. No managed account => 000000..00 --- rpc/args.go | 5 ----- rpc/args_test.go | 15 --------------- 2 files changed, 20 deletions(-) (limited to 'rpc') diff --git a/rpc/args.go b/rpc/args.go index 5b1c271cc..4bc36f5d9 100644 --- a/rpc/args.go +++ b/rpc/args.go @@ -279,11 +279,6 @@ func (args *CallArgs) UnmarshalJSON(b []byte) (err error) { return NewDecodeParamError(err.Error()) } - if len(ext.From) == 0 { - return NewValidationError("from", "is required") - } - args.From = ext.From - if len(ext.To) == 0 { return NewValidationError("to", "is required") } diff --git a/rpc/args_test.go b/rpc/args_test.go index 050f8e472..cfe6c0c45 100644 --- a/rpc/args_test.go +++ b/rpc/args_test.go @@ -671,10 +671,6 @@ func TestCallArgs(t *testing.T) { t.Error(err) } - if expected.From != args.From { - t.Errorf("From shoud be %#v but is %#v", expected.From, args.From) - } - if expected.To != args.To { t.Errorf("To shoud be %#v but is %#v", expected.To, args.To) } @@ -895,19 +891,8 @@ func TestCallArgsNotStrings(t *testing.T) { } } -func TestCallArgsFromEmpty(t *testing.T) { - input := `[{"to": "0xb60e8dd61c5d32be8058bb8eb970870f07233155"}]` - - args := new(CallArgs) - str := ExpectValidationError(json.Unmarshal([]byte(input), &args)) - if len(str) > 0 { - t.Error(str) - } -} - func TestCallArgsToEmpty(t *testing.T) { input := `[{"from": "0xb60e8dd61c5d32be8058bb8eb970870f07233155"}]` - args := new(CallArgs) str := ExpectValidationError(json.Unmarshal([]byte(input), &args)) if len(str) > 0 { -- cgit v1.2.3