From bfdc0fa3622d7c3b421d2f5a6dda5746be41bfde Mon Sep 17 00:00:00 2001 From: Eugene Valeyev Date: Mon, 6 Nov 2017 18:46:43 +0300 Subject: mobile: fix FilterLogs (#15418) All logs in the FilterLog return value would be the same object because the for loop captured the pointer to the iteration variable. --- mobile/ethclient.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mobile') diff --git a/mobile/ethclient.go b/mobile/ethclient.go index 7f31a8998..758863b6d 100644 --- a/mobile/ethclient.go +++ b/mobile/ethclient.go @@ -198,8 +198,8 @@ func (ec *EthereumClient) FilterLogs(ctx *Context, query *FilterQuery) (logs *Lo } // Temp hack due to vm.Logs being []*vm.Log res := make([]*types.Log, len(rawLogs)) - for i, log := range rawLogs { - res[i] = &log + for i := range rawLogs { + res[i] = &rawLogs[i] } return &Logs{res}, nil } -- cgit v1.2.3 From 86f6568f6618945b19057553ec32690d723da982 Mon Sep 17 00:00:00 2001 From: ferhat elmas Date: Fri, 10 Nov 2017 18:06:45 +0100 Subject: build: enable unconvert linter (#15456) * build: enable unconvert linter - fixes #15453 - update code base for failing cases * cmd/puppeth: replace syscall.Stdin with os.Stdin.Fd() for unconvert linter --- mobile/interface.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mobile') diff --git a/mobile/interface.go b/mobile/interface.go index 72958e66a..ac0c26088 100644 --- a/mobile/interface.go +++ b/mobile/interface.go @@ -59,7 +59,7 @@ func (i *Interface) SetInt64(n int64) { i.object = &n } func (i *Interface) SetUint8(bigint *BigInt) { n := uint8(bigint.bigint.Uint64()); i.object = &n } func (i *Interface) SetUint16(bigint *BigInt) { n := uint16(bigint.bigint.Uint64()); i.object = &n } func (i *Interface) SetUint32(bigint *BigInt) { n := uint32(bigint.bigint.Uint64()); i.object = &n } -func (i *Interface) SetUint64(bigint *BigInt) { n := uint64(bigint.bigint.Uint64()); i.object = &n } +func (i *Interface) SetUint64(bigint *BigInt) { n := bigint.bigint.Uint64(); i.object = &n } func (i *Interface) SetBigInt(bigint *BigInt) { i.object = &bigint.bigint } func (i *Interface) SetBigInts(bigints *BigInts) { i.object = &bigints.bigints } -- cgit v1.2.3 From bbfe0b8d040728b4f6a40de0480301b4b5f3c9e2 Mon Sep 17 00:00:00 2001 From: Alejandro Isaza Date: Sat, 9 Dec 2017 14:45:46 -0800 Subject: mobile: Add GetSign to BigInt (#15558) --- mobile/big.go | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'mobile') diff --git a/mobile/big.go b/mobile/big.go index 564fbad47..dd7b15878 100644 --- a/mobile/big.go +++ b/mobile/big.go @@ -62,6 +62,16 @@ func (bi *BigInt) SetInt64(x int64) { bi.bigint.SetInt64(x) } +// Sign returns: +// +// -1 if x < 0 +// 0 if x == 0 +// +1 if x > 0 +// +func (bi *BigInt) Sign() int { + return bi.bigint.Sign() +} + // SetString sets the big int to x. // // The string prefix determines the actual conversion base. A prefix of "0x" or -- cgit v1.2.3