From e58e2f5ee466f054405b3e90a67720254ea17ead Mon Sep 17 00:00:00 2001 From: Marek Kotewicz Date: Tue, 3 Feb 2015 23:00:02 +0100 Subject: jsonrpc.js tests && jsonrpc response validation is more strict --- lib/jsonrpc.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'lib/jsonrpc.js') diff --git a/lib/jsonrpc.js b/lib/jsonrpc.js index 0036d0abf..63afa3229 100644 --- a/lib/jsonrpc.js +++ b/lib/jsonrpc.js @@ -39,9 +39,13 @@ var toPayload = function (method, params) { }; /// Should be called to check if jsonrpc response is valid -/// @returns true if response doesn't have error field +/// @returns true if response is valid, otherwise false var isValidResponse = function (response) { - return response && !response.error; + return !!response && + !response.error && + response.jsonrpc === '2.0' && + typeof response.id === 'number' && + (!!response.result || typeof response.result === 'boolean'); }; /// Should be called to create batch payload object -- cgit v1.2.3