From c0ae5c58a6b3d78540ec19b24bd31b6e14e24191 Mon Sep 17 00:00:00 2001 From: Maran Date: Tue, 15 Jul 2014 12:52:30 +0200 Subject: Rewrote mnemonic word loading to facilitate deployable builds. --- ethereal/flags.go | 31 ++----------------------------- 1 file changed, 2 insertions(+), 29 deletions(-) (limited to 'ethereal/flags.go') diff --git a/ethereal/flags.go b/ethereal/flags.go index d5ca9f336..c7d330f80 100644 --- a/ethereal/flags.go +++ b/ethereal/flags.go @@ -1,15 +1,13 @@ package main import ( - "bitbucket.org/kardianos/osext" "flag" "fmt" "github.com/ethereum/eth-go/ethlog" + "github.com/ethereum/go-ethereum/utils" "os" "os/user" "path" - "path/filepath" - "runtime" ) var Identifier string @@ -36,31 +34,6 @@ var LogLevel int // flags specific to gui client var AssetPath string -func defaultAssetPath() string { - var assetPath string - // If the current working directory is the go-ethereum dir - // assume a debug build and use the source directory as - // asset directory. - pwd, _ := os.Getwd() - if pwd == path.Join(os.Getenv("GOPATH"), "src", "github.com", "ethereum", "go-ethereum", "ethereal") { - assetPath = path.Join(pwd, "assets") - } else { - switch runtime.GOOS { - case "darwin": - // Get Binary Directory - exedir, _ := osext.ExecutableFolder() - assetPath = filepath.Join(exedir, "../Resources") - case "linux": - assetPath = "/usr/share/ethereal" - case "windows": - assetPath = "./assets" - default: - assetPath = "." - } - } - return assetPath -} - func defaultDataDir() string { usr, _ := user.Current() return path.Join(usr.HomeDir, ".ethereal") @@ -93,7 +66,7 @@ func Init() { flag.StringVar(&DebugFile, "debug", "", "debug file (no debugging if not set)") flag.IntVar(&LogLevel, "loglevel", int(ethlog.InfoLevel), "loglevel: 0-5: silent,error,warn,info,debug,debug detail)") - flag.StringVar(&AssetPath, "asset_path", defaultAssetPath(), "absolute path to GUI assets directory") + flag.StringVar(&AssetPath, "asset_path", utils.DefaultAssetPath(), "absolute path to GUI assets directory") flag.Parse() } -- cgit v1.2.3 From 223432fa1eedb9fa5c712056afb804322aa12b02 Mon Sep 17 00:00:00 2001 From: Maran Date: Tue, 15 Jul 2014 16:21:16 +0200 Subject: Work around crash issues when building OSX binary --- ethereal/flags.go | 31 +++++++++++++++++++++++++++++-- 1 file changed, 29 insertions(+), 2 deletions(-) (limited to 'ethereal/flags.go') diff --git a/ethereal/flags.go b/ethereal/flags.go index c7d330f80..c9327c3d3 100644 --- a/ethereal/flags.go +++ b/ethereal/flags.go @@ -1,13 +1,15 @@ package main import ( + "bitbucket.org/kardianos/osext" "flag" "fmt" "github.com/ethereum/eth-go/ethlog" - "github.com/ethereum/go-ethereum/utils" "os" "os/user" "path" + "path/filepath" + "runtime" ) var Identifier string @@ -34,6 +36,31 @@ var LogLevel int // flags specific to gui client var AssetPath string +//TODO: If we re-use the one defined in cmd.go the binary osx image crashes. If somebody finds out why we can dry this up. +func defaultAssetPath() string { + var assetPath string + // If the current working directory is the go-ethereum dir + // assume a debug build and use the source directory as + // asset directory. + pwd, _ := os.Getwd() + if pwd == path.Join(os.Getenv("GOPATH"), "src", "github.com", "ethereum", "go-ethereum", "ethereal") { + assetPath = path.Join(pwd, "assets") + } else { + switch runtime.GOOS { + case "darwin": + // Get Binary Directory + exedir, _ := osext.ExecutableFolder() + assetPath = filepath.Join(exedir, "../Resources") + case "linux": + assetPath = "/usr/share/ethereal" + case "windows": + assetPath = "./assets" + default: + assetPath = "." + } + } + return assetPath +} func defaultDataDir() string { usr, _ := user.Current() return path.Join(usr.HomeDir, ".ethereal") @@ -66,7 +93,7 @@ func Init() { flag.StringVar(&DebugFile, "debug", "", "debug file (no debugging if not set)") flag.IntVar(&LogLevel, "loglevel", int(ethlog.InfoLevel), "loglevel: 0-5: silent,error,warn,info,debug,debug detail)") - flag.StringVar(&AssetPath, "asset_path", utils.DefaultAssetPath(), "absolute path to GUI assets directory") + flag.StringVar(&AssetPath, "asset_path", defaultAssetPath(), "absolute path to GUI assets directory") flag.Parse() } -- cgit v1.2.3