From 3f306f63d48f011a527e301e3bf9aec2d6efb7e1 Mon Sep 17 00:00:00 2001 From: Gustav Simonsson Date: Sun, 5 Apr 2015 19:31:18 +0200 Subject: Forward and log EC recover err and remove dup pubkey len check --- crypto/crypto.go | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) (limited to 'crypto') diff --git a/crypto/crypto.go b/crypto/crypto.go index 9a1559fbf..7d1d51fa6 100644 --- a/crypto/crypto.go +++ b/crypto/crypto.go @@ -68,10 +68,8 @@ func Ripemd160(data []byte) []byte { return ripemd.Sum(nil) } -func Ecrecover(hash, sig []byte) []byte { - r, _ := secp256k1.RecoverPubkey(hash, sig) - - return r +func Ecrecover(hash, sig []byte) ([]byte, error) { + return secp256k1.RecoverPubkey(hash, sig) } // New methods using proper ecdsa keys from the stdlib @@ -145,14 +143,14 @@ func GenerateKey() (*ecdsa.PrivateKey, error) { return ecdsa.GenerateKey(S256(), rand.Reader) } -func SigToPub(hash, sig []byte) *ecdsa.PublicKey { - s := Ecrecover(hash, sig) - if s == nil || len(s) != 65 { - return nil +func SigToPub(hash, sig []byte) (*ecdsa.PublicKey, error) { + s, err := Ecrecover(hash, sig) + if err != nil { + return nil, err } x, y := elliptic.Unmarshal(S256(), s) - return &ecdsa.PublicKey{S256(), x, y} + return &ecdsa.PublicKey{S256(), x, y}, nil } func Sign(hash []byte, prv *ecdsa.PrivateKey) (sig []byte, err error) { -- cgit v1.2.3