From d52097c148c5247be8e346c8eca3c3cfc8fdd770 Mon Sep 17 00:00:00 2001
From: Wei-Ning Huang <w@dexon.org>
Date: Thu, 4 Apr 2019 10:33:55 +0800
Subject: core: vm: cache GPK to prevent DoS (#335)

Cache GPK so one can not slow the chain down with the ProposeCRS method
call.
---
 core/vm/oracle_contracts.go | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

(limited to 'core')

diff --git a/core/vm/oracle_contracts.go b/core/vm/oracle_contracts.go
index a698b87f1..06b9c2a89 100644
--- a/core/vm/oracle_contracts.go
+++ b/core/vm/oracle_contracts.go
@@ -24,6 +24,7 @@ import (
 	"math"
 	"math/big"
 	"sort"
+	"sync/atomic"
 
 	"github.com/dexon-foundation/dexon/accounts/abi"
 	"github.com/dexon-foundation/dexon/common"
@@ -1250,16 +1251,32 @@ type GovernanceContract struct {
 
 // defaultCoreDKGUtils implements coreDKGUtils.
 type defaultCoreDKGUtils struct {
+	gpk atomic.Value
 }
 
 func (c *defaultCoreDKGUtils) NewGroupPublicKey(
 	state *GovernanceState, round *big.Int, threshold int) (tsigVerifierIntf, error) {
+	var gpk *dkgTypes.GroupPublicKey
+	var err error
+
+	v := c.gpk.Load()
+	if v != nil {
+		gpk = v.(*dkgTypes.GroupPublicKey)
+		if gpk.Round == round.Uint64() {
+			return gpk, nil
+		}
+	}
 
 	// Prepare DKGMasterPublicKeys.
 	mpks := state.DKGMasterPublicKeyItems()
 	comps := state.DKGComplaintItems()
 
-	return dkgTypes.NewGroupPublicKey(round.Uint64(), mpks, comps, threshold)
+	gpk, err = dkgTypes.NewGroupPublicKey(round.Uint64(), mpks, comps, threshold)
+	if err != nil {
+		return nil, err
+	}
+	c.gpk.Store(gpk)
+	return gpk, nil
 }
 
 func (g *GovernanceContract) Address() common.Address {
-- 
cgit v1.2.3