From 8fbd7c39a3685bb8acb466f1cd797c9324e09fc2 Mon Sep 17 00:00:00 2001
From: Ting-Wei Lan <tingwei.lan@cobinhood.com>
Date: Thu, 21 Feb 2019 16:00:23 +0800
Subject: core: vm: sqlvm: ast: remove pointer indicator in printer output
Since our 'Node' interface includes methods which must be implemented
with pointer receivers, all AST nodes are now referenced with pointers
and the '*' pointer indicator is no longer useful.
---
core/vm/sqlvm/ast/printer.go | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/core/vm/sqlvm/ast/printer.go b/core/vm/sqlvm/ast/printer.go
index 56cfd07b9..e9b289411 100644
--- a/core/vm/sqlvm/ast/printer.go
+++ b/core/vm/sqlvm/ast/printer.go
@@ -44,18 +44,17 @@ func printAST(w io.Writer, n interface{}, depth int, base string, detail bool) {
}
typeOf := reflect.TypeOf(n)
valueOf := reflect.ValueOf(n)
- name := ""
- if typeOf.Kind() == reflect.Ptr {
+ kind := typeOf.Kind()
+ if kind == reflect.Ptr {
if valueOf.IsNil() {
fmt.Fprintf(w, "%snil\n", indent)
return
}
- name = "*"
valueOf = valueOf.Elem()
typeOf = typeOf.Elem()
+ kind = typeOf.Kind()
}
- kind := typeOf.Kind()
- name = name + typeOf.Name()
+ name := typeOf.Name()
if op, ok := n.(UnaryOperator); ok {
fmt.Fprintf(w, "%s%s:\n", indent, name)
--
cgit v1.2.3