From 46eea4d10533f9376e0d36255dfc1083e28d5bbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Szil=C3=A1gyi?= Date: Mon, 27 Feb 2017 13:17:58 +0200 Subject: accounts, eth/downloader: use "err" instead of "error" in logs --- accounts/abi/bind/util.go | 2 +- accounts/keystore/account_cache.go | 6 +++--- accounts/keystore/watch.go | 2 +- accounts/usbwallet/ledger_wallet.go | 10 +++++----- eth/downloader/downloader.go | 26 +++++++++++++------------- 5 files changed, 23 insertions(+), 23 deletions(-) diff --git a/accounts/abi/bind/util.go b/accounts/abi/bind/util.go index ca79694ef..50b7a6f02 100644 --- a/accounts/abi/bind/util.go +++ b/accounts/abi/bind/util.go @@ -39,7 +39,7 @@ func WaitMined(ctx context.Context, b DeployBackend, tx *types.Transaction) (*ty return receipt, nil } if err != nil { - logger.Trace("Receipt retrieval failed", "error", err) + logger.Trace("Receipt retrieval failed", "err", err) } else { logger.Trace("Transaction not yet mined") } diff --git a/accounts/keystore/account_cache.go b/accounts/keystore/account_cache.go index 866f8ae7b..2324e128d 100644 --- a/accounts/keystore/account_cache.go +++ b/accounts/keystore/account_cache.go @@ -210,7 +210,7 @@ func (ac *accountCache) close() { func (ac *accountCache) reload() { accounts, err := ac.scan() if err != nil { - log.Debug("Failed to reload keystore contents", "error", err) + log.Debug("Failed to reload keystore contents", "err", err) } ac.all = accounts sort.Sort(ac.all) @@ -250,7 +250,7 @@ func (ac *accountCache) scan() ([]accounts.Account, error) { fd, err := os.Open(path) if err != nil { - logger.Trace("Failed to open keystore file", "error", err) + logger.Trace("Failed to open keystore file", "err", err) continue } buf.Reset(fd) @@ -260,7 +260,7 @@ func (ac *accountCache) scan() ([]accounts.Account, error) { addr := common.HexToAddress(keyJSON.Address) switch { case err != nil: - logger.Debug("Failed to decode keystore key", "error", err) + logger.Debug("Failed to decode keystore key", "err", err) case (addr == common.Address{}): logger.Debug("Failed to decode keystore key", "error", "missing or zero address") default: diff --git a/accounts/keystore/watch.go b/accounts/keystore/watch.go index ae97805be..f4d647791 100644 --- a/accounts/keystore/watch.go +++ b/accounts/keystore/watch.go @@ -66,7 +66,7 @@ func (w *watcher) loop() { logger := log.New("path", w.ac.keydir) if err := notify.Watch(w.ac.keydir, w.ev, notify.All); err != nil { - logger.Trace("Failed to watch keystore folder", "error", err) + logger.Trace("Failed to watch keystore folder", "err", err) return } defer notify.Stop(w.ev) diff --git a/accounts/usbwallet/ledger_wallet.go b/accounts/usbwallet/ledger_wallet.go index 6086660f9..37e04e598 100644 --- a/accounts/usbwallet/ledger_wallet.go +++ b/accounts/usbwallet/ledger_wallet.go @@ -262,7 +262,7 @@ func (w *ledgerWallet) heartbeat() { } // In case of error, wait for termination if err != nil { - w.logger.Debug("Ledger health-check failed", "error", err) + w.logger.Debug("Ledger health-check failed", "err", err) errc = <-w.healthQuit } errc <- err @@ -396,7 +396,7 @@ func (w *ledgerWallet) selfDerive() { // Retrieve the next derived Ethereum account if nextAddr == (common.Address{}) { if nextAddr, err = w.ledgerDerive(nextPath); err != nil { - w.logger.Warn("Ledger account derivation failed", "error", err) + w.logger.Warn("Ledger account derivation failed", "err", err) break } } @@ -407,12 +407,12 @@ func (w *ledgerWallet) selfDerive() { ) balance, err = w.deriveChain.BalanceAt(context, nextAddr, nil) if err != nil { - w.logger.Warn("Ledger balance retrieval failed", "error", err) + w.logger.Warn("Ledger balance retrieval failed", "err", err) break } nonce, err = w.deriveChain.NonceAt(context, nextAddr, nil) if err != nil { - w.logger.Warn("Ledger nonce retrieval failed", "error", err) + w.logger.Warn("Ledger nonce retrieval failed", "err", err) break } // If the next account is empty, stop self-derivation, but add it nonetheless @@ -471,7 +471,7 @@ func (w *ledgerWallet) selfDerive() { } // In case of error, wait for termination if err != nil { - w.logger.Debug("Ledger self-derivation failed", "error", err) + w.logger.Debug("Ledger self-derivation failed", "err", err) errc = <-w.deriveQuit } errc <- err diff --git a/eth/downloader/downloader.go b/eth/downloader/downloader.go index f71ecbb43..8ce86eacd 100644 --- a/eth/downloader/downloader.go +++ b/eth/downloader/downloader.go @@ -250,7 +250,7 @@ func (d *Downloader) RegisterPeer(id string, version int, currentHead currentHea logger := log.New("peer", id) logger.Trace("Registering sync peer") if err := d.peers.Register(newPeer(id, version, currentHead, getRelHeaders, getAbsHeaders, getBlockBodies, getReceipts, getNodeData, logger)); err != nil { - logger.Error("Failed to register sync peer", "error", err) + logger.Error("Failed to register sync peer", "err", err) return err } d.qosReduceConfidence() @@ -266,7 +266,7 @@ func (d *Downloader) UnregisterPeer(id string) error { logger := log.New("peer", id) logger.Trace("Unregistering sync peer") if err := d.peers.Unregister(id); err != nil { - logger.Error("Failed to unregister sync peer", "error", err) + logger.Error("Failed to unregister sync peer", "err", err) return err } d.queue.Revoke(id) @@ -293,11 +293,11 @@ func (d *Downloader) Synchronise(id string, head common.Hash, td *big.Int, mode case errTimeout, errBadPeer, errStallingPeer, errEmptyHeaderSet, errPeersUnavailable, errTooOld, errInvalidAncestor, errInvalidChain: - log.Warn("Synchronisation failed, dropping peer", "peer", id, "error", err) + log.Warn("Synchronisation failed, dropping peer", "peer", id, "err", err) d.dropPeer(id) default: - log.Warn("Synchronisation failed, retrying", "error", err) + log.Warn("Synchronisation failed, retrying", "err", err) } return err } @@ -802,7 +802,7 @@ func (d *Downloader) fetchHeaders(p *peer, from uint64) error { if skeleton { filled, proced, err := d.fillHeaderSkeleton(from, headers) if err != nil { - p.logger.Debug("Skeleton chain invalid", "error", err) + p.logger.Debug("Skeleton chain invalid", "err", err) return errInvalidChain } headers = filled[proced:] @@ -873,7 +873,7 @@ func (d *Downloader) fillHeaderSkeleton(from uint64, skeleton []*types.Header) ( d.queue.PendingHeaders, d.queue.InFlightHeaders, throttle, reserve, nil, fetch, d.queue.CancelHeaders, capacity, d.peers.HeaderIdlePeers, setIdle, "headers") - log.Debug("Skeleton fill terminated", "error", err) + log.Debug("Skeleton fill terminated", "err", err) filled, proced := d.queue.RetrieveHeaders() return filled, proced, err @@ -899,7 +899,7 @@ func (d *Downloader) fetchBodies(from uint64) error { d.queue.PendingBlocks, d.queue.InFlightBlocks, d.queue.ShouldThrottleBlocks, d.queue.ReserveBodies, d.bodyFetchHook, fetch, d.queue.CancelBodies, capacity, d.peers.BodyIdlePeers, setIdle, "bodies") - log.Debug("Block body download terminated", "error", err) + log.Debug("Block body download terminated", "err", err) return err } @@ -923,7 +923,7 @@ func (d *Downloader) fetchReceipts(from uint64) error { d.queue.PendingReceipts, d.queue.InFlightReceipts, d.queue.ShouldThrottleReceipts, d.queue.ReserveReceipts, d.receiptFetchHook, fetch, d.queue.CancelReceipts, capacity, d.peers.ReceiptIdlePeers, setIdle, "receipts") - log.Debug("Transaction receipt download terminated", "error", err) + log.Debug("Transaction receipt download terminated", "err", err) return err } @@ -944,7 +944,7 @@ func (d *Downloader) fetchNodeData() error { } if err != nil { // If the node data processing failed, the root hash is very wrong, abort - log.Error("State processing failed", "peer", packet.PeerId(), "error", err) + log.Error("State processing failed", "peer", packet.PeerId(), "err", err) d.cancel() return } @@ -985,7 +985,7 @@ func (d *Downloader) fetchNodeData() error { d.queue.PendingNodeData, d.queue.InFlightNodeData, throttle, reserve, nil, fetch, d.queue.CancelNodeData, capacity, d.peers.NodeDataIdlePeers, setIdle, "states") - log.Debug("Node state data download terminated", "error", err) + log.Debug("Node state data download terminated", "err", err) return err } @@ -1054,7 +1054,7 @@ func (d *Downloader) fetchParts(errCancel error, deliveryCh chan dataPack, deliv case err == nil: peer.logger.Trace("Delivered new batch of data", "type", kind, "count", packet.Stats()) default: - peer.logger.Trace("Failed to deliver retrieved data", "type", kind, "error", err) + peer.logger.Trace("Failed to deliver retrieved data", "type", kind, "err", err) } } // Blocks assembled, try to update the progress @@ -1304,7 +1304,7 @@ func (d *Downloader) processHeaders(origin uint64, td *big.Int) error { if n > 0 { rollback = append(rollback, chunk[:n]...) } - log.Debug("Invalid header encountered", "number", chunk[n].Number, "hash", chunk[n].Hash().Hex()[2:10], "error", err) + log.Debug("Invalid header encountered", "number", chunk[n].Number, "hash", chunk[n].Hash().Hex()[2:10], "err", err) return errInvalidChain } // All verifications passed, store newly found uncertain headers @@ -1413,7 +1413,7 @@ func (d *Downloader) processContent() error { index, err = d.insertBlocks(blocks) } if err != nil { - log.Debug("Downloaded item processing failed", "number", results[index].Header.Number, "hash", results[index].Header.Hash().Hex()[2:10], "error", err) + log.Debug("Downloaded item processing failed", "number", results[index].Header.Number, "hash", results[index].Header.Hash().Hex()[2:10], "err", err) return errInvalidChain } // Shift the results to the next batch -- cgit v1.2.3