aboutsummaryrefslogtreecommitdiffstats
path: root/whisper/mailserver/server_test.go
diff options
context:
space:
mode:
authorGuillaume Ballet <gballet@gmail.com>2018-02-28 21:10:08 +0800
committerGitHub <noreply@github.com>2018-02-28 21:10:08 +0800
commit1843615456b531fdf9fce836013579bd52c92d86 (patch)
tree7d8777a6102ae0230fe51004a4503f7b3e5afafa /whisper/mailserver/server_test.go
parent7843192c8e18d1d7d559a19c2234a8563e5670f5 (diff)
parenta69cb3b4ff55c6ea2bafb7bd0ab0ff4afafb148f (diff)
downloaddexon-1843615456b531fdf9fce836013579bd52c92d86.tar
dexon-1843615456b531fdf9fce836013579bd52c92d86.tar.gz
dexon-1843615456b531fdf9fce836013579bd52c92d86.tar.bz2
dexon-1843615456b531fdf9fce836013579bd52c92d86.tar.lz
dexon-1843615456b531fdf9fce836013579bd52c92d86.tar.xz
dexon-1843615456b531fdf9fce836013579bd52c92d86.tar.zst
dexon-1843615456b531fdf9fce836013579bd52c92d86.zip
Merge pull request #16206 from gluk256/277-mailserver
whisper: mailserver no longer supports the signature validation Mailserver is provided as an example, but client validation belongs to the upper layer protocol and needs not be covered in this example. The check that was previously available hinders the switch to libp2p so we agreed not to include that check in that example code anymore.
Diffstat (limited to 'whisper/mailserver/server_test.go')
-rw-r--r--whisper/mailserver/server_test.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/whisper/mailserver/server_test.go b/whisper/mailserver/server_test.go
index c8e0a553a..63864c1e6 100644
--- a/whisper/mailserver/server_test.go
+++ b/whisper/mailserver/server_test.go
@@ -167,8 +167,9 @@ func singleRequest(t *testing.T, server *WMailServer, env *whisper.Envelope, p *
src[0]++
ok, lower, upper, topic = server.validateRequest(src, request)
- if ok {
- t.Fatalf("request validation false positive, seed: %d (lower: %d, upper: %d).", seed, lower, upper)
+ if !ok {
+ // request should be valid regardless of signature
+ t.Fatalf("request validation false negative, seed: %d (lower: %d, upper: %d).", seed, lower, upper)
}
}