aboutsummaryrefslogtreecommitdiffstats
path: root/vm
diff options
context:
space:
mode:
authorobscuren <geffobscura@gmail.com>2014-11-14 20:47:12 +0800
committerobscuren <geffobscura@gmail.com>2014-11-14 20:47:12 +0800
commitf6e55962a8cadfb440dd03467017941b96838362 (patch)
tree259bdf39e8697f03c0f1944d4c33cbfb21277204 /vm
parent20d518ee959f1621a5accf1f3432282a6c0d6c3c (diff)
downloaddexon-f6e55962a8cadfb440dd03467017941b96838362.tar
dexon-f6e55962a8cadfb440dd03467017941b96838362.tar.gz
dexon-f6e55962a8cadfb440dd03467017941b96838362.tar.bz2
dexon-f6e55962a8cadfb440dd03467017941b96838362.tar.lz
dexon-f6e55962a8cadfb440dd03467017941b96838362.tar.xz
dexon-f6e55962a8cadfb440dd03467017941b96838362.tar.zst
dexon-f6e55962a8cadfb440dd03467017941b96838362.zip
Fixes for PV41/42
* Don't expand mem on empty value * Removed all coinbase logs for PV42 * Removed C++ bug stuff for LOG*
Diffstat (limited to 'vm')
-rw-r--r--vm/execution.go2
-rw-r--r--vm/stack.go28
-rw-r--r--vm/vm_debug.go15
3 files changed, 28 insertions, 17 deletions
diff --git a/vm/execution.go b/vm/execution.go
index 401157808..c23164f82 100644
--- a/vm/execution.go
+++ b/vm/execution.go
@@ -34,11 +34,13 @@ func (self *Execution) Exec(codeAddr []byte, caller ClosureRef) ([]byte, error)
func (self *Execution) exec(code, caddr []byte, caller ClosureRef) (ret []byte, err error) {
env := self.vm.Env()
+ vmlogger.Debugf("pre state %x\n", env.State().Root())
snapshot := env.State().Copy()
defer func() {
if IsDepthErr(err) || IsOOGErr(err) {
env.State().Set(snapshot)
}
+ vmlogger.Debugf("post state %x\n", env.State().Root())
}()
msg := env.State().Manifest().AddMessage(&state.Message{
diff --git a/vm/stack.go b/vm/stack.go
index 69ded6562..2eca60ad1 100644
--- a/vm/stack.go
+++ b/vm/stack.go
@@ -107,20 +107,26 @@ type Memory struct {
store []byte
}
+func NewMemory() *Memory {
+ return &Memory{nil}
+}
+
func (m *Memory) Set(offset, size int64, value []byte) {
- totSize := offset + size
- lenSize := int64(len(m.store) - 1)
- if totSize > lenSize {
- // Calculate the diff between the sizes
- diff := totSize - lenSize
- if diff > 0 {
- // Create a new empty slice and append it
- newSlice := make([]byte, diff-1)
- // Resize slice
- m.store = append(m.store, newSlice...)
+ if len(value) > 0 {
+ totSize := offset + size
+ lenSize := int64(len(m.store) - 1)
+ if totSize > lenSize {
+ // Calculate the diff between the sizes
+ diff := totSize - lenSize
+ if diff > 0 {
+ // Create a new empty slice and append it
+ newSlice := make([]byte, diff-1)
+ // Resize slice
+ m.store = append(m.store, newSlice...)
+ }
}
+ copy(m.store[offset:offset+size], value)
}
- copy(m.store[offset:offset+size], value)
}
func (m *Memory) Resize(size uint64) {
diff --git a/vm/vm_debug.go b/vm/vm_debug.go
index 37ad7620e..ae5a20175 100644
--- a/vm/vm_debug.go
+++ b/vm/vm_debug.go
@@ -61,7 +61,7 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
op OpCode
destinations = analyseJumpDests(closure.Code)
- mem = &Memory{}
+ mem = NewMemory()
stack = NewStack()
pc = big.NewInt(0)
step = 0
@@ -169,8 +169,6 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
gas.Set(GasLog)
addStepGasUsage(new(big.Int).Mul(big.NewInt(int64(n)), GasLog))
addStepGasUsage(new(big.Int).Add(mSize, mStart))
- // BUG in C++
- //gas.Set(ethutil.Big1)
// Gas only
case STOP:
gas.Set(ethutil.Big0)
@@ -263,11 +261,14 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
memGasUsage.Div(memGasUsage, u256(32))
addStepGasUsage(memGasUsage)
+
+ mem.Resize(newMemSize.Uint64())
}
+
}
self.Printf("(pc) %-3d -o- %-14s", pc, op.String())
- self.Printf(" (g) %-3v (%v)", gas, closure.Gas)
+ self.Printf(" (m) %-4d (s) %-4d (g) %-3v (%v)", mem.Len(), stack.Len(), gas, closure.Gas)
if !closure.UseGas(gas) {
self.Endl()
@@ -279,8 +280,6 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
return closure.Return(nil), OOG(gas, tmp)
}
- mem.Resize(newMemSize.Uint64())
-
switch op {
// 0x20 range
case ADD:
@@ -622,6 +621,8 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
code := closure.Args[cOff : cOff+l]
mem.Set(mOff, l, code)
+
+ self.Printf(" => [%v, %v, %v] %x", mOff, cOff, l, code[cOff:cOff+l])
case CODESIZE, EXTCODESIZE:
var code []byte
if op == EXTCODESIZE {
@@ -663,6 +664,8 @@ func (self *DebugVm) RunClosure(closure *Closure) (ret []byte, err error) {
codeCopy := code[cOff : cOff+l]
mem.Set(mOff, l, codeCopy)
+
+ self.Printf(" => [%v, %v, %v] %x", mOff, cOff, l, code[cOff:cOff+l])
case GASPRICE:
stack.Push(closure.Price)