diff options
| author | Felix Lange <fjl@twurst.com> | 2016-10-15 00:04:33 +0800 |
|---|---|---|
| committer | Péter Szilágyi <peterke@gmail.com> | 2016-10-15 00:04:33 +0800 |
| commit | 40cdcf1183df235e4b32cfdbf6182a00a0e49f24 (patch) | |
| tree | 571daa75d1590a47dfe98b67ab1a3350e46ea527 /trie/sync.go | |
| parent | c2ddfb343a22958324c0c26dae789d3937eece4f (diff) | |
| download | dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar.gz dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar.bz2 dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar.lz dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar.xz dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.tar.zst dexon-40cdcf1183df235e4b32cfdbf6182a00a0e49f24.zip | |
trie, core/state: improve memory usage and performance (#3135)
* trie: store nodes as pointers
This avoids memory copies when unwrapping node interface values.
name old time/op new time/op delta
Get 388ns ± 8% 215ns ± 2% -44.56% (p=0.000 n=15+15)
GetDB 363ns ± 3% 202ns ± 2% -44.21% (p=0.000 n=15+15)
UpdateBE 1.57µs ± 2% 1.29µs ± 3% -17.80% (p=0.000 n=13+15)
UpdateLE 1.92µs ± 2% 1.61µs ± 2% -16.25% (p=0.000 n=14+14)
HashBE 2.16µs ± 6% 2.18µs ± 6% ~ (p=0.436 n=15+15)
HashLE 7.43µs ± 3% 7.21µs ± 3% -2.96% (p=0.000 n=15+13)
* trie: close temporary databases in GetDB benchmark
* trie: don't keep []byte from DB load around
Nodes decoded from a DB load kept hashes and values as sub-slices of
the DB value. This can be a problem because loading from leveldb often
returns []byte with a cap that's larger than necessary, increasing
memory usage.
* trie: unload old cached nodes
* trie, core/state: use cache unloading for account trie
* trie: use explicit private flags (fixes Go 1.5 reflection issue).
* trie: fixup cachegen overflow at request of nick
* core/state: rename journal size constant
Diffstat (limited to 'trie/sync.go')
| -rw-r--r-- | trie/sync.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/trie/sync.go b/trie/sync.go index 6e9e029b9..3de758536 100644 --- a/trie/sync.go +++ b/trie/sync.go @@ -212,12 +212,12 @@ func (s *TrieSync) children(req *request) ([]*request, error) { children := []child{} switch node := (*req.object).(type) { - case shortNode: + case *shortNode: children = []child{{ node: &node.Val, depth: req.depth + len(node.Key), }} - case fullNode: + case *fullNode: for i := 0; i < 17; i++ { if node.Children[i] != nil { children = append(children, child{ |