aboutsummaryrefslogtreecommitdiffstats
path: root/tests/transaction_test.go
diff options
context:
space:
mode:
authorGustav Simonsson <gustav.simonsson@gmail.com>2015-04-16 04:37:16 +0800
committerGustav Simonsson <gustav.simonsson@gmail.com>2015-04-16 04:37:16 +0800
commitc617a6ec790a974770f3553fe0b2fed9ad560fcc (patch)
tree916080981cc2dc8c32ec57fb8fc4f18ac801256a /tests/transaction_test.go
parent2d8a2d0c9997e658bbdbf7a172c920dbb3c47821 (diff)
downloaddexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar.gz
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar.bz2
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar.lz
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar.xz
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.tar.zst
dexon-c617a6ec790a974770f3553fe0b2fed9ad560fcc.zip
Fixes for TransactionTests
* Include tests which now has consistent HEX encodings * Comment out two failing tests: " "TransactionWithHihghNonce" due to wrong nonce size "TransactionWithSvalueHigh" due to wrong ECDSA s range * Cleanup conversion functions and fix expected encodings for tests validation fields
Diffstat (limited to 'tests/transaction_test.go')
-rw-r--r--tests/transaction_test.go29
1 files changed, 18 insertions, 11 deletions
diff --git a/tests/transaction_test.go b/tests/transaction_test.go
index dabc7823b..a6c7492d5 100644
--- a/tests/transaction_test.go
+++ b/tests/transaction_test.go
@@ -6,19 +6,11 @@ import (
func TestTransactions(t *testing.T) {
notWorking := make(map[string]bool, 100)
- // TODO: all commented out tests should work!
+ // TODO: all these tests should work! remove them from the array when they work
snafus := []string{
- "EmptyTransaction",
- "TransactionWithHihghNonce",
- "TransactionWithRvalueWrongSize",
- "TransactionWithSvalueHigh",
- "TransactionWithSvalueTooHigh",
- "TransactionWithSvalueWrongSize",
- "ValuesAsDec",
- "ValuesAsHex",
- "libsecp256k1test",
- "unpadedRValue",
+ "TransactionWithHihghNonce", // fails due to testing upper bound of 256 bit nonce
+ "TransactionWithSvalueHigh", // fails due to C++ wrong ECDSA r,s ranges. see https://github.com/ethereum/yellowpaper/pull/112
}
for _, name := range snafus {
@@ -42,3 +34,18 @@ func TestWrongRLPTransactions(t *testing.T) {
t.Fatal(err)
}
}
+
+/*
+
+Not working until it's fields are in HEX
+
+func Test10MBtx(t *testing.T) {
+ notWorking := make(map[string]bool, 100)
+ var err error
+ err = RunTransactionTests("./files/TransactionTests/tt10mbDataField.json",
+ notWorking)
+ if err != nil {
+ t.Fatal(err)
+ }
+}
+*/