diff options
| author | Felix Lange <fjl@twurst.com> | 2015-01-06 18:35:09 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@twurst.com> | 2015-01-06 19:23:38 +0800 |
| commit | eb0e7b1b8120852a1d56aa0ebd3a98e652965635 (patch) | |
| tree | 9e87afc204d178d89ed24cc43afcc3da6b252a49 /p2p/peer_test.go | |
| parent | 36e1e5f15142b37801844a072eb46ea67fbc8868 (diff) | |
| download | dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar.gz dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar.bz2 dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar.lz dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar.xz dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.tar.zst dexon-eb0e7b1b8120852a1d56aa0ebd3a98e652965635.zip | |
eth, p2p: remove EncodeMsg from p2p.MsgWriter
...and make it a top-level function instead.
The original idea behind having EncodeMsg in the interface was that
implementations might be able to encode RLP data to their underlying
writer directly instead of buffering the encoded data. The encoder
will buffer anyway, so that doesn't matter anymore.
Given the recent problems with EncodeMsg (copy-pasted implementation
bug) I'd rather implement once, correctly.
Diffstat (limited to 'p2p/peer_test.go')
| -rw-r--r-- | p2p/peer_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/p2p/peer_test.go b/p2p/peer_test.go index 5b9e9e784..4ee88f112 100644 --- a/p2p/peer_test.go +++ b/p2p/peer_test.go @@ -126,10 +126,10 @@ func TestPeerProtoEncodeMsg(t *testing.T) { Name: "a", Length: 2, Run: func(peer *Peer, rw MsgReadWriter) error { - if err := rw.EncodeMsg(2); err == nil { + if err := EncodeMsg(rw, 2); err == nil { t.Error("expected error for out-of-range msg code, got nil") } - if err := rw.EncodeMsg(1, "foo", "bar"); err != nil { + if err := EncodeMsg(rw, 1, "foo", "bar"); err != nil { t.Errorf("write error: %v", err) } return nil |