aboutsummaryrefslogtreecommitdiffstats
path: root/mobile/ethereum.go
diff options
context:
space:
mode:
authorElias Naur <elias.naur@gmail.com>2017-07-17 20:25:46 +0800
committerPéter Szilágyi <peterke@gmail.com>2017-07-17 20:25:46 +0800
commit23c6fcdbe834b70ff25473e6ff03da94814609c1 (patch)
tree09eaf858707d61ff2f117cadc0e11e2a0e77f0da /mobile/ethereum.go
parentcf5d4b55412f570bd1b492998b0c0b8e953e2418 (diff)
downloaddexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar.gz
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar.bz2
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar.lz
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar.xz
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.tar.zst
dexon-23c6fcdbe834b70ff25473e6ff03da94814609c1.zip
mobile: don't retain transient []byte in CallMsg.SetData (#14804)
* mobile: don't retain transient []byte in CallMsg.SetData Go mobile doesn't copy []byte parameters, for performance and to allow writes to the byte array be reflected in the native byte array. Unfortunately, that means []byte arguments are only valid during the call it is being passed into. CallMsg.SetData retains such a byte array. Copy it instead Fixes #14675 * mobile: copy all []byte arguments from gomobile To avoid subtle errors when accidentially retaining an otherwise transient byte slice coming from gomobile, copy all byte slices before use. * mobile: replace copySlice with common.CopyBytes
Diffstat (limited to 'mobile/ethereum.go')
-rw-r--r--mobile/ethereum.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/mobile/ethereum.go b/mobile/ethereum.go
index 30a94dc89..c9bb3013c 100644
--- a/mobile/ethereum.go
+++ b/mobile/ethereum.go
@@ -64,7 +64,7 @@ func (msg *CallMsg) SetFrom(address *Address) { msg.msg.From = address.address
func (msg *CallMsg) SetGas(gas int64) { msg.msg.Gas = big.NewInt(gas) }
func (msg *CallMsg) SetGasPrice(price *BigInt) { msg.msg.GasPrice = price.bigint }
func (msg *CallMsg) SetValue(value *BigInt) { msg.msg.Value = value.bigint }
-func (msg *CallMsg) SetData(data []byte) { msg.msg.Data = data }
+func (msg *CallMsg) SetData(data []byte) { msg.msg.Data = common.CopyBytes(data) }
func (msg *CallMsg) SetTo(address *Address) {
if address == nil {
msg.msg.To = nil