aboutsummaryrefslogtreecommitdiffstats
path: root/metrics
diff options
context:
space:
mode:
authorkiel barry <kiel.j.barry@gmail.com>2018-05-03 17:43:59 +0800
committerPéter Szilágyi <peterke@gmail.com>2018-05-03 17:43:59 +0800
commitcd9a1d5b37b41c45fd660bc36ced5427478fc0e0 (patch)
treedc01dc6d1f28441ae43af3b198afa261d7328b0d /metrics
parent2ad511ce0912194e9f30010f01fc338c585f8634 (diff)
downloaddexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar.gz
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar.bz2
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar.lz
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar.xz
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.tar.zst
dexon-cd9a1d5b37b41c45fd660bc36ced5427478fc0e0.zip
metrics: golint updates for this or self warning (#16635)
* metrics/*: golint updates for this or self warning * metrics/*: golint updates for this or self warning, updated pr from feedback
Diffstat (limited to 'metrics')
-rw-r--r--metrics/librato/client.go4
-rw-r--r--metrics/librato/librato.go46
2 files changed, 25 insertions, 25 deletions
diff --git a/metrics/librato/client.go b/metrics/librato/client.go
index 8c0c850e3..1f8920cb1 100644
--- a/metrics/librato/client.go
+++ b/metrics/librato/client.go
@@ -65,7 +65,7 @@ type Batch struct {
Source string `json:"source"`
}
-func (self *LibratoClient) PostMetrics(batch Batch) (err error) {
+func (c *LibratoClient) PostMetrics(batch Batch) (err error) {
var (
js []byte
req *http.Request
@@ -85,7 +85,7 @@ func (self *LibratoClient) PostMetrics(batch Batch) (err error) {
}
req.Header.Set("Content-Type", "application/json")
- req.SetBasicAuth(self.Email, self.Token)
+ req.SetBasicAuth(c.Email, c.Token)
if resp, err = http.DefaultClient.Do(req); err != nil {
return
diff --git a/metrics/librato/librato.go b/metrics/librato/librato.go
index f8c8c9ecb..2138e01ae 100644
--- a/metrics/librato/librato.go
+++ b/metrics/librato/librato.go
@@ -40,14 +40,14 @@ func Librato(r metrics.Registry, d time.Duration, e string, t string, s string,
NewReporter(r, d, e, t, s, p, u).Run()
}
-func (self *Reporter) Run() {
+func (rep *Reporter) Run() {
log.Printf("WARNING: This client has been DEPRECATED! It has been moved to https://github.com/mihasya/go-metrics-librato and will be removed from rcrowley/go-metrics on August 5th 2015")
- ticker := time.Tick(self.Interval)
- metricsApi := &LibratoClient{self.Email, self.Token}
+ ticker := time.Tick(rep.Interval)
+ metricsApi := &LibratoClient{rep.Email, rep.Token}
for now := range ticker {
var metrics Batch
var err error
- if metrics, err = self.BuildRequest(now, self.Registry); err != nil {
+ if metrics, err = rep.BuildRequest(now, rep.Registry); err != nil {
log.Printf("ERROR constructing librato request body %s", err)
continue
}
@@ -79,21 +79,21 @@ func sumSquaresTimer(t metrics.Timer) float64 {
return sumSquares
}
-func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot Batch, err error) {
+func (rep *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot Batch, err error) {
snapshot = Batch{
// coerce timestamps to a stepping fn so that they line up in Librato graphs
- MeasureTime: (now.Unix() / self.intervalSec) * self.intervalSec,
- Source: self.Source,
+ MeasureTime: (now.Unix() / rep.intervalSec) * rep.intervalSec,
+ Source: rep.Source,
}
snapshot.Gauges = make([]Measurement, 0)
snapshot.Counters = make([]Measurement, 0)
- histogramGaugeCount := 1 + len(self.Percentiles)
+ histogramGaugeCount := 1 + len(rep.Percentiles)
r.Each(func(name string, metric interface{}) {
- if self.Namespace != "" {
- name = fmt.Sprintf("%s.%s", self.Namespace, name)
+ if rep.Namespace != "" {
+ name = fmt.Sprintf("%s.%s", rep.Namespace, name)
}
measurement := Measurement{}
- measurement[Period] = self.Interval.Seconds()
+ measurement[Period] = rep.Interval.Seconds()
switch m := metric.(type) {
case metrics.Counter:
if m.Count() > 0 {
@@ -125,7 +125,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
measurement[Sum] = float64(s.Sum())
measurement[SumSquares] = sumSquares(s)
gauges[0] = measurement
- for i, p := range self.Percentiles {
+ for i, p := range rep.Percentiles {
gauges[i+1] = Measurement{
Name: fmt.Sprintf("%s.%.2f", measurement[Name], p),
Value: s.Percentile(p),
@@ -142,7 +142,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "1min"),
Value: m.Rate1(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,
@@ -152,7 +152,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "5min"),
Value: m.Rate5(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,
@@ -162,7 +162,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "15min"),
Value: m.Rate15(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,
@@ -184,15 +184,15 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Max: float64(m.Max()),
Min: float64(m.Min()),
SumSquares: sumSquaresTimer(m),
- Period: int64(self.Interval.Seconds()),
- Attributes: self.TimerAttributes,
+ Period: int64(rep.Interval.Seconds()),
+ Attributes: rep.TimerAttributes,
}
- for i, p := range self.Percentiles {
+ for i, p := range rep.Percentiles {
gauges[i+1] = Measurement{
Name: fmt.Sprintf("%s.timer.%2.0f", name, p*100),
Value: m.Percentile(p),
- Period: int64(self.Interval.Seconds()),
- Attributes: self.TimerAttributes,
+ Period: int64(rep.Interval.Seconds()),
+ Attributes: rep.TimerAttributes,
}
}
snapshot.Gauges = append(snapshot.Gauges, gauges...)
@@ -200,7 +200,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "rate.1min"),
Value: m.Rate1(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,
@@ -210,7 +210,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "rate.5min"),
Value: m.Rate5(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,
@@ -220,7 +220,7 @@ func (self *Reporter) BuildRequest(now time.Time, r metrics.Registry) (snapshot
Measurement{
Name: fmt.Sprintf("%s.%s", name, "rate.15min"),
Value: m.Rate15(),
- Period: int64(self.Interval.Seconds()),
+ Period: int64(rep.Interval.Seconds()),
Attributes: map[string]interface{}{
DisplayUnitsLong: Operations,
DisplayUnitsShort: OperationsShort,