aboutsummaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorobscuren <geffobscura@gmail.com>2015-06-04 22:19:22 +0800
committerobscuren <geffobscura@gmail.com>2015-06-04 22:19:22 +0800
commitdcdb4554d7f7ea3e96fec57805f0ea1042d0abc7 (patch)
tree869b04dc058936fe0e61416265d568839eec2991 /core
parentcf5ad266f6b8b7dd4800b63404c0efe680d47673 (diff)
downloaddexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar.gz
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar.bz2
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar.lz
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar.xz
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.tar.zst
dexon-dcdb4554d7f7ea3e96fec57805f0ea1042d0abc7.zip
core: documented changes in tx pool
Diffstat (limited to 'core')
-rw-r--r--core/transaction_pool.go33
1 files changed, 30 insertions, 3 deletions
diff --git a/core/transaction_pool.go b/core/transaction_pool.go
index a0f3c326a..462159fa7 100644
--- a/core/transaction_pool.go
+++ b/core/transaction_pool.go
@@ -62,19 +62,32 @@ func NewTxPool(eventMux *event.TypeMux, currentStateFn stateFn, gasLimitFn func(
}
func (pool *TxPool) Start() {
+ // Track chain events. When a chain events occurs (new chain canon block)
+ // we need to know the new state. The new state will help us determine
+ // the nonces in the managed state
pool.events = pool.eventMux.Subscribe(ChainEvent{})
for _ = range pool.events.Chan() {
pool.mu.Lock()
pool.state = state.ManageState(pool.currentState())
+ // validate the pool of pending transactions, this will remove
+ // any transactions that have been included in the block or
+ // have been invalidated because of another transaction (e.g.
+ // higher gas price)
+ pool.validatePool()
+
+ // Loop over the pending transactions and base the nonce of the new
+ // pending transaction set.
for _, tx := range pool.pending {
if addr, err := tx.From(); err == nil {
- if pool.state.GetNonce(addr) < tx.Nonce() {
- pool.state.SetNonce(addr, tx.Nonce())
- }
+ // Set the nonce. Transaction nonce can never be lower
+ // than the state nonce; validatePool took care of that.
+ pool.state.SetNonce(addr, tx.Nonce())
}
}
+ // Check the queue and move transactions over to the pending if possible
+ // or remove those that have become invalid
pool.checkQueue()
pool.mu.Unlock()
}
@@ -103,32 +116,46 @@ func (pool *TxPool) validateTx(tx *types.Transaction) error {
err error
)
+ // Validate the transaction sender and it's sig. Throw
+ // if the from fields is invalid.
if from, err = tx.From(); err != nil {
return ErrInvalidSender
}
+ // Make sure the account exist. Non existant accounts
+ // haven't got funds and well therefor never pass.
if !pool.currentState().HasAccount(from) {
return ErrNonExistentAccount
}
+ // Check the transaction doesn't exceed the current
+ // block limit gas.
if pool.gasLimit().Cmp(tx.GasLimit) < 0 {
return ErrGasLimit
}
+ // Transactions can't be negative. This may never happen
+ // using RLP decoded transactions but may occur if you create
+ // a transaction using the RPC for example.
if tx.Amount.Cmp(common.Big0) < 0 {
return ErrNegativeValue
}
+ // Transactor should have enough funds to cover the costs
+ // cost == V + GP * GL
total := new(big.Int).Mul(tx.Price, tx.GasLimit)
total.Add(total, tx.Value())
if pool.currentState().GetBalance(from).Cmp(total) < 0 {
return ErrInsufficientFunds
}
+ // Should supply enough intrinsic gas
if tx.GasLimit.Cmp(IntrinsicGas(tx)) < 0 {
return ErrIntrinsicGas
}
+ // Last but not least check for nonce errors (intensive
+ // operation, saved for last)
if pool.currentState().GetNonce(from) > tx.Nonce() {
return ErrNonce
}