diff options
| author | Felix Lange <fjl@twurst.com> | 2017-01-06 23:44:20 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@twurst.com> | 2017-01-07 01:18:07 +0800 |
| commit | f2da6581ba827a2aab091f764ace8017b26450d8 (patch) | |
| tree | 3bf7ed2ec48812064c5eb6191c9848ad7985561b /core/state | |
| parent | 35a7dcb162546f7f31cb6492f716cb93159218d7 (diff) | |
| download | dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.gz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.bz2 dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.lz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.xz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.zst dexon-f2da6581ba827a2aab091f764ace8017b26450d8.zip | |
all: fix issues reported by honnef.co/go/simple/cmd/gosimple
Diffstat (limited to 'core/state')
| -rw-r--r-- | core/state/iterator.go | 2 | ||||
| -rw-r--r-- | core/state/sync_test.go | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/core/state/iterator.go b/core/state/iterator.go index 14265b277..a58a15ad3 100644 --- a/core/state/iterator.go +++ b/core/state/iterator.go @@ -123,7 +123,7 @@ func (it *NodeIterator) step() error { if !it.dataIt.Next() { it.dataIt = nil } - if bytes.Compare(account.CodeHash, emptyCodeHash) != 0 { + if !bytes.Equal(account.CodeHash, emptyCodeHash) { it.codeHash = common.BytesToHash(account.CodeHash) it.code, err = it.state.db.Get(account.CodeHash) if err != nil { diff --git a/core/state/sync_test.go b/core/state/sync_test.go index cb585f78c..43d146e3a 100644 --- a/core/state/sync_test.go +++ b/core/state/sync_test.go @@ -84,7 +84,7 @@ func checkStateAccounts(t *testing.T, db ethdb.Database, root common.Hash, accou if nonce := state.GetNonce(acc.address); nonce != acc.nonce { t.Errorf("account %d: nonce mismatch: have %v, want %v", i, nonce, acc.nonce) } - if code := state.GetCode(acc.address); bytes.Compare(code, acc.code) != 0 { + if code := state.GetCode(acc.address); !bytes.Equal(code, acc.code) { t.Errorf("account %d: code mismatch: have %x, want %x", i, code, acc.code) } } @@ -294,7 +294,7 @@ func TestIncompleteStateSync(t *testing.T) { // Skim through the accounts and make sure the root hash is not a code node codeHash := false for _, acc := range srcAccounts { - if bytes.Compare(root.Bytes(), crypto.Sha3(acc.code)) == 0 { + if root == crypto.Keccak256Hash(acc.code) { codeHash = true break } |