diff options
author | Kyuntae Ethan Kim <ethan.kyuntae.kim@gmail.com> | 2018-03-07 18:05:14 +0800 |
---|---|---|
committer | Péter Szilágyi <peterke@gmail.com> | 2018-03-07 18:05:14 +0800 |
commit | 63687f04e441c97cbb39d6b0ebea346b154d2e73 (patch) | |
tree | b834a42f5ef84de9d3de307b980f83537befdf3b /core/blockchain.go | |
parent | d43ffdbf6a406839bbf54bdf76f5574345abdd57 (diff) | |
download | dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar.gz dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar.bz2 dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar.lz dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar.xz dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.tar.zst dexon-63687f04e441c97cbb39d6b0ebea346b154d2e73.zip |
core: check transaction/receipt count match when reconstructing blocks (#16272)
Diffstat (limited to 'core/blockchain.go')
-rw-r--r-- | core/blockchain.go | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/core/blockchain.go b/core/blockchain.go index 6006e6674..b33eb85a4 100644 --- a/core/blockchain.go +++ b/core/blockchain.go @@ -723,10 +723,13 @@ func (bc *BlockChain) Rollback(chain []common.Hash) { } // SetReceiptsData computes all the non-consensus fields of the receipts -func SetReceiptsData(config *params.ChainConfig, block *types.Block, receipts types.Receipts) { +func SetReceiptsData(config *params.ChainConfig, block *types.Block, receipts types.Receipts) error { signer := types.MakeSigner(config, block.Number()) transactions, logIndex := block.Transactions(), uint(0) + if len(transactions) != len(receipts) { + return errors.New("transaction and receipt count mismatch") + } for j := 0; j < len(receipts); j++ { // The transaction hash can be retrieved from the transaction itself @@ -754,6 +757,7 @@ func SetReceiptsData(config *params.ChainConfig, block *types.Block, receipts ty logIndex++ } } + return nil } // InsertReceiptChain attempts to complete an already existing header chain with @@ -794,7 +798,9 @@ func (bc *BlockChain) InsertReceiptChain(blockChain types.Blocks, receiptChain [ continue } // Compute all the non-consensus fields of the receipts - SetReceiptsData(bc.chainConfig, block, receipts) + if err := SetReceiptsData(bc.chainConfig, block, receipts); err != nil { + return i, fmt.Errorf("failed to set receipts data: %v", err) + } // Write all the data out into the database if err := WriteBody(batch, block.Hash(), block.NumberU64(), block.Body()); err != nil { return i, fmt.Errorf("failed to write block body: %v", err) |