diff options
author | Felix Lange <fjl@twurst.com> | 2017-01-06 23:44:20 +0800 |
---|---|---|
committer | Felix Lange <fjl@twurst.com> | 2017-01-07 01:18:07 +0800 |
commit | f2da6581ba827a2aab091f764ace8017b26450d8 (patch) | |
tree | 3bf7ed2ec48812064c5eb6191c9848ad7985561b /common | |
parent | 35a7dcb162546f7f31cb6492f716cb93159218d7 (diff) | |
download | dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.gz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.bz2 dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.lz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.xz dexon-f2da6581ba827a2aab091f764ace8017b26450d8.tar.zst dexon-f2da6581ba827a2aab091f764ace8017b26450d8.zip |
all: fix issues reported by honnef.co/go/simple/cmd/gosimple
Diffstat (limited to 'common')
-rw-r--r-- | common/big_test.go | 6 | ||||
-rw-r--r-- | common/bytes_test.go | 4 | ||||
-rw-r--r-- | common/compiler/solidity.go | 2 | ||||
-rw-r--r-- | common/format.go | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/common/big_test.go b/common/big_test.go index 1eb0c0c1f..4d04a8db3 100644 --- a/common/big_test.go +++ b/common/big_test.go @@ -27,7 +27,7 @@ func TestMisc(t *testing.T) { c := []byte{1, 2, 3, 4} z := BitTest(a, 1) - if z != true { + if !z { t.Error("Expected true got", z) } @@ -79,11 +79,11 @@ func TestBigCopy(t *testing.T) { z := BigToBytes(c, 16) zbytes := []byte{232, 212, 165, 16, 0} - if bytes.Compare(y, ybytes) != 0 { + if !bytes.Equal(y, ybytes) { t.Error("Got", ybytes) } - if bytes.Compare(z, zbytes) != 0 { + if !bytes.Equal(z, zbytes) { t.Error("Got", zbytes) } } diff --git a/common/bytes_test.go b/common/bytes_test.go index 2e5208477..98d402c48 100644 --- a/common/bytes_test.go +++ b/common/bytes_test.go @@ -181,7 +181,7 @@ func TestFromHex(t *testing.T) { input := "0x01" expected := []byte{1} result := FromHex(input) - if bytes.Compare(expected, result) != 0 { + if !bytes.Equal(expected, result) { t.Errorf("Expected % x got % x", expected, result) } } @@ -190,7 +190,7 @@ func TestFromHexOddLength(t *testing.T) { input := "0x1" expected := []byte{1} result := FromHex(input) - if bytes.Compare(expected, result) != 0 { + if !bytes.Equal(expected, result) { t.Errorf("Expected % x got % x", expected, result) } } diff --git a/common/compiler/solidity.go b/common/compiler/solidity.go index b0ca9bd75..d27bddd9f 100644 --- a/common/compiler/solidity.go +++ b/common/compiler/solidity.go @@ -32,7 +32,7 @@ import ( ) var ( - versionRegexp = regexp.MustCompile("[0-9]+\\.[0-9]+\\.[0-9]+") + versionRegexp = regexp.MustCompile(`[0-9]+\.[0-9]+\.[0-9]+`) solcParams = []string{ "--combined-json", "bin,abi,userdoc,devdoc", "--add-std", // include standard lib contracts diff --git a/common/format.go b/common/format.go index 119637d2e..fccc29962 100644 --- a/common/format.go +++ b/common/format.go @@ -27,7 +27,7 @@ import ( // the unnecessary precision off from the formatted textual representation. type PrettyDuration time.Duration -var prettyDurationRe = regexp.MustCompile("\\.[0-9]+") +var prettyDurationRe = regexp.MustCompile(`\.[0-9]+`) // String implements the Stringer interface, allowing pretty printing of duration // values rounded to three decimals. |