aboutsummaryrefslogtreecommitdiffstats
path: root/cmd
diff options
context:
space:
mode:
authorGustav Simonsson <gustav.simonsson@gmail.com>2015-04-21 00:14:57 +0800
committerGustav Simonsson <gustav.simonsson@gmail.com>2015-04-21 11:23:10 +0800
commitb448390889685fc87f221c152b16b82849f7797f (patch)
tree99ab2230d8c2b744bf2201368bce0f2045aab944 /cmd
parent805345d13594b41e5dd2e4fed471c58c3775be9e (diff)
downloaddexon-b448390889685fc87f221c152b16b82849f7797f.tar
dexon-b448390889685fc87f221c152b16b82849f7797f.tar.gz
dexon-b448390889685fc87f221c152b16b82849f7797f.tar.bz2
dexon-b448390889685fc87f221c152b16b82849f7797f.tar.lz
dexon-b448390889685fc87f221c152b16b82849f7797f.tar.xz
dexon-b448390889685fc87f221c152b16b82849f7797f.tar.zst
dexon-b448390889685fc87f221c152b16b82849f7797f.zip
Further fixes to block test wrapper
* Move go test wrapper for block tests from cmd/geth to tests * Fix logic for when tests are valid or not, by adding correct validations for expected valid/invalid blocks * Change block insertion helper to work on single blocks * Add one test case for each file in BlockTests and comment out the tests which are currently failing * Add Skip call in all block tests in lieu of performance fixes around ethash cache which are needed before it will be fast enough to start / stop the node between each test
Diffstat (limited to 'cmd')
-rw-r--r--cmd/geth/block_go_test.go80
-rw-r--r--cmd/geth/blocktest.go6
2 files changed, 3 insertions, 83 deletions
diff --git a/cmd/geth/block_go_test.go b/cmd/geth/block_go_test.go
deleted file mode 100644
index 1980e4798..000000000
--- a/cmd/geth/block_go_test.go
+++ /dev/null
@@ -1,80 +0,0 @@
-package main
-
-import (
- "path"
- "testing"
-
- "github.com/ethereum/go-ethereum/accounts"
- "github.com/ethereum/go-ethereum/common"
- "github.com/ethereum/go-ethereum/crypto"
- "github.com/ethereum/go-ethereum/eth"
- "github.com/ethereum/go-ethereum/ethdb"
- "github.com/ethereum/go-ethereum/tests"
-)
-
-// TODO: refactor test setup & execution to better align with vm and tx tests
-// TODO: refactor to avoid duplication with cmd/geth/blocktest.go
-func TestBcValidBlockTests(t *testing.T) {
- runBlockTestsInFile("../../tests/files/BlockTests/bcValidBlockTest.json", t)
-}
-
-/*
-func TestBcUncleTests(t *testing.T) {
- runBlockTestsInFile("../../tests/files/BlockTests/bcUncleTest.json", t)
-}
-*/
-
-func runBlockTestsInFile(filepath string, t *testing.T) {
- bt, err := tests.LoadBlockTests(filepath)
- if err != nil {
- t.Fatal(err)
- }
- for name, test := range bt {
- runTest(name, test, t)
- }
-}
-
-func runTest(name string, test *tests.BlockTest, t *testing.T) {
- t.Log("Running test: ", name)
- cfg := testEthConfig()
- ethereum, err := eth.New(cfg)
- if err != nil {
- t.Fatalf("%v", err)
- }
-
- err = ethereum.Start()
- if err != nil {
- t.Fatalf("%v", err)
- }
-
- // import the genesis block
- ethereum.ResetWithGenesisBlock(test.Genesis)
-
- // import pre accounts
- statedb, err := test.InsertPreState(ethereum.StateDb())
- if err != nil {
- t.Fatalf("InsertPreState: %v", err)
- }
-
- // insert the test blocks, which will execute all transactions
- if err := test.InsertBlocks(ethereum.ChainManager()); err != nil {
- t.Fatalf("Block Test load error: %v %T", err, err)
- }
-
- if err := test.ValidatePostState(statedb); err != nil {
- t.Fatal("post state validation failed: %v", err)
- }
- t.Log("Test passed: ", name)
-}
-
-func testEthConfig() *eth.Config {
- ks := crypto.NewKeyStorePassphrase(path.Join(common.DefaultDataDir(), "keys"))
-
- return &eth.Config{
- DataDir: common.DefaultDataDir(),
- LogLevel: 5,
- Etherbase: "primary",
- AccountManager: accounts.NewManager(ks),
- NewDB: func(path string) (common.Database, error) { return ethdb.NewMemDatabase() },
- }
-}
diff --git a/cmd/geth/blocktest.go b/cmd/geth/blocktest.go
index 792981ec0..343a0bf28 100644
--- a/cmd/geth/blocktest.go
+++ b/cmd/geth/blocktest.go
@@ -109,10 +109,10 @@ func runOneBlockTest(ctx *cli.Context, test *tests.BlockTest) (*eth.Ethereum, er
return ethereum, fmt.Errorf("InsertPreState: %v", err)
}
- // insert the test blocks, which will execute all transactions
- if err := test.InsertBlocks(ethereum.ChainManager()); err != nil {
- return ethereum, fmt.Errorf("Block Test load error: %v %T", err, err)
+ if err := test.TryBlocksInsert(ethereum.ChainManager()); err != nil {
+ return ethereum, fmt.Errorf("Block Test load error: %v", err)
}
+
fmt.Println("chain loaded")
if err := test.ValidatePostState(statedb); err != nil {
return ethereum, fmt.Errorf("post state validation failed: %v", err)