diff options
| author | bas-vk <bas-vk@users.noreply.github.com> | 2016-12-11 07:01:57 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@users.noreply.github.com> | 2016-12-11 07:01:57 +0800 |
| commit | 4f9ccdd70f69dd0a879329d57ec21588f29f182c (patch) | |
| tree | 485d305d44c364b93a4c6a06505803bb97ba70af /build/nsis.uninstall.nsh | |
| parent | 4e36b1e3dadda62a53e309a1b6cf7aed97ea7a3a (diff) | |
| download | dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.gz dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.bz2 dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.lz dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.xz dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.zst dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.zip | |
build: safe update of PATH on Windows (#3419)
NSIS has a default MAX_STR_LEN of 1024. If $ENV{PATH} is longer
the returned string is truncated to an empty string. Its then not
possible to distinguis between the variable not set or too long.
As a result the variable is set with the location where geth and/or
dev tools are installed. This may override any previous set values.
Diffstat (limited to 'build/nsis.uninstall.nsh')
| -rw-r--r-- | build/nsis.uninstall.nsh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/build/nsis.uninstall.nsh b/build/nsis.uninstall.nsh index ea7d5e298..6358faa74 100644 --- a/build/nsis.uninstall.nsh +++ b/build/nsis.uninstall.nsh @@ -25,7 +25,8 @@ Section "Uninstall" ${un.EnvVarUpdate} $0 "ETHEREUM_SOCKET" "R" "HKLM" "\\.\pipe\geth.ipc" # Remove install directory from PATH - ${un.EnvVarUpdate} $0 "PATH" "R" "HKLM" $INSTDIR + Push "$INSTDIR" + Call un.RemoveFromPath # Cleanup registry (deletes all sub keys) DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${GROUPNAME} ${APPNAME}" |