aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSam Boyer <tech@samboyer.org>2014-02-19 06:24:44 +0800
committerSam Boyer <tech@samboyer.org>2014-02-19 06:24:44 +0800
commit357b4bc14c82d206a8c813291fb3ead01ed29041 (patch)
tree75458eddf067d8943f7103ee4b713ff142bf3754
parent5adbd399463edc5ec800bdcf3524d64313c8add5 (diff)
downloaddexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar.gz
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar.bz2
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar.lz
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar.xz
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.tar.zst
dexon-357b4bc14c82d206a8c813291fb3ead01ed29041.zip
Add comment explaining why iota is not used.
-rw-r--r--ethwire/messaging.go3
-rw-r--r--peer.go3
2 files changed, 6 insertions, 0 deletions
diff --git a/ethwire/messaging.go b/ethwire/messaging.go
index 651bf4710..185faa341 100644
--- a/ethwire/messaging.go
+++ b/ethwire/messaging.go
@@ -19,6 +19,9 @@ var MagicToken = []byte{34, 64, 8, 145}
type MsgType byte
const (
+ // Values are given explicitly instead of by iota because these values are
+ // defined by the wire protocol spec; it is easier for humans to ensure
+ // correctness when values are explicit.
MsgHandshakeTy = 0x00
MsgDiscTy = 0x01
MsgPingTy = 0x02
diff --git a/peer.go b/peer.go
index e64b5b3bd..a6481e10c 100644
--- a/peer.go
+++ b/peer.go
@@ -23,6 +23,9 @@ const (
type DiscReason byte
const (
+ // Values are given explicitly instead of by iota because these values are
+ // defined by the wire protocol spec; it is easier for humans to ensure
+ // correctness when values are explicit.
DiscReRequested = 0x00
DiscReTcpSysErr = 0x01
DiscBadProto = 0x02