aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTing-Wei Lan <tingwei.lan@cobinhood.com>2019-02-21 16:00:23 +0800
committerJhih-Ming Huang <jm.huang@cobinhood.com>2019-04-11 10:39:58 +0800
commited9f627cb61facac163f00122148b898a5f9a007 (patch)
treeb8b9c375c9dfd72ccae1eec75ff1c6770c8eec9e
parentfb0aeb4e3aca16d6e5c14566e817b21c75e68e25 (diff)
downloaddexon-ed9f627cb61facac163f00122148b898a5f9a007.tar
dexon-ed9f627cb61facac163f00122148b898a5f9a007.tar.gz
dexon-ed9f627cb61facac163f00122148b898a5f9a007.tar.bz2
dexon-ed9f627cb61facac163f00122148b898a5f9a007.tar.lz
dexon-ed9f627cb61facac163f00122148b898a5f9a007.tar.xz
dexon-ed9f627cb61facac163f00122148b898a5f9a007.tar.zst
dexon-ed9f627cb61facac163f00122148b898a5f9a007.zip
core: vm: sqlvm: ast: remove pointer indicator in printer output
Since our 'Node' interface includes methods which must be implemented with pointer receivers, all AST nodes are now referenced with pointers and the '*' pointer indicator is no longer useful.
-rw-r--r--core/vm/sqlvm/ast/printer.go9
1 files changed, 4 insertions, 5 deletions
diff --git a/core/vm/sqlvm/ast/printer.go b/core/vm/sqlvm/ast/printer.go
index 56cfd07b9..e9b289411 100644
--- a/core/vm/sqlvm/ast/printer.go
+++ b/core/vm/sqlvm/ast/printer.go
@@ -44,18 +44,17 @@ func printAST(w io.Writer, n interface{}, depth int, base string, detail bool) {
}
typeOf := reflect.TypeOf(n)
valueOf := reflect.ValueOf(n)
- name := ""
- if typeOf.Kind() == reflect.Ptr {
+ kind := typeOf.Kind()
+ if kind == reflect.Ptr {
if valueOf.IsNil() {
fmt.Fprintf(w, "%snil\n", indent)
return
}
- name = "*"
valueOf = valueOf.Elem()
typeOf = typeOf.Elem()
+ kind = typeOf.Kind()
}
- kind := typeOf.Kind()
- name = name + typeOf.Name()
+ name := typeOf.Name()
if op, ok := n.(UnaryOperator); ok {
fmt.Fprintf(w, "%s%s:\n", indent, name)