aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPéter Szilágyi <peterke@gmail.com>2017-01-13 17:22:24 +0800
committerPéter Szilágyi <peterke@gmail.com>2017-01-13 17:22:24 +0800
commita2bc90d1d7ec796e51d8783a97558dfa4f2e7f45 (patch)
treedcf3b40866766b72b39cefb418cd22b6082d6e82
parentc01f8c3d3c286244292718133544e17be32000cc (diff)
downloaddexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar.gz
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar.bz2
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar.lz
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar.xz
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.tar.zst
dexon-a2bc90d1d7ec796e51d8783a97558dfa4f2e7f45.zip
build: spellcheck individual packages (Windows path limits)
-rw-r--r--build/ci.go16
1 files changed, 9 insertions, 7 deletions
diff --git a/build/ci.go b/build/ci.go
index 31c4885a3..152c86d1b 100644
--- a/build/ci.go
+++ b/build/ci.go
@@ -289,27 +289,29 @@ func doTest(cmdline []string) {
build.MustRun(goTool("vet", packages...))
}
if *misspell {
- // The spell checker doesn't work on packages, gather all .go files for it
- sources := []string{}
+ // Ensure the spellchecker is available
+ build.MustRun(goTool("get", "github.com/client9/misspell/cmd/misspell"))
+
+ // Windows (AppVeyor) chokes on long argument lists, check packages individualy
for _, pkg := range packages {
- // Gather all the source files of the package
+ // The spell checker doesn't work on packages, gather all .go files for it
out, err := goTool("list", "-f", "{{.Dir}}{{range .GoFiles}}\n{{.}}{{end}}{{range .CgoFiles}}\n{{.}}{{end}}{{range .TestGoFiles}}\n{{.}}{{end}}", pkg).CombinedOutput()
if err != nil {
log.Fatalf("source file listing failed: %v\n%s", err, string(out))
}
// Retrieve the folder and assemble the source list
lines := strings.Split(string(out), "\n")
-
root := lines[0]
+
+ sources := make([]string, 0, len(lines)-1)
for _, line := range lines[1:] {
if line = strings.TrimSpace(line); line != "" {
sources = append(sources, filepath.Join(root, line))
}
}
+ // Run the spell checker for this particular package
+ build.MustRunCommand(filepath.Join(GOBIN, "misspell"), append([]string{"-error"}, sources...)...)
}
- // Download the spell checker tool and run on all source files
- build.MustRun(goTool("get", "github.com/client9/misspell/cmd/misspell"))
- build.MustRunCommand(filepath.Join(GOBIN, "misspell"), append([]string{"-error"}, sources...)...)
}
// Run the actual tests.
gotest := goTool("test")